[INFO] fetching crate duplicate-finder 0.0.23... [INFO] checking duplicate-finder-0.0.23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate duplicate-finder 0.0.23 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate duplicate-finder 0.0.23 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate duplicate-finder 0.0.23 [INFO] finished tweaking crates.io crate duplicate-finder 0.0.23 [INFO] tweaked toml for crates.io crate duplicate-finder 0.0.23 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate duplicate-finder 0.0.23 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4ca76167f23cb1e977eaf7113a79ffab45aeb312c461131b8b04724442104a9 [INFO] running `Command { std: "docker" "start" "-a" "b4ca76167f23cb1e977eaf7113a79ffab45aeb312c461131b8b04724442104a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4ca76167f23cb1e977eaf7113a79ffab45aeb312c461131b8b04724442104a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4ca76167f23cb1e977eaf7113a79ffab45aeb312c461131b8b04724442104a9", kill_on_drop: false }` [INFO] [stdout] b4ca76167f23cb1e977eaf7113a79ffab45aeb312c461131b8b04724442104a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d49808fcd4fbb4b6eeba8240fdb29cc227d3966e6e0a05733b72231bf517a5e [INFO] running `Command { std: "docker" "start" "-a" "4d49808fcd4fbb4b6eeba8240fdb29cc227d3966e6e0a05733b72231bf517a5e", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking siphasher v0.3.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling test-case v0.3.3 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Checking duplicate-finder v0.0.23 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/convert.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | x if x < 0 => (0..(-x)).map({ |_| ' ' }).chain(chars).collect::(), [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 13 - x if x < 0 => (0..(-x)).map({ |_| ' ' }).chain(chars).collect::(), [INFO] [stdout] 13 + x if x < 0 => (0..(-x)).map(|_| ' ').chain(chars).collect::(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/convert.rs:13:37 [INFO] [stdout] | [INFO] [stdout] 13 | x if x < 0 => (0..(-x)).map({ |_| ' ' }).chain(chars).collect::(), [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 13 - x if x < 0 => (0..(-x)).map({ |_| ' ' }).chain(chars).collect::(), [INFO] [stdout] 13 + x if x < 0 => (0..(-x)).map(|_| ' ').chain(chars).collect::(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | fn to_json(vecs: Vec>) -> String { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | serde_json::to_string_pretty(&vecs).unwrap_or("".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|path_buf| (path_buf, sender.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|pair| CalculateHash::new(pair.0, pair.1).calculate()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_finder.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | fn convert_to_vec_and_retain(mut hash_map: HashMap>) -> Vec> { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | / hash_map [INFO] [stdout] 30 | | .drain() [INFO] [stdout] 31 | | .filter(|(_, vec)| vec.len() > 1) [INFO] [stdout] 32 | | .map(|(_, vec)| (vec)) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashing.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn send_output_msg(&mut self, progress: OutputMsg) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.sender.send(progress) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duplicate-finder` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 47 | fn to_json(vecs: Vec>) -> String { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | serde_json::to_string_pretty(&vecs).unwrap_or("".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:23:40 [INFO] [stdout] | [INFO] [stdout] 23 | .map(|path_buf| (path_buf, sender.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|pair| CalculateHash::new(pair.0, pair.1).calculate()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_finder.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | fn convert_to_vec_and_retain(mut hash_map: HashMap>) -> Vec> { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | / hash_map [INFO] [stdout] 30 | | .drain() [INFO] [stdout] 31 | | .filter(|(_, vec)| vec.len() > 1) [INFO] [stdout] 32 | | .map(|(_, vec)| (vec)) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashing.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn send_output_msg(&mut self, progress: OutputMsg) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.sender.send(progress) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duplicate-finder` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4d49808fcd4fbb4b6eeba8240fdb29cc227d3966e6e0a05733b72231bf517a5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d49808fcd4fbb4b6eeba8240fdb29cc227d3966e6e0a05733b72231bf517a5e", kill_on_drop: false }` [INFO] [stdout] 4d49808fcd4fbb4b6eeba8240fdb29cc227d3966e6e0a05733b72231bf517a5e