[INFO] fetching crate dumpster 1.0.0... [INFO] checking dumpster-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dumpster 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate dumpster 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dumpster 1.0.0 [INFO] finished tweaking crates.io crate dumpster 1.0.0 [INFO] tweaked toml for crates.io crate dumpster 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9af62bc067a780c7feaa61b07ba949befe101951117efefd9bb09cfa32e7d75f [INFO] running `Command { std: "docker" "start" "-a" "9af62bc067a780c7feaa61b07ba949befe101951117efefd9bb09cfa32e7d75f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9af62bc067a780c7feaa61b07ba949befe101951117efefd9bb09cfa32e7d75f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9af62bc067a780c7feaa61b07ba949befe101951117efefd9bb09cfa32e7d75f", kill_on_drop: false }` [INFO] [stdout] 9af62bc067a780c7feaa61b07ba949befe101951117efefd9bb09cfa32e7d75f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bec578407977a350ba375f420abee8c19e1665f59373579e6bcfd72f555fd657 [INFO] running `Command { std: "docker" "start" "-a" "bec578407977a350ba375f420abee8c19e1665f59373579e6bcfd72f555fd657", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling dumpster_derive v1.0.0 [INFO] [stderr] Checking dumpster v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:233:72 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn new(value: T) -> Gc [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | ptr: UnsafeCell::new(Nullable::new(NonNull::from(Box::leak(Box::new(GcBox { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 234 | | strong: AtomicUsize::new(1), [INFO] [stdout] 235 | | weak: AtomicUsize::new(0), [INFO] [stdout] 236 | | generation: AtomicUsize::new(CURRENT_TAG.load(Ordering::Acquire)), [INFO] [stdout] 237 | | value, [INFO] [stdout] 238 | | }))))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/collect.rs:134:37 [INFO] [stdout] | [INFO] [stdout] 134 | DUMPSTER.with(|d| d.deliver_to(&GARBAGE_TRUCK)); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unsync/mod.rs:218:66 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn new(value: T) -> Gc [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | ptr: Cell::new(Nullable::new(NonNull::from(Box::leak(Box::new(GcBox { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 219 | | ref_count: Cell::new(NonZeroUsize::MIN), [INFO] [stdout] 220 | | value, [INFO] [stdout] 221 | | }))))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dumpster` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:233:72 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn new(value: T) -> Gc [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | ptr: UnsafeCell::new(Nullable::new(NonNull::from(Box::leak(Box::new(GcBox { [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 234 | | strong: AtomicUsize::new(1), [INFO] [stdout] 235 | | weak: AtomicUsize::new(0), [INFO] [stdout] 236 | | generation: AtomicUsize::new(CURRENT_TAG.load(Ordering::Acquire)), [INFO] [stdout] 237 | | value, [INFO] [stdout] 238 | | }))))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/collect.rs:134:37 [INFO] [stdout] | [INFO] [stdout] 134 | DUMPSTER.with(|d| d.deliver_to(&GARBAGE_TRUCK)); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unsync/mod.rs:218:66 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn new(value: T) -> Gc [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | ptr: Cell::new(Nullable::new(NonNull::from(Box::leak(Box::new(GcBox { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 219 | | ref_count: Cell::new(NonZeroUsize::MIN), [INFO] [stdout] 220 | | value, [INFO] [stdout] 221 | | }))))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unsync/tests.rs:296:26 [INFO] [stdout] | [INFO] [stdout] 296 | ESCAPED.with(|e| e.lock().unwrap().as_ref().unwrap().x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dumpster` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bec578407977a350ba375f420abee8c19e1665f59373579e6bcfd72f555fd657", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bec578407977a350ba375f420abee8c19e1665f59373579e6bcfd72f555fd657", kill_on_drop: false }` [INFO] [stdout] bec578407977a350ba375f420abee8c19e1665f59373579e6bcfd72f555fd657