[INFO] fetching crate dummy_xml 0.1.6... [INFO] checking dummy_xml-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dummy_xml 0.1.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dummy_xml 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dummy_xml 0.1.6 [INFO] finished tweaking crates.io crate dummy_xml 0.1.6 [INFO] tweaked toml for crates.io crate dummy_xml 0.1.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1c575b0c97ac9e5f6dd1c4952ac4cb546628a452f2b4ccf0cf06274d74fa58b [INFO] running `Command { std: "docker" "start" "-a" "f1c575b0c97ac9e5f6dd1c4952ac4cb546628a452f2b4ccf0cf06274d74fa58b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1c575b0c97ac9e5f6dd1c4952ac4cb546628a452f2b4ccf0cf06274d74fa58b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1c575b0c97ac9e5f6dd1c4952ac4cb546628a452f2b4ccf0cf06274d74fa58b", kill_on_drop: false }` [INFO] [stdout] f1c575b0c97ac9e5f6dd1c4952ac4cb546628a452f2b4ccf0cf06274d74fa58b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c85d662d527ceef69e056948e3831ef1695b1ddb2c40bbb48c950f1e5bc2b375 [INFO] running `Command { std: "docker" "start" "-a" "c85d662d527ceef69e056948e3831ef1695b1ddb2c40bbb48c950f1e5bc2b375", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking dummy_xml v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new>(name: S, value: S) -> Box { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Box::new(Attribute { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | name: name.into(), [INFO] [stdout] 42 | | value: value.into(), [INFO] [stdout] 43 | | next: None, [INFO] [stdout] 44 | | prev: ptr::null_mut(), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:82:52 [INFO] [stdout] | [INFO] [stdout] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new>(name: S) -> Box { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 104 | | name: Cow::Owned(name.into()), [INFO] [stdout] 105 | | node_type: NodeType::Element, [INFO] [stdout] 106 | | value: EMPTY_STRING, [INFO] [stdout] ... | [INFO] [stdout] 113 | | last_attr: ptr::null_mut(), [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:208:58 [INFO] [stdout] | [INFO] [stdout] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Node<'_>` does not implement `Borrow`, so calling `borrow` on `&Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Attribute` does not implement `Borrow`, so calling `borrow` on `&Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new>(name: S, value: S) -> Box { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Box::new(Attribute { [INFO] [stdout] | __________________^ [INFO] [stdout] 41 | | name: name.into(), [INFO] [stdout] 42 | | value: value.into(), [INFO] [stdout] 43 | | next: None, [INFO] [stdout] 44 | | prev: ptr::null_mut(), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dummy_xml` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:82:52 [INFO] [stdout] | [INFO] [stdout] 82 | unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 82 - unsafe { self.prev.as_ref().map(|attr| attr.borrow()) } [INFO] [stdout] 82 + unsafe { self.prev.as_ref().map(|attr| attr) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new>(name: S) -> Box { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 104 | | name: Cow::Owned(name.into()), [INFO] [stdout] 105 | | node_type: NodeType::Element, [INFO] [stdout] 106 | | value: EMPTY_STRING, [INFO] [stdout] ... | [INFO] [stdout] 113 | | last_attr: ptr::null_mut(), [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:178:52 [INFO] [stdout] | [INFO] [stdout] 178 | unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 178 - unsafe { self.prev.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 178 + unsafe { self.prev.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:188:54 [INFO] [stdout] | [INFO] [stdout] 188 | unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 188 - unsafe { self.parent.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 188 + unsafe { self.parent.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:208:58 [INFO] [stdout] | [INFO] [stdout] 208 | unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Node<'_>` does not implement `Borrow`, so calling `borrow` on `&node::Node<'_>` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 208 - unsafe { self.last_child.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 208 + unsafe { self.last_child.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Node<'_>`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Clone)] [INFO] [stdout] 25 | pub struct Node<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node.rs:228:57 [INFO] [stdout] | [INFO] [stdout] 228 | unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `node::Attribute` does not implement `Borrow`, so calling `borrow` on `&node::Attribute` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 228 - unsafe { self.last_attr.as_ref().map(|node| node.borrow()) } [INFO] [stdout] 228 + unsafe { self.last_attr.as_ref().map(|node| node) } [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `node::Attribute`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Clone)] [INFO] [stdout] 6 | pub struct Attribute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dummy_xml` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c85d662d527ceef69e056948e3831ef1695b1ddb2c40bbb48c950f1e5bc2b375", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c85d662d527ceef69e056948e3831ef1695b1ddb2c40bbb48c950f1e5bc2b375", kill_on_drop: false }` [INFO] [stdout] c85d662d527ceef69e056948e3831ef1695b1ddb2c40bbb48c950f1e5bc2b375