[INFO] fetching crate dull-dotfile-manager 0.1.1... [INFO] checking dull-dotfile-manager-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dull-dotfile-manager 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dull-dotfile-manager 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dull-dotfile-manager 0.1.1 [INFO] finished tweaking crates.io crate dull-dotfile-manager 0.1.1 [INFO] tweaked toml for crates.io crate dull-dotfile-manager 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate dull-dotfile-manager 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55486f0382a4069e08d4e36bcd958b6836ba7cb8a4f339d2c608a494c69e0900 [INFO] running `Command { std: "docker" "start" "-a" "55486f0382a4069e08d4e36bcd958b6836ba7cb8a4f339d2c608a494c69e0900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55486f0382a4069e08d4e36bcd958b6836ba7cb8a4f339d2c608a494c69e0900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55486f0382a4069e08d4e36bcd958b6836ba7cb8a4f339d2c608a494c69e0900", kill_on_drop: false }` [INFO] [stdout] 55486f0382a4069e08d4e36bcd958b6836ba7cb8a4f339d2c608a494c69e0900 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d8f609e29733f0f6ba190bc1a670d2b647cae572d1afcdccdb7845510bf1ecc [INFO] running `Command { std: "docker" "start" "-a" "7d8f609e29733f0f6ba190bc1a670d2b647cae572d1afcdccdb7845510bf1ecc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking winnow v0.5.19 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking gethostname v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.192 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking pwd v1.4.0 [INFO] [stderr] Checking expanduser v1.2.2 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking dull-dotfile-manager v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `tx_apply::*` [INFO] [stdout] --> src/transaction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use tx_apply::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tx_apply::*` [INFO] [stdout] --> src/transaction.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use tx_apply::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_parser.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|include_config| (read_config(&include_config.path), &include_config.path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 60 | let tx_file = std::fs::File::open(&path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | .context(format!("could not read the transaction file at {:?}", path))?; [INFO] [stdout] 62 | let tx_rd = std::io::BufReader::new(tx_file); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | serde_json::from_reader(tx_rd).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction/tx_builder.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn build>(self, name: S) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Transaction::generate(name.clone(), primitives) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction/tx_gen.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | .filter(|subdir| !subdir.symlink_metadata().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dull-dotfile-manager` (bin "dull") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_parser.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|include_config| (read_config(&include_config.path), &include_config.path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 60 | let tx_file = std::fs::File::open(&path) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | .context(format!("could not read the transaction file at {:?}", path))?; [INFO] [stdout] 62 | let tx_rd = std::io::BufReader::new(tx_file); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | serde_json::from_reader(tx_rd).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction/tx_builder.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn build>(self, name: S) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Transaction::generate(name.clone(), primitives) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction/tx_gen.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | .filter(|subdir| !subdir.symlink_metadata().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dull-dotfile-manager` (bin "dull" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7d8f609e29733f0f6ba190bc1a670d2b647cae572d1afcdccdb7845510bf1ecc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d8f609e29733f0f6ba190bc1a670d2b647cae572d1afcdccdb7845510bf1ecc", kill_on_drop: false }` [INFO] [stdout] 7d8f609e29733f0f6ba190bc1a670d2b647cae572d1afcdccdb7845510bf1ecc