[INFO] fetching crate duct 0.13.7... [INFO] checking duct-0.13.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate duct 0.13.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate duct 0.13.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate duct 0.13.7 [INFO] finished tweaking crates.io crate duct 0.13.7 [INFO] tweaked toml for crates.io crate duct 0.13.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate duct 0.13.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f801749e659e79e6d67986ed65cf8ff2fa2956d9d2869238c3ffcd3ae68da9ed [INFO] running `Command { std: "docker" "start" "-a" "f801749e659e79e6d67986ed65cf8ff2fa2956d9d2869238c3ffcd3ae68da9ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f801749e659e79e6d67986ed65cf8ff2fa2956d9d2869238c3ffcd3ae68da9ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f801749e659e79e6d67986ed65cf8ff2fa2956d9d2869238c3ffcd3ae68da9ed", kill_on_drop: false }` [INFO] [stdout] f801749e659e79e6d67986ed65cf8ff2fa2956d9d2869238c3ffcd3ae68da9ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5ac05e152141c7cba6f2e76ce7f5d0ddcd8b09d219b4667500d419e07edce3a [INFO] running `Command { std: "docker" "start" "-a" "e5ac05e152141c7cba6f2e76ce7f5d0ddcd8b09d219b4667500d419e07edce3a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking shared_child v1.0.0 [INFO] [stderr] Checking os_pipe v1.1.4 [INFO] [stderr] Checking duct v0.13.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn cmd(program: T, args: U) -> Expression [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Expression::new(Cmd(argv_vec)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 309 | let stdout_capture = OutputCaptureContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let stderr_capture = OutputCaptureContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | let context = IoContext::new(&stdout_capture, &stderr_capture); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | [INFO] [stdout] 313 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 314 | | inner: self.0.start(context)?, [INFO] [stdout] 315 | | result: OnceCell::new(), [INFO] [stdout] 316 | | readers: Mutex::new(( [INFO] [stdout] ... | [INFO] [stdout] 319 | | )), [INFO] [stdout] 320 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 352 | let stdout_capture = OutputCaptureContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | let stderr_capture = OutputCaptureContext::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let context = IoContext::new(&stdout_capture, &stderr_capture); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | let handle = Handle { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok(ReaderHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 361 | | handle, [INFO] [stdout] 362 | | reader: stdout_capture.pair.into_inner().expect("pipe opened").0, [INFO] [stdout] 363 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:395:19 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn pipe>(&self, right: T) -> Expression { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 395 | Self::new(Pipe(self.clone(), right.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:418:19 [INFO] [stdout] | [INFO] [stdout] 417 | pub fn stdin_bytes>>(&self, bytes: T) -> Expression { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Self::new(Io(StdinBytes(Arc::new(bytes.into())), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:437:19 [INFO] [stdout] | [INFO] [stdout] 436 | pub fn stdin_path>(&self, path: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | Self::new(Io(StdinPath(path.into()), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:19 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn stdin_file(&self, file: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | Self::new(Io(StdinFile(into_file(file)), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:500:19 [INFO] [stdout] | [INFO] [stdout] 499 | pub fn stdout_path>(&self, path: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 500 | Self::new(Io(StdoutPath(path.into()), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:523:19 [INFO] [stdout] | [INFO] [stdout] 522 | pub fn stdout_file(&self, file: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 523 | Self::new(Io(StdoutFile(into_file(file)), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:620:19 [INFO] [stdout] | [INFO] [stdout] 619 | pub fn stderr_path>(&self, path: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 620 | Self::new(Io(StderrPath(path.into()), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:643:19 [INFO] [stdout] | [INFO] [stdout] 642 | pub fn stderr_file(&self, file: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | Self::new(Io(StderrFile(into_file(file)), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:764:19 [INFO] [stdout] | [INFO] [stdout] 763 | pub fn dir>(&self, path: T) -> Expression { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 764 | Self::new(Io(Dir(path.into()), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:785:19 [INFO] [stdout] | [INFO] [stdout] 780 | pub fn env(&self, name: T, val: U) -> Expression [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 785 | Self::new(Io( [INFO] [stdout] | ___________________^ [INFO] [stdout] 786 | | Env(canonicalize_env_var_name(name.into()), val.into()), [INFO] [stdout] 787 | | self.clone(), [INFO] [stdout] 788 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:817:19 [INFO] [stdout] | [INFO] [stdout] 813 | pub fn env_remove(&self, name: T) -> Expression [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 817 | Self::new(Io( [INFO] [stdout] | ___________________^ [INFO] [stdout] 818 | | EnvRemove(canonicalize_env_var_name(name.into())), [INFO] [stdout] 819 | | self.clone(), [INFO] [stdout] 820 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:857:19 [INFO] [stdout] | [INFO] [stdout] 847 | pub fn full_env(&self, name_vals: T) -> Expression [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 857 | Self::new(Io(FullEnv(env_map), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:931:19 [INFO] [stdout] | [INFO] [stdout] 927 | pub fn before_spawn(&self, hook: F) -> Expression [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 931 | Self::new(Io(BeforeSpawn(BeforeSpawnHook::new(hook)), self.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:935:20 [INFO] [stdout] | [INFO] [stdout] 934 | fn new(inner: ExpressionInner) -> Expression { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 935 | Expression(Arc::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1119:22 [INFO] [stdout] | [INFO] [stdout] 1119 | .map(|t| t.join().expect("stdout reader error")) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1123:22 [INFO] [stdout] | [INFO] [stdout] 1123 | .map(|t| t.join().expect("stderr reader error")) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1143:12 [INFO] [stdout] | [INFO] [stdout] 1142 | fn start(&self, context: IoContext) -> io::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1143 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1144 | | Cmd(argv) => HandleInner::Child(start_argv(argv, context)?), [INFO] [stdout] 1145 | | Pipe(left, right) => { [INFO] [stdout] 1146 | | HandleInner::Pipe(Box::new(PipeHandle::start(left, right, context)?)) [INFO] [stdout] 1147 | | } [INFO] [stdout] 1148 | | Io(io_inner, expr) => start_io(io_inner, expr, context)?, [INFO] [stdout] 1149 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1225:8 [INFO] [stdout] | [INFO] [stdout] 1199 | fn start_argv(argv: &[OsString], context: IoContext) -> io::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1200 | let exe = canonicalize_exe_path_for_dir(&argv[0], &context)?; [INFO] [stdout] 1201 | let mut command = Command::new(exe); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1223 | let shared_child = SharedChild::spawn(&mut command)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1224 | let command_string = format!("{:?}", argv); [INFO] [stdout] 1225 | Ok(ChildHandle { [INFO] [stdout] | ________^ [INFO] [stdout] 1226 | | child: shared_child, [INFO] [stdout] 1227 | | command_string, [INFO] [stdout] 1228 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1453:12 [INFO] [stdout] | [INFO] [stdout] 1444 | mut context: IoContext, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1445 | input: Arc>, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1446 | ) -> io::Result { [INFO] [stdout] 1447 | let (reader, mut writer) = os_pipe::pipe()?; [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1448 | context.stdin = IoValue::Handle(into_file(reader)); [INFO] [stdout] 1449 | let inner = expression.0.start(context)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1452 | let thread = std::thread::spawn(move || writer.write_all(&input)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1453 | Ok(StdinBytesHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 1454 | | inner_handle: inner, [INFO] [stdout] 1455 | | writer_thread: SharedThread::new(thread), [INFO] [stdout] 1456 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1525:20 [INFO] [stdout] | [INFO] [stdout] 1520 | fn new(hook: F) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1525 | inner: Arc::new(hook), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1611:12 [INFO] [stdout] | [INFO] [stdout] 1610 | fn into_stdio(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1611 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1612 | | IoValue::ParentStdin => os_pipe::dup_stdin()?.into(), [INFO] [stdout] 1613 | | IoValue::ParentStdout => os_pipe::dup_stdout()?.into(), [INFO] [stdout] 1614 | | IoValue::ParentStderr => os_pipe::dup_stderr()?.into(), [INFO] [stdout] 1615 | | IoValue::Null => Stdio::null(), [INFO] [stdout] 1616 | | IoValue::Handle(f) => f.into(), [INFO] [stdout] 1617 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1817:21 [INFO] [stdout] | [INFO] [stdout] 1815 | fn new(handle: JoinHandle) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1816 | SharedThread { [INFO] [stdout] 1817 | result: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1818:21 [INFO] [stdout] | [INFO] [stdout] 1815 | fn new(handle: JoinHandle) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1818 | handle: Mutex::new(Some(handle)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duct` (lib) due to 27 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e5ac05e152141c7cba6f2e76ce7f5d0ddcd8b09d219b4667500d419e07edce3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5ac05e152141c7cba6f2e76ce7f5d0ddcd8b09d219b4667500d419e07edce3a", kill_on_drop: false }` [INFO] [stdout] e5ac05e152141c7cba6f2e76ce7f5d0ddcd8b09d219b4667500d419e07edce3a