[INFO] fetching crate duckdb-extension-framework 0.7.0... [INFO] checking duckdb-extension-framework-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate duckdb-extension-framework 0.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate duckdb-extension-framework 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate duckdb-extension-framework 0.7.0 [INFO] finished tweaking crates.io crate duckdb-extension-framework 0.7.0 [INFO] tweaked toml for crates.io crate duckdb-extension-framework 0.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.61.0 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b79fafe271faa48c3395cc2befd09f066ec82f25ecb4fcc65bd31220bf66542c [INFO] running `Command { std: "docker" "start" "-a" "b79fafe271faa48c3395cc2befd09f066ec82f25ecb4fcc65bd31220bf66542c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b79fafe271faa48c3395cc2befd09f066ec82f25ecb4fcc65bd31220bf66542c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b79fafe271faa48c3395cc2befd09f066ec82f25ecb4fcc65bd31220bf66542c", kill_on_drop: false }` [INFO] [stdout] b79fafe271faa48c3395cc2befd09f066ec82f25ecb4fcc65bd31220bf66542c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 083f2bc76e6ebf9bf51bc3bb5b8e691c32a61dcd0a8c92b8fc51c7bf8f2edc53 [INFO] running `Command { std: "docker" "start" "-a" "083f2bc76e6ebf9bf51bc3bb5b8e691c32a61dcd0a8c92b8fc51c7bf8f2edc53", kill_on_drop: false }` [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bindgen v0.61.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling build_script v0.2.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling duckdb-extension-framework v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | let filename = CString::new(":memory:")?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Self(Owned(db))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 41 | let error = CString::new("")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let filename = CString::new(":memory:")?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self(Owned(db))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logical_type.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/logical_type.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | duckdb_bind_add_result_column(self.ptr, as_string!(column_name), column_type.typ); [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | duckdb_bind_set_error(self.ptr, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/function_info.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | duckdb_function_set_error(self.0, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duckdb-extension-framework` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | let filename = CString::new(":memory:")?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(Self(Owned(db))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 41 | let error = CString::new("")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let filename = CString::new(":memory:")?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self(Owned(db))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logical_type.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&str` instead of dereferencing the inner type [INFO] [stdout] --> src/logical_type.rs:75:38 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|it| CString::new(it.deref()).unwrap()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:26:53 [INFO] [stdout] | [INFO] [stdout] 26 | duckdb_bind_add_result_column(self.ptr, as_string!(column_name), column_type.typ); [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/bind_info.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | duckdb_bind_set_error(self.ptr, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/error.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 15 | / std::ffi::CString::new($x) [INFO] [stdout] 16 | | .expect("c string") [INFO] [stdout] | |_______________________________- this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] 17 | .as_ptr() [INFO] [stdout] | ^^^^^^ this pointer will be invalid [INFO] [stdout] | [INFO] [stdout] ::: src/table_functions/function_info.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | duckdb_function_set_error(self.0, as_string!(error)); [INFO] [stdout] | ----------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: this warning originates in the macro `as_string` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duckdb-extension-framework` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "083f2bc76e6ebf9bf51bc3bb5b8e691c32a61dcd0a8c92b8fc51c7bf8f2edc53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "083f2bc76e6ebf9bf51bc3bb5b8e691c32a61dcd0a8c92b8fc51c7bf8f2edc53", kill_on_drop: false }` [INFO] [stdout] 083f2bc76e6ebf9bf51bc3bb5b8e691c32a61dcd0a8c92b8fc51c7bf8f2edc53