[INFO] fetching crate duat-term 0.1.3... [INFO] checking duat-term-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate duat-term 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate duat-term 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate duat-term 0.1.3 [INFO] finished tweaking crates.io crate duat-term 0.1.3 [INFO] tweaked toml for crates.io crate duat-term 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 828bc4a36288c125b7f42e0e661f18aad5a4867b11ab64abd6b4a2a842a9a613 [INFO] running `Command { std: "docker" "start" "-a" "828bc4a36288c125b7f42e0e661f18aad5a4867b11ab64abd6b4a2a842a9a613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "828bc4a36288c125b7f42e0e661f18aad5a4867b11ab64abd6b4a2a842a9a613", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "828bc4a36288c125b7f42e0e661f18aad5a4867b11ab64abd6b4a2a842a9a613", kill_on_drop: false }` [INFO] [stdout] 828bc4a36288c125b7f42e0e661f18aad5a4867b11ab64abd6b4a2a842a9a613 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46d481f389cc189d7301a1ee0e5a0253073baec02b96784f50aed35e140e5d30 [INFO] running `Command { std: "docker" "start" "-a" "46d481f389cc189d7301a1ee0e5a0253073baec02b96784f50aed35e140e5d30", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking gapbuf v0.1.4 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking duat-core v0.1.3 [INFO] [stderr] Checking duat-term v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut layout = self.layout.write(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Area::new(child, self.layout.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut layout = self.layout.write(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:51 [INFO] [stdout] | [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:67:24 [INFO] [stdout] | [INFO] [stdout] 55 | iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 68 | | if let Some(unit) = finished_word.pop() { [INFO] [stdout] 69 | | return attach_caret( [INFO] [stdout] 70 | | (&mut x, &mut needs_to_wrap, &mut prev_char), [INFO] [stdout] ... | [INFO] [stdout] 105 | | }) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:251:24 [INFO] [stdout] | [INFO] [stdout] 244 | mut iter: RevTextIter<'a>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 252 | | if let Some(next) = returns.pop() { [INFO] [stdout] 253 | | Some(next) [INFO] [stdout] 254 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/rect.rs:478:9 [INFO] [stdout] | [INFO] [stdout] 459 | let equality = match constraint { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | / length [INFO] [stdout] 479 | | .constraint [INFO] [stdout] 480 | | .replace((equality, (constraint, axis))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/print/mod.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 124 | let (map, solver, max) = { [INFO] [stdout] | --- ------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let mut solver = Solver::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let max = VarPoint::new_from_hash_map(&mut map); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | recvs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duat-term` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut layout = self.layout.write(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Area::new(child, self.layout.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut layout = self.layout.write(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/mod.rs:354:51 [INFO] [stdout] | [INFO] [stdout] 354 | parent.map(|parent| Area::new(parent, self.layout.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:67:24 [INFO] [stdout] | [INFO] [stdout] 55 | iter: impl Iterator + Clone + 'a, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut iter = iter.peekable(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 68 | | if let Some(unit) = finished_word.pop() { [INFO] [stdout] 69 | | return attach_caret( [INFO] [stdout] 70 | | (&mut x, &mut needs_to_wrap, &mut prev_char), [INFO] [stdout] ... | [INFO] [stdout] 105 | | }) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/area/iter.rs:251:24 [INFO] [stdout] | [INFO] [stdout] 244 | mut iter: RevTextIter<'a>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | std::iter::from_fn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 252 | | if let Some(next) = returns.pop() { [INFO] [stdout] 253 | | Some(next) [INFO] [stdout] 254 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layout/rect.rs:478:9 [INFO] [stdout] | [INFO] [stdout] 459 | let equality = match constraint { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 478 | / length [INFO] [stdout] 479 | | .constraint [INFO] [stdout] 480 | | .replace((equality, (constraint, axis))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/print/mod.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 124 | let (map, solver, max) = { [INFO] [stdout] | --- ------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let mut solver = Solver::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let max = VarPoint::new_from_hash_map(&mut map); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | recvs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `duat-term` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "46d481f389cc189d7301a1ee0e5a0253073baec02b96784f50aed35e140e5d30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46d481f389cc189d7301a1ee0e5a0253073baec02b96784f50aed35e140e5d30", kill_on_drop: false }` [INFO] [stdout] 46d481f389cc189d7301a1ee0e5a0253073baec02b96784f50aed35e140e5d30