[INFO] fetching crate dualsense-rs 0.6.0... [INFO] checking dualsense-rs-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dualsense-rs 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate dualsense-rs 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dualsense-rs 0.6.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate dualsense-rs 0.6.0 [INFO] tweaked toml for crates.io crate dualsense-rs 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate dualsense-rs 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7832c1e55eba177c141cf00c05abc370eaa0fdd396fcd3a45f7c2bcec62fadc3 [INFO] running `Command { std: "docker" "start" "-a" "7832c1e55eba177c141cf00c05abc370eaa0fdd396fcd3a45f7c2bcec62fadc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7832c1e55eba177c141cf00c05abc370eaa0fdd396fcd3a45f7c2bcec62fadc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7832c1e55eba177c141cf00c05abc370eaa0fdd396fcd3a45f7c2bcec62fadc3", kill_on_drop: false }` [INFO] [stdout] 7832c1e55eba177c141cf00c05abc370eaa0fdd396fcd3a45f7c2bcec62fadc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0390908d18ee26ef7c4e046c2d05ad458feb8360c75bb8b1159fa59c39f6f27 [INFO] running `Command { std: "docker" "start" "-a" "a0390908d18ee26ef7c4e046c2d05ad458feb8360c75bb8b1159fa59c39f6f27", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling hidapi v2.4.1 [INFO] [stderr] Checking dualsense-rs v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/dualsense/stream.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/dualsense/stream.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/dualsense/stream.rs:725:38 [INFO] [stdout] | [INFO] [stdout] 725 | .push(Box::new(move |x| {})); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `duration` [INFO] [stdout] --> src/dualsense/properties/combo_builder.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn cooldown(self, duration: Duration) -> Self { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_duration` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `register_pad` is never used [INFO] [stdout] --> src/dualsense/stream.rs:396:8 [INFO] [stdout] | [INFO] [stdout] 44 | impl DualSense { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 396 | fn register_pad(&mut self, prop: ComboProperty, mut cb: Box) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Callback` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | enum Callback { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackU8` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | trait ToCallbackU8 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackU16` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | trait ToCallbackU16 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackDPad` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | trait ToCallbackDPad { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackSymbols` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | trait ToCallbackSymbols { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `offset` and `convert` are never used [INFO] [stdout] --> src/dualsense/properties/property.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 47 | impl InputProperty { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] 48 | pub(crate) fn offset(&self) -> Offset { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub(crate) fn convert(&self, data: &[u8]) -> ValueType { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gyro_accel_into_u16` is never used [INFO] [stdout] --> src/dualsense/properties/property.rs:130:4 [INFO] [stdout] | [INFO] [stdout] 130 | fn gyro_accel_into_u16(data: &[u8]) -> i16 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) enum ValueType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 7 | U8(u8), [INFO] [stdout] | ^^ [INFO] [stdout] 8 | U16(u16), [INFO] [stdout] | ^^^ [INFO] [stdout] 9 | I16(i16), [INFO] [stdout] | ^^^ [INFO] [stdout] 10 | Pad(DPad), [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | Symbol(Symbols), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 12 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | Combo(ComboProperty), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ValueType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `NewValueType` is never used [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) enum NewValueType { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_dpad`, `to_symbol`, `to_combo`, `to_analog`, and `to_trigger` are never used [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 21 | impl ValueType { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub(crate) fn to_dpad(self) -> DPad { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub(crate) fn to_symbol(self) -> Symbols { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub(crate) fn to_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub(crate) fn to_analog(self) -> AnalogPad { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | pub(crate) fn to_trigger(self) -> Trigger { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `QUADRANT_ANGLE` is never used [INFO] [stdout] --> src/dualsense/properties/analog_pad.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const QUADRANT_ANGLE: u8 = 90; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_left_combo` and `to_right_combo` are never used [INFO] [stdout] --> src/dualsense/properties/analog_pad.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 14 | impl AnalogPad { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 59 | pub(crate) fn to_left_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub(crate) fn to_right_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/stream.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 82 | let device = Arc::clone(&self.device); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let callbacks_v2 = Arc::clone(&self.callbacks_v2); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let cache_v2 = Arc::clone(&self.callback_cache_v2); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let output_cache = Arc::clone(&self.output_cache); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let output_cache_changed = Arc::clone(&self.output_cache_changed); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let combos = Arc::clone(&self.combos); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 90 | | let mut buf = [0u8; PACKET_SIZE]; [INFO] [stdout] 91 | | let bytes_read = device.lock().unwrap().read(&mut buf); [INFO] [stdout] 92 | | match bytes_read { [INFO] [stdout] ... | [INFO] [stdout] 114 | | sleep(Duration::from_millis(50)); [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 30 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Callback::FromU8(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Callback::FromU16(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 48 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Callback::FromDPad(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 57 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Callback::FromSymbols(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/dualsense/stream.rs:725:38 [INFO] [stdout] | [INFO] [stdout] 725 | .push(Box::new(move |x| {})); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dualsense-rs` (lib) due to 6 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `duration` [INFO] [stdout] --> src/dualsense/properties/combo_builder.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn cooldown(self, duration: Duration) -> Self { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_duration` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `register_pad` is never used [INFO] [stdout] --> src/dualsense/stream.rs:396:8 [INFO] [stdout] | [INFO] [stdout] 44 | impl DualSense { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 396 | fn register_pad(&mut self, prop: ComboProperty, mut cb: Box) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Callback` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | enum Callback { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackU8` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | trait ToCallbackU8 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackU16` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | trait ToCallbackU16 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackDPad` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | trait ToCallbackDPad { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ToCallbackSymbols` is never used [INFO] [stdout] --> src/dualsense/callback_helpers.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | trait ToCallbackSymbols { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `offset` and `convert` are never used [INFO] [stdout] --> src/dualsense/properties/property.rs:48:19 [INFO] [stdout] | [INFO] [stdout] 47 | impl InputProperty { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] 48 | pub(crate) fn offset(&self) -> Offset { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub(crate) fn convert(&self, data: &[u8]) -> ValueType { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gyro_accel_into_u16` is never used [INFO] [stdout] --> src/dualsense/properties/property.rs:130:4 [INFO] [stdout] | [INFO] [stdout] 130 | fn gyro_accel_into_u16(data: &[u8]) -> i16 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) enum ValueType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 7 | U8(u8), [INFO] [stdout] | ^^ [INFO] [stdout] 8 | U16(u16), [INFO] [stdout] | ^^^ [INFO] [stdout] 9 | I16(i16), [INFO] [stdout] | ^^^ [INFO] [stdout] 10 | Pad(DPad), [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | Symbol(Symbols), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 12 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | Combo(ComboProperty), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ValueType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `NewValueType` is never used [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) enum NewValueType { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_dpad`, `to_symbol`, `to_combo`, `to_analog`, and `to_trigger` are never used [INFO] [stdout] --> src/dualsense/properties/valuetype.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 21 | impl ValueType { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub(crate) fn to_dpad(self) -> DPad { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub(crate) fn to_symbol(self) -> Symbols { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub(crate) fn to_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub(crate) fn to_analog(self) -> AnalogPad { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | pub(crate) fn to_trigger(self) -> Trigger { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `QUADRANT_ANGLE` is never used [INFO] [stdout] --> src/dualsense/properties/analog_pad.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const QUADRANT_ANGLE: u8 = 90; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `to_left_combo` and `to_right_combo` are never used [INFO] [stdout] --> src/dualsense/properties/analog_pad.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 14 | impl AnalogPad { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 59 | pub(crate) fn to_left_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub(crate) fn to_right_combo(self) -> ComboProperty { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/stream.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 82 | let device = Arc::clone(&self.device); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let callbacks_v2 = Arc::clone(&self.callbacks_v2); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let cache_v2 = Arc::clone(&self.callback_cache_v2); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let output_cache = Arc::clone(&self.output_cache); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let output_cache_changed = Arc::clone(&self.output_cache_changed); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let combos = Arc::clone(&self.combos); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | thread::spawn(move || loop { [INFO] [stdout] | _______________________^ [INFO] [stdout] 90 | | let mut buf = [0u8; PACKET_SIZE]; [INFO] [stdout] 91 | | let bytes_read = device.lock().unwrap().read(&mut buf); [INFO] [stdout] 92 | | match bytes_read { [INFO] [stdout] ... | [INFO] [stdout] 114 | | sleep(Duration::from_millis(50)); [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 30 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Callback::FromU8(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Callback::FromU16(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 48 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Callback::FromDPad(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dualsense/callback_helpers.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 57 | fn to_callback(self) -> Callback { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Callback::FromSymbols(Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dualsense-rs` (lib test) due to 6 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a0390908d18ee26ef7c4e046c2d05ad458feb8360c75bb8b1159fa59c39f6f27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0390908d18ee26ef7c4e046c2d05ad458feb8360c75bb8b1159fa59c39f6f27", kill_on_drop: false }` [INFO] [stdout] a0390908d18ee26ef7c4e046c2d05ad458feb8360c75bb8b1159fa59c39f6f27