[INFO] fetching crate du2 0.2.1... [INFO] checking du2-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate du2 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate du2 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate du2 0.2.1 [INFO] finished tweaking crates.io crate du2 0.2.1 [INFO] tweaked toml for crates.io crate du2 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate du2 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcc818b841709142236a4f53eefaae626577b5cf27094f1139f904cf0a57d474 [INFO] running `Command { std: "docker" "start" "-a" "fcc818b841709142236a4f53eefaae626577b5cf27094f1139f904cf0a57d474", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcc818b841709142236a4f53eefaae626577b5cf27094f1139f904cf0a57d474", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcc818b841709142236a4f53eefaae626577b5cf27094f1139f904cf0a57d474", kill_on_drop: false }` [INFO] [stdout] fcc818b841709142236a4f53eefaae626577b5cf27094f1139f904cf0a57d474 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fd06e3638715b1a3e1dbc00fee9f2d97f2b98e8f6dba28b9d9ed78a26f2c4ee [INFO] running `Command { std: "docker" "start" "-a" "3fd06e3638715b1a3e1dbc00fee9f2d97f2b98e8f6dba28b9d9ed78a26f2c4ee", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.3 [INFO] [stderr] Compiling proc-macro-error v1.0.3 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking cpu-time v1.0.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking users v0.10.0 [INFO] [stderr] Checking num-format v0.4.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking du2 v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | let mut dstats: &mut DirStats = if top.dtree.contains_key(parent) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:404:25 [INFO] [stdout] | [INFO] [stdout] 404 | let mut upstats = if top.dtree.contains_key(nextpar) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:348:21 [INFO] [stdout] | [INFO] [stdout] 348 | let mut dstats: &mut DirStats = if top.dtree.contains_key(parent) { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:404:25 [INFO] [stdout] | [INFO] [stdout] 404 | let mut upstats = if top.dtree.contains_key(nextpar) { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserUsage` is never constructed [INFO] [stdout] --> src/main.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | struct UserUsage { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `long_help` is never read [INFO] [stdout] --> src/cli.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct ParLsCfg { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 123 | pub long_help: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParLsCfg` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:47:58 [INFO] [stdout] | [INFO] [stdout] 47 | #[structopt(name = "DIRECTORY", parse(try_from_str = dir_check))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:73:64 [INFO] [stdout] | [INFO] [stdout] 73 | #[structopt(long = "file-newer-than", parse(try_from_str = parse_timespec))] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:77:64 [INFO] [stdout] | [INFO] [stdout] 77 | #[structopt(long = "file-older-than", parse(try_from_str = parse_timespec))] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | #[structopt(long = "re", parse(try_from_str = parse_regex))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:89:59 [INFO] [stdout] | [INFO] [stdout] 89 | #[structopt(long = "exclude-re", parse(try_from_str = parse_regex))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UserUsage` is never constructed [INFO] [stdout] --> src/main.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | struct UserUsage { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `long_help` is never read [INFO] [stdout] --> src/cli.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct ParLsCfg { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 123 | pub long_help: bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParLsCfg` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `du2` (bin "du2") due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:47:58 [INFO] [stdout] | [INFO] [stdout] 47 | #[structopt(name = "DIRECTORY", parse(try_from_str = dir_check))] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:73:64 [INFO] [stdout] | [INFO] [stdout] 73 | #[structopt(long = "file-newer-than", parse(try_from_str = parse_timespec))] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:77:64 [INFO] [stdout] | [INFO] [stdout] 77 | #[structopt(long = "file-older-than", parse(try_from_str = parse_timespec))] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:81:51 [INFO] [stdout] | [INFO] [stdout] 81 | #[structopt(long = "re", parse(try_from_str = parse_regex))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:89:59 [INFO] [stdout] | [INFO] [stdout] 89 | #[structopt(long = "exclude-re", parse(try_from_str = parse_regex))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `du2` (bin "du2" test) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3fd06e3638715b1a3e1dbc00fee9f2d97f2b98e8f6dba28b9d9ed78a26f2c4ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fd06e3638715b1a3e1dbc00fee9f2d97f2b98e8f6dba28b9d9ed78a26f2c4ee", kill_on_drop: false }` [INFO] [stdout] 3fd06e3638715b1a3e1dbc00fee9f2d97f2b98e8f6dba28b9d9ed78a26f2c4ee