[INFO] fetching crate dt-core 0.7.9... [INFO] checking dt-core-0.7.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dt-core 0.7.9 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate dt-core 0.7.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dt-core 0.7.9 [INFO] finished tweaking crates.io crate dt-core 0.7.9 [INFO] tweaked toml for crates.io crate dt-core 0.7.9 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.21.0 (latest: v0.24.1) [INFO] [stderr] Adding backtrace v0.3.71 (latest: v0.3.73) [INFO] [stderr] Adding dirs v4.0.0 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gethostname v0.2.3 (latest: v0.5.0) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding handlebars v4.5.0 (latest: v6.0.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding object v0.32.2 (latest: v0.36.4) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding path-clean v0.1.0 (latest: v1.0.1) [INFO] [stderr] Adding shellexpand v2.1.2 (latest: v3.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8c475b28f767b8cadd2bdfe4a2e8129da994ccb8296427d763ae96568abd4dd [INFO] running `Command { std: "docker" "start" "-a" "e8c475b28f767b8cadd2bdfe4a2e8129da994ccb8296427d763ae96568abd4dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8c475b28f767b8cadd2bdfe4a2e8129da994ccb8296427d763ae96568abd4dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8c475b28f767b8cadd2bdfe4a2e8129da994ccb8296427d763ae96568abd4dd", kill_on_drop: false }` [INFO] [stdout] e8c475b28f767b8cadd2bdfe4a2e8129da994ccb8296427d763ae96568abd4dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af3fb97e0d535a78c1e90828e3c51fc338a0391630a4d42ba6736ed88cfe18e2 [INFO] running `Command { std: "docker" "start" "-a" "af3fb97e0d535a78c1e90828e3c51fc338a0391630a4d42ba6736ed88cfe18e2", kill_on_drop: false }` [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling sys-info v0.9.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking gethostname v0.2.3 [INFO] [stderr] Checking shellexpand v2.1.2 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Compiling serde_tuple_macros v0.5.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking serde_tuple v0.5.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking handlebars v4.5.0 [INFO] [stderr] Checking dt-core v0.7.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:338:20 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn filter_names(self, group_names: Vec) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | local: self [INFO] [stdout] | ____________________^ [INFO] [stdout] 339 | | .local [INFO] [stdout] 340 | | .iter() [INFO] [stdout] 341 | | .filter(|l| group_names.iter().any(|n| l.name.0.starts_with(n))) [INFO] [stdout] 342 | | .map(|l| l.to_owned()) [INFO] [stdout] 343 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn filter_names(self, group_names: Vec) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | remote: self [INFO] [stdout] | _____________________^ [INFO] [stdout] 345 | | .remote [INFO] [stdout] 346 | | .iter() [INFO] [stdout] 347 | | .filter(|l| group_names.iter().any(|n| l.name.0.starts_with(n))) [INFO] [stdout] 348 | | .map(|l| l.to_owned()) [INFO] [stdout] 349 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 69 | fn register_helpers(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut render_env = self.env; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | env: render_env, [INFO] [stdout] 84 | | ..self [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | x.unwrap_or_else(|_| panic!("Cannot read dir '{}' properly", path.display())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 193 | fn resolve(config: DTConfig) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(DTConfig { [INFO] [stdout] | ________^ [INFO] [stdout] 228 | | local: config [INFO] [stdout] 229 | | .local [INFO] [stdout] 230 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 254 | | ..config [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | ..group.to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dt-core` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:338:20 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn filter_names(self, group_names: Vec) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | local: self [INFO] [stdout] | ____________________^ [INFO] [stdout] 339 | | .local [INFO] [stdout] 340 | | .iter() [INFO] [stdout] 341 | | .filter(|l| group_names.iter().any(|n| l.name.0.starts_with(n))) [INFO] [stdout] 342 | | .map(|l| l.to_owned()) [INFO] [stdout] 343 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn filter_names(self, group_names: Vec) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | remote: self [INFO] [stdout] | _____________________^ [INFO] [stdout] 345 | | .remote [INFO] [stdout] 346 | | .iter() [INFO] [stdout] 347 | | .filter(|l| group_names.iter().any(|n| l.name.0.starts_with(n))) [INFO] [stdout] 348 | | .map(|l| l.to_owned()) [INFO] [stdout] 349 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 69 | fn register_helpers(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut render_env = self.env; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | env: render_env, [INFO] [stdout] 84 | | ..self [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 154 | .map(|x| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | x.unwrap_or_else(|_| panic!("Cannot read dir '{}' properly", path.display())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:227:8 [INFO] [stdout] | [INFO] [stdout] 193 | fn resolve(config: DTConfig) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(DTConfig { [INFO] [stdout] | ________^ [INFO] [stdout] 228 | | local: config [INFO] [stdout] 229 | | .local [INFO] [stdout] 230 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 254 | | ..config [INFO] [stdout] 255 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syncing.rs:251:19 [INFO] [stdout] | [INFO] [stdout] 251 | ..group.to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dt-core` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "af3fb97e0d535a78c1e90828e3c51fc338a0391630a4d42ba6736ed88cfe18e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af3fb97e0d535a78c1e90828e3c51fc338a0391630a4d42ba6736ed88cfe18e2", kill_on_drop: false }` [INFO] [stdout] af3fb97e0d535a78c1e90828e3c51fc338a0391630a4d42ba6736ed88cfe18e2