[INFO] fetching crate dssim 3.3.2... [INFO] checking dssim-3.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dssim 3.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dssim 3.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dssim 3.3.2 [INFO] finished tweaking crates.io crate dssim 3.3.2 [INFO] tweaked toml for crates.io crate dssim 3.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate dssim 3.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa9932f34f0f7a9bea1b5b50b1a2433e50c9634b987ba09c51cf4a81c2b53425 [INFO] running `Command { std: "docker" "start" "-a" "fa9932f34f0f7a9bea1b5b50b1a2433e50c9634b987ba09c51cf4a81c2b53425", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa9932f34f0f7a9bea1b5b50b1a2433e50c9634b987ba09c51cf4a81c2b53425", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa9932f34f0f7a9bea1b5b50b1a2433e50c9634b987ba09c51cf4a81c2b53425", kill_on_drop: false }` [INFO] [stdout] fa9932f34f0f7a9bea1b5b50b1a2433e50c9634b987ba09c51cf4a81c2b53425 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 929d7f6167c2933a309d991a512bf30e6a0872ae95b3c71d1914197edfb535b0 [INFO] running `Command { std: "docker" "start" "-a" "929d7f6167c2933a309d991a512bf30e6a0872ae95b3c71d1914197edfb535b0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking flate2 v1.0.29 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking fallible_collections v0.4.9 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking lodepng v3.10.1 [INFO] [stderr] Checking ordered-channel v1.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Compiling lcms2-sys v4.0.5 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking num v0.4.2 [INFO] [stderr] Checking rexif v0.7.3 [INFO] [stderr] Checking dssim-core v3.2.9 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking lcms2 v6.1.0 [INFO] [stderr] Checking load_image v3.1.4 [INFO] [stderr] Checking dssim v3.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 80 | let (images_send, mut images_recv) = ordered_channel::bounded(2); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (filenames_send, filenames_recv) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | std::thread::scope(|scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 88 | | let decode_thread = || { [INFO] [stdout] 89 | | let images_send = images_send; // ensure it's moved, and attr isn't [INFO] [stdout] 90 | | filenames_recv.into_iter().try_for_each(|(i, file): (usize, PathBuf)| { [INFO] [stdout] ... | [INFO] [stdout] 127 | | result [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 80 | let (images_send, mut images_recv) = ordered_channel::bounded(2); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (filenames_send, filenames_recv) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let images_send = images_send; // ensure it's moved, and attr isn't [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | filenames_recv.into_iter().try_for_each(|(i, file): (usize, PathBuf)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:46 [INFO] [stdout] | [INFO] [stdout] 126 | threads.into_iter().try_for_each(|t| t.join().map_err(|_| "thread panicked; this is a bug")?)?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dssim` (bin "dssim") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 80 | let (images_send, mut images_recv) = ordered_channel::bounded(2); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (filenames_send, filenames_recv) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | std::thread::scope(|scope| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 88 | | let decode_thread = || { [INFO] [stdout] 89 | | let images_send = images_send; // ensure it's moved, and attr isn't [INFO] [stdout] 90 | | filenames_recv.into_iter().try_for_each(|(i, file): (usize, PathBuf)| { [INFO] [stdout] ... | [INFO] [stdout] 127 | | result [INFO] [stdout] 128 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 80 | let (images_send, mut images_recv) = ordered_channel::bounded(2); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let (filenames_send, filenames_recv) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let images_send = images_send; // ensure it's moved, and attr isn't [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | filenames_recv.into_iter().try_for_each(|(i, file): (usize, PathBuf)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:46 [INFO] [stdout] | [INFO] [stdout] 126 | threads.into_iter().try_for_each(|t| t.join().map_err(|_| "thread panicked; this is a bug")?)?; [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dssim` (bin "dssim" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "929d7f6167c2933a309d991a512bf30e6a0872ae95b3c71d1914197edfb535b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "929d7f6167c2933a309d991a512bf30e6a0872ae95b3c71d1914197edfb535b0", kill_on_drop: false }` [INFO] [stdout] 929d7f6167c2933a309d991a512bf30e6a0872ae95b3c71d1914197edfb535b0