[INFO] fetching crate dsf 0.2.2... [INFO] checking dsf-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dsf 0.2.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dsf 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dsf 0.2.2 [INFO] finished tweaking crates.io crate dsf 0.2.2 [INFO] tweaked toml for crates.io crate dsf 0.2.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8364f4959b4583a4ca4faab27ccdbbc743fe6f54c171772c705fbb71eb7a47ea [INFO] running `Command { std: "docker" "start" "-a" "8364f4959b4583a4ca4faab27ccdbbc743fe6f54c171772c705fbb71eb7a47ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8364f4959b4583a4ca4faab27ccdbbc743fe6f54c171772c705fbb71eb7a47ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8364f4959b4583a4ca4faab27ccdbbc743fe6f54c171772c705fbb71eb7a47ea", kill_on_drop: false }` [INFO] [stdout] 8364f4959b4583a4ca4faab27ccdbbc743fe6f54c171772c705fbb71eb7a47ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 724d1f934079db35c1f3770c3a78b3826e7442dc27280f42fe5c3475cf4dc7a0 [INFO] running `Command { std: "docker" "start" "-a" "724d1f934079db35c1f3770c3a78b3826e7442dc27280f42fe5c3475cf4dc7a0", kill_on_drop: false }` [INFO] [stderr] Checking sampled_data_duration v0.3.1 [INFO] [stderr] Checking id3 v1.14.0 [INFO] [stderr] Checking dsf v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `id3::Tag::read_from`: use read_from2 [INFO] [stdout] --> src/lib.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | Some(Tag::read_from(&file)?) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `id3::Tag::read_from`: use read_from2 [INFO] [stdout] --> src/lib.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | Some(Tag::read_from(&file)?) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 96 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(DsfFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | file, [INFO] [stdout] 119 | | dsd_chunk, [INFO] [stdout] 120 | | fmt_chunk, [INFO] [stdout] 121 | | data_chunk, [INFO] [stdout] 122 | | id3_tag, [INFO] [stdout] 123 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsf` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 96 | let mut file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | Ok(DsfFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | file, [INFO] [stdout] 119 | | dsd_chunk, [INFO] [stdout] 120 | | fmt_chunk, [INFO] [stdout] 121 | | data_chunk, [INFO] [stdout] 122 | | id3_tag, [INFO] [stdout] 123 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsf` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "724d1f934079db35c1f3770c3a78b3826e7442dc27280f42fe5c3475cf4dc7a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "724d1f934079db35c1f3770c3a78b3826e7442dc27280f42fe5c3475cf4dc7a0", kill_on_drop: false }` [INFO] [stdout] 724d1f934079db35c1f3770c3a78b3826e7442dc27280f42fe5c3475cf4dc7a0