[INFO] fetching crate dsc 0.1.3... [INFO] checking dsc-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dsc 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate dsc 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dsc 0.1.3 [INFO] finished tweaking crates.io crate dsc 0.1.3 [INFO] tweaked toml for crates.io crate dsc 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate dsc 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 354e11a69174f3e3e18597fa8e4b094023328b01164310f56c6c77916558eba9 [INFO] running `Command { std: "docker" "start" "-a" "354e11a69174f3e3e18597fa8e4b094023328b01164310f56c6c77916558eba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "354e11a69174f3e3e18597fa8e4b094023328b01164310f56c6c77916558eba9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "354e11a69174f3e3e18597fa8e4b094023328b01164310f56c6c77916558eba9", kill_on_drop: false }` [INFO] [stdout] 354e11a69174f3e3e18597fa8e4b094023328b01164310f56c6c77916558eba9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19aa144706cd8ad3902fb174b2e986a1123f4247805bac4fb59372a2d140eca4 [INFO] running `Command { std: "docker" "start" "-a" "19aa144706cd8ad3902fb174b2e986a1123f4247805bac4fb59372a2d140eca4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.56 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling const_fn v0.4.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling anyhow v1.0.37 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking xxhash-rust v0.8.1 [INFO] [stderr] Checking throttle v0.1.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking terminal_size v0.1.15 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-queue v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking crossbeam v0.8.0 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking console v0.14.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking format_num v0.1.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking globset v0.4.6 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking ignore v0.4.17 [INFO] [stderr] Checking dsc v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `total_duplicates_found` is never read [INFO] [stdout] --> src/duplicate_detection/messages.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct AnalysisStatistics { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 41 | pub total_completed_investigations: u64, [INFO] [stdout] 42 | pub total_duplicates_found: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnalysisStatistics` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `initial_block_size` is never read [INFO] [stdout] --> src/options.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Options { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub initial_block_size: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Options` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 4 | let debug_arg = Arg::with_name("debug") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let quiet_arg = Arg::with_name("quiet") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let force_arg = Arg::with_name("force") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let dry_run_arg = Arg::with_name("dry-run") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let prefer_arg = Arg::with_name("prefer") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let estimate_arg = Arg::with_name("estimate") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let output_format_arg = Arg::with_name("output-format") [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let no_sampling_arg = Arg::with_name("no-sampling") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let fail_on_duplicate_arg = Arg::with_name("error-on-duplicate") [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let threads_arg = Arg::with_name("threads") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let read_buffer_arg = Arg::with_name("read-buffer-size") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let start_block_size_arg = Arg::with_name("start-block-size") [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let path_arg = Arg::with_name("path") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let min_size_arg = Arg::with_name("min-size") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let max_size_arg = Arg::with_name("max-size") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let shared_args = vec![ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let cmp = SubCommand::with_name("cmp") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let link = SubCommand::with_name("link") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let report = SubCommand::with_name("report") [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / App::new("dsc") [INFO] [stdout] 168 | | .subcommands(vec![cmp, report, link]) [INFO] [stdout] 169 | | .version(crate_version!()) [INFO] [stdout] 170 | | .usage("dsc [FLAGS/OPTIONS] [...]") [INFO] [stdout] 171 | | .setting(AppSettings::ColoredHelp) [INFO] [stdout] 172 | | .setting(AppSettings::DeriveDisplayOrder) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/candidate_selector.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 79 | let multi = MultiProgress::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let progress_updater = std::thread::spawn(move || { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / progress_updater [INFO] [stdout] 138 | | .join() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 40 | out: Sender, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | coordinator_files_in: Receiver, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | coordinator_work_in: Receiver, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | tracker: CollisionTracker::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn into_duplicates(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let CollisionTracker { [INFO] [stdout] 59 | mut handles, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | duplicates, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / duplicates [INFO] [stdout] 65 | | .into_iter() [INFO] [stdout] 66 | | .map(|entry| { [INFO] [stdout] 67 | | let (FullCollisionKey { file_size, .. }, descriptors) = entry; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let (FullCollisionKey { file_size, .. }, descriptors) = entry; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | locations: descriptors [INFO] [stdout] | ________________________________^ [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] 72 | | .map(|file_descriptor| { [INFO] [stdout] 73 | | handles [INFO] [stdout] ... | [INFO] [stdout] 80 | | .flat_map(|option| option.into_iter()) [INFO] [stdout] 81 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/messages.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(FileWithDescriptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | file, [INFO] [stdout] 57 | | file_descriptor, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/path_walker.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let file_event_sender = file_event_sender.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Box::new(move |entry| match entry { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | Ok(entry) => { [INFO] [stdout] 33 | | if let Some(file_type) = entry.file_type() { [INFO] [stdout] 34 | | if file_type.is_symlink() { [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/worker.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn work(mut self) -> JoinHandle<::anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 37 | | self.work_internal()?; [INFO] [stdout] 38 | | Ok(self) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrency/select.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | let operation = self.select.select(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | / self.tag_by_index [INFO] [stdout] 49 | | .get(&operation.index()) [INFO] [stdout] 50 | | .map(|&t| (t, operation)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/duplicate_checker.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 104 | let multi = MultiProgress::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let progress_updater = std::thread::spawn(move || { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | / progress_updater [INFO] [stdout] 154 | | .join() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/open_file_guard.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 19 | sem: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (request_out, request_in) = channel::unbounded(); [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (response_out, response_in) = channel::unbounded(); [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / OpenFileGuard { [INFO] [stdout] 30 | | request_in, [INFO] [stdout] 31 | | response_out, [INFO] [stdout] 32 | | sem, [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/open_file_guard.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn work(self) -> JoinHandle<::anyhow::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 41 | | info!("Mutex guard started"); [INFO] [stdout] 42 | | self.work_internal()?; [INFO] [stdout] 43 | | info!("Mutex guard ended"); [INFO] [stdout] 44 | | Ok(self) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn work(mut self) -> JoinHandle> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | let res = self.work_internal(); [INFO] [stdout] 41 | | info!("Worker has finished {:?}", res); [INFO] [stdout] 42 | | res?; [INFO] [stdout] 43 | | Ok(self) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 117 | grouping_round: FxHashMap, Vec>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / grouping_round [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] 122 | | .map(|v| v.1) [INFO] [stdout] 123 | | .map(|v| Duplicate { [INFO] [stdout] 124 | | file_size, [INFO] [stdout] 125 | | locations: v.into_iter().map(|v| v.descriptor).collect(), [INFO] [stdout] 126 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|v| Duplicate { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | file_size, [INFO] [stdout] 125 | locations: v.into_iter().map(|v| v.descriptor).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 169 | grouping_round: FxHashMap, Vec>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let mut partitions: Vec<_> = grouping_round.into_iter().map(|v| v.1).collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let work = partitions.pop(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let future_work: Vec = partitions [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok((work, lease_count)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:195:32 [INFO] [stdout] | [INFO] [stdout] 187 | .map(|partition| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let locations = partition [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | duplicate: Duplicate { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 196 | | file_size, [INFO] [stdout] 197 | | locations, [INFO] [stdout] 198 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsc` (bin "dsc") due to 18 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `total_duplicates_found` is never read [INFO] [stdout] --> src/duplicate_detection/messages.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct AnalysisStatistics { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 41 | pub total_completed_investigations: u64, [INFO] [stdout] 42 | pub total_duplicates_found: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnalysisStatistics` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `initial_block_size` is never read [INFO] [stdout] --> src/options.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Options { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub initial_block_size: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Options` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 4 | let debug_arg = Arg::with_name("debug") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let quiet_arg = Arg::with_name("quiet") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | let force_arg = Arg::with_name("force") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let dry_run_arg = Arg::with_name("dry-run") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let prefer_arg = Arg::with_name("prefer") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let estimate_arg = Arg::with_name("estimate") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let output_format_arg = Arg::with_name("output-format") [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let no_sampling_arg = Arg::with_name("no-sampling") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let fail_on_duplicate_arg = Arg::with_name("error-on-duplicate") [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let threads_arg = Arg::with_name("threads") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let read_buffer_arg = Arg::with_name("read-buffer-size") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let start_block_size_arg = Arg::with_name("start-block-size") [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let path_arg = Arg::with_name("path") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let min_size_arg = Arg::with_name("min-size") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let max_size_arg = Arg::with_name("max-size") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let shared_args = vec![ [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let cmp = SubCommand::with_name("cmp") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let link = SubCommand::with_name("link") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let report = SubCommand::with_name("report") [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / App::new("dsc") [INFO] [stdout] 168 | | .subcommands(vec![cmp, report, link]) [INFO] [stdout] 169 | | .version(crate_version!()) [INFO] [stdout] 170 | | .usage("dsc [FLAGS/OPTIONS] [...]") [INFO] [stdout] 171 | | .setting(AppSettings::ColoredHelp) [INFO] [stdout] 172 | | .setting(AppSettings::DeriveDisplayOrder) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/candidate_selector.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 79 | let multi = MultiProgress::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let progress_updater = std::thread::spawn(move || { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / progress_updater [INFO] [stdout] 138 | | .join() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:50:22 [INFO] [stdout] | [INFO] [stdout] 40 | out: Sender, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | coordinator_files_in: Receiver, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | coordinator_work_in: Receiver, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | tracker: CollisionTracker::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn into_duplicates(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let CollisionTracker { [INFO] [stdout] 59 | mut handles, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | duplicates, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / duplicates [INFO] [stdout] 65 | | .into_iter() [INFO] [stdout] 66 | | .map(|entry| { [INFO] [stdout] 67 | | let (FullCollisionKey { file_size, .. }, descriptors) = entry; [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/message_handler.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 66 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let (FullCollisionKey { file_size, .. }, descriptors) = entry; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | locations: descriptors [INFO] [stdout] | ________________________________^ [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] 72 | | .map(|file_descriptor| { [INFO] [stdout] 73 | | handles [INFO] [stdout] ... | [INFO] [stdout] 80 | | .flat_map(|option| option.into_iter()) [INFO] [stdout] 81 | | .collect(), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/messages.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(FileWithDescriptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | file, [INFO] [stdout] 57 | | file_descriptor, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/path_walker.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let file_event_sender = file_event_sender.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Box::new(move |entry| match entry { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | Ok(entry) => { [INFO] [stdout] 33 | | if let Some(file_type) = entry.file_type() { [INFO] [stdout] 34 | | if file_type.is_symlink() { [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/candidate_selection/worker.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn work(mut self) -> JoinHandle<::anyhow::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 37 | | self.work_internal()?; [INFO] [stdout] 38 | | Ok(self) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/concurrency/select.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | let operation = self.select.select(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | / self.tag_by_index [INFO] [stdout] 49 | | .get(&operation.index()) [INFO] [stdout] 50 | | .map(|&t| (t, operation)) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/duplicate_checker.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 104 | let multi = MultiProgress::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let progress_updater = std::thread::spawn(move || { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | / progress_updater [INFO] [stdout] 154 | | .join() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/open_file_guard.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 19 | sem: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (request_out, request_in) = channel::unbounded(); [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (response_out, response_in) = channel::unbounded(); [INFO] [stdout] | ------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / OpenFileGuard { [INFO] [stdout] 30 | | request_in, [INFO] [stdout] 31 | | response_out, [INFO] [stdout] 32 | | sem, [INFO] [stdout] 33 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/open_file_guard.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn work(self) -> JoinHandle<::anyhow::Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 41 | | info!("Mutex guard started"); [INFO] [stdout] 42 | | self.work_internal()?; [INFO] [stdout] 43 | | info!("Mutex guard ended"); [INFO] [stdout] 44 | | Ok(self) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn work(mut self) -> JoinHandle> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | let res = self.work_internal(); [INFO] [stdout] 41 | | info!("Worker has finished {:?}", res); [INFO] [stdout] 42 | | res?; [INFO] [stdout] 43 | | Ok(self) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 117 | grouping_round: FxHashMap, Vec>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / grouping_round [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] 122 | | .map(|v| v.1) [INFO] [stdout] 123 | | .map(|v| Duplicate { [INFO] [stdout] 124 | | file_size, [INFO] [stdout] 125 | | locations: v.into_iter().map(|v| v.descriptor).collect(), [INFO] [stdout] 126 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:125:28 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|v| Duplicate { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | file_size, [INFO] [stdout] 125 | locations: v.into_iter().map(|v| v.descriptor).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 169 | grouping_round: FxHashMap, Vec>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let mut partitions: Vec<_> = grouping_round.into_iter().map(|v| v.1).collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let work = partitions.pop(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let future_work: Vec = partitions [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok((work, lease_count)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/duplicate_detection/worker.rs:195:32 [INFO] [stdout] | [INFO] [stdout] 187 | .map(|partition| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let locations = partition [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | duplicate: Duplicate { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 196 | | file_size, [INFO] [stdout] 197 | | locations, [INFO] [stdout] 198 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsc` (bin "dsc" test) due to 18 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "19aa144706cd8ad3902fb174b2e986a1123f4247805bac4fb59372a2d140eca4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19aa144706cd8ad3902fb174b2e986a1123f4247805bac4fb59372a2d140eca4", kill_on_drop: false }` [INFO] [stdout] 19aa144706cd8ad3902fb174b2e986a1123f4247805bac4fb59372a2d140eca4