[INFO] fetching crate ds 1.2.4... [INFO] checking ds-1.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ds 1.2.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ds 1.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ds 1.2.4 [INFO] finished tweaking crates.io crate ds 1.2.4 [INFO] tweaked toml for crates.io crate ds 1.2.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ds 1.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c17d0d647370386bb70e381eab5e87aa236d12b65305ca35cb4d0c019669fff1 [INFO] running `Command { std: "docker" "start" "-a" "c17d0d647370386bb70e381eab5e87aa236d12b65305ca35cb4d0c019669fff1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c17d0d647370386bb70e381eab5e87aa236d12b65305ca35cb4d0c019669fff1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c17d0d647370386bb70e381eab5e87aa236d12b65305ca35cb4d0c019669fff1", kill_on_drop: false }` [INFO] [stdout] c17d0d647370386bb70e381eab5e87aa236d12b65305ca35cb4d0c019669fff1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac2761dc120c797a74d014b99921d97c1b828324904277acd3ada25d2a98f074 [INFO] running `Command { std: "docker" "start" "-a" "ac2761dc120c797a74d014b99921d97c1b828324904277acd3ada25d2a98f074", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Compiling pin-project-internal v0.4.23 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking once_cell v1.4.1 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Checking miniz_oxide v0.4.1 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.2.1 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking chrono v0.4.15 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking pin-project v0.4.23 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking ds v1.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/ext.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait BufExt: Buf { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] ... [INFO] [stdout] 26 | fn read_u32_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | fn read_u64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | fn read_i8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | fn read_i16_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn read_i32_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | fn read_i64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | fn read_f64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IncomingTcpPacket` is never used [INFO] [stdout] --> src/proto/tcp/inbound.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait IncomingTcpPacket: Sized { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `seqnum` is never read [INFO] [stdout] --> src/proto/udp/inbound.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct UdpResponsePacket { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 13 | pub seqnum: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpResponsePacket` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/tcp.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 34 | let mut buf = src.clone().freeze(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | match inner(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/udp.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 17 | let mut buf = src.clone().freeze(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | match UdpResponsePacket::decode(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/ext.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait BufExt: Buf { [INFO] [stdout] | ------ methods in this trait [INFO] [stdout] ... [INFO] [stdout] 26 | fn read_u32_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | fn read_u64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | fn read_i8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | fn read_i16_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn read_i32_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | fn read_i64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | fn read_f64_be(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `IncomingTcpPacket` is never used [INFO] [stdout] --> src/proto/tcp/inbound.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) trait IncomingTcpPacket: Sized { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `seqnum` is never read [INFO] [stdout] --> src/proto/udp/inbound.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct UdpResponsePacket { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 13 | pub seqnum: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UdpResponsePacket` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/tcp.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 34 | let mut buf = src.clone().freeze(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | match inner(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/udp.rs:19:15 [INFO] [stdout] | [INFO] [stdout] 17 | let mut buf = src.clone().freeze(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | match UdpResponsePacket::decode(&mut buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ac2761dc120c797a74d014b99921d97c1b828324904277acd3ada25d2a98f074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac2761dc120c797a74d014b99921d97c1b828324904277acd3ada25d2a98f074", kill_on_drop: false }` [INFO] [stdout] ac2761dc120c797a74d014b99921d97c1b828324904277acd3ada25d2a98f074