[INFO] fetching crate drop-move 0.1.0... [INFO] checking drop-move-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate drop-move 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate drop-move 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate drop-move 0.1.0 [INFO] finished tweaking crates.io crate drop-move 0.1.0 [INFO] tweaked toml for crates.io crate drop-move 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe96027a61800ca3f8343d6cb491891f16cd14ac7e8972e736026456e5c98f63 [INFO] running `Command { std: "docker" "start" "-a" "fe96027a61800ca3f8343d6cb491891f16cd14ac7e8972e736026456e5c98f63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe96027a61800ca3f8343d6cb491891f16cd14ac7e8972e736026456e5c98f63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe96027a61800ca3f8343d6cb491891f16cd14ac7e8972e736026456e5c98f63", kill_on_drop: false }` [INFO] [stdout] fe96027a61800ca3f8343d6cb491891f16cd14ac7e8972e736026456e5c98f63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06a556699d92f760a98328eb161e7f1b3149d01de2e008e40b500336193f5f7c [INFO] running `Command { std: "docker" "start" "-a" "06a556699d92f760a98328eb161e7f1b3149d01de2e008e40b500336193f5f7c", kill_on_drop: false }` [INFO] [stderr] Checking drop-move v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_handle.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn into_inner(self_: Self) -> T { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self::into_outer(self_).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_handle.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self(ManuallyDrop::new(t.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_move_wrap.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 295 | fn from(x: $inner_name$($generic_params)*) -> Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | Self($crate::DropMoveWrapper::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/drop_guard.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / drop_move_wrap! { [INFO] [stdout] 4 | | /// Run a [`FnOnce`] function on drop. [INFO] [stdout] 5 | | #[derive(Clone)] [INFO] [stdout] 6 | | pub struct DropGuard(DropGuardInner { [INFO] [stdout] 7 | | func: F, [INFO] [stdout] 8 | | }); [INFO] [stdout] 9 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::drop_move_wrap_transcribe` which comes from the expansion of the macro `drop_move_wrap` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_guard.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | fn drop_move(self_: DropHandle) { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | (DropHandle::into_inner(self_).func)() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_guard.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | DropGuardInner { func: f }.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_handle.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn into_inner(self_: Self) -> T { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self::into_outer(self_).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_handle.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 41 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self(ManuallyDrop::new(t.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_move_wrap.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 295 | fn from(x: $inner_name$($generic_params)*) -> Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | Self($crate::DropMoveWrapper::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/drop_guard.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / drop_move_wrap! { [INFO] [stdout] 4 | | /// Run a [`FnOnce`] function on drop. [INFO] [stdout] 5 | | #[derive(Clone)] [INFO] [stdout] 6 | | pub struct DropGuard(DropGuardInner { [INFO] [stdout] 7 | | func: F, [INFO] [stdout] 8 | | }); [INFO] [stdout] 9 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::drop_move_wrap_transcribe` which comes from the expansion of the macro `drop_move_wrap` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_guard.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | fn drop_move(self_: DropHandle) { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | (DropHandle::into_inner(self_).func)() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_guard.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | DropGuardInner { func: f }.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_move_wrap.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 295 | fn from(x: $inner_name$($generic_params)*) -> Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | Self($crate::DropMoveWrapper::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | / drop_move_wrap! { [INFO] [stdout] 230 | | pub struct ReturnToSender(pub ReturnToSenderInner(T, Rc>>)) [INFO] [stdout] 231 | | where [INFO] [stdout] 232 | | T: Clone; [INFO] [stdout] 233 | | } [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::drop_move_wrap_transcribe` which comes from the expansion of the macro `drop_move_wrap` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_move_wrap.rs:296:22 [INFO] [stdout] | [INFO] [stdout] 295 | fn from(x: $inner_name$($generic_params)*) -> Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | Self($crate::DropMoveWrapper::new(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | / drop_move_wrap! { [INFO] [stdout] 256 | | #[derive(Clone)] [INFO] [stdout] 257 | | { [INFO] [stdout] 258 | | #[derive(PartialEq)] [INFO] [stdout] ... | [INFO] [stdout] 269 | | T::Target: 'a; [INFO] [stdout] 270 | | } [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `$crate::drop_move_wrap_transcribe` which comes from the expansion of the macro `drop_move_wrap` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drop-move` (lib) due to 6 previous errors [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `drop-move` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "06a556699d92f760a98328eb161e7f1b3149d01de2e008e40b500336193f5f7c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06a556699d92f760a98328eb161e7f1b3149d01de2e008e40b500336193f5f7c", kill_on_drop: false }` [INFO] [stdout] 06a556699d92f760a98328eb161e7f1b3149d01de2e008e40b500336193f5f7c