[INFO] fetching crate drake 0.2.0... [INFO] checking drake-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate drake 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate drake 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate drake 0.2.0 [INFO] finished tweaking crates.io crate drake 0.2.0 [INFO] tweaked toml for crates.io crate drake 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate drake 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33e648231979fb0e518c4a470d552bc1ea675ef0cb972b870cb0f576c24ce28f [INFO] running `Command { std: "docker" "start" "-a" "33e648231979fb0e518c4a470d552bc1ea675ef0cb972b870cb0f576c24ce28f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33e648231979fb0e518c4a470d552bc1ea675ef0cb972b870cb0f576c24ce28f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33e648231979fb0e518c4a470d552bc1ea675ef0cb972b870cb0f576c24ce28f", kill_on_drop: false }` [INFO] [stdout] 33e648231979fb0e518c4a470d552bc1ea675ef0cb972b870cb0f576c24ce28f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1a030102d125373091de8f55a75713fac3c0d0346b199954f056b9c8bcf66d6 [INFO] running `Command { std: "docker" "start" "-a" "e1a030102d125373091de8f55a75713fac3c0d0346b199954f056b9c8bcf66d6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.7.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking patricia_tree v0.6.3 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling tree-sitter v0.20.10 [INFO] [stderr] Compiling tree-sitter-swift v0.3.6 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking globset v0.4.13 [INFO] [stderr] Checking ignore v0.4.20 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Checking drake v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Declaration` and `Reference` [INFO] [stdout] --> src/parser/mod.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | pub use tree::{Declaration, Definition, Reference, Tree}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Declaration` and `Reference` [INFO] [stdout] --> src/parser/mod.rs:6:16 [INFO] [stdout] | [INFO] [stdout] 6 | pub use tree::{Declaration, Definition, Reference, Tree}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `path_prefix` are never read [INFO] [stdout] --> src/index.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Package { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 21 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 22 | path_prefix: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Package` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `references` is never used [INFO] [stdout] --> src/parser/tree.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Tree<'_> { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn references(&self, source: &str) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut parser = tree_sitter::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let tree = parser [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Tree { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | source, [INFO] [stdout] 50 | | tree, [INFO] [stdout] 51 | | parser: self, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker_pool.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let task_tx = task_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | if let Ok(dent) = result { [INFO] [stdout] 33 | | if let Some(ftype) = dent.file_type() { [INFO] [stdout] 34 | | if !ftype.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 42 | | WalkState::Continue [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drake` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name` and `path_prefix` are never read [INFO] [stdout] --> src/index.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct Package { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 21 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 22 | path_prefix: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Package` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `references` is never used [INFO] [stdout] --> src/parser/tree.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Tree<'_> { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn references(&self, source: &str) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut parser = tree_sitter::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let tree = parser [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Tree { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | source, [INFO] [stdout] 50 | | tree, [INFO] [stdout] 51 | | parser: self, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker_pool.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let task_tx = task_tx.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Box::new(move |result| { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | if let Ok(dent) = result { [INFO] [stdout] 33 | | if let Some(ftype) = dent.file_type() { [INFO] [stdout] 34 | | if !ftype.is_dir() { [INFO] [stdout] ... | [INFO] [stdout] 42 | | WalkState::Continue [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drake` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e1a030102d125373091de8f55a75713fac3c0d0346b199954f056b9c8bcf66d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1a030102d125373091de8f55a75713fac3c0d0346b199954f056b9c8bcf66d6", kill_on_drop: false }` [INFO] [stdout] e1a030102d125373091de8f55a75713fac3c0d0346b199954f056b9c8bcf66d6