[INFO] fetching crate drain-rs 0.3.0... [INFO] checking drain-rs-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate drain-rs 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate drain-rs 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate drain-rs 0.3.0 [INFO] finished tweaking crates.io crate drain-rs 0.3.0 [INFO] tweaked toml for crates.io crate drain-rs 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate drain-rs 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 500e565e26075bd386c1d4bee05343eba4664a0c19bce9b7d37eb0ca3e45abf7 [INFO] running `Command { std: "docker" "start" "-a" "500e565e26075bd386c1d4bee05343eba4664a0c19bce9b7d37eb0ca3e45abf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "500e565e26075bd386c1d4bee05343eba4664a0c19bce9b7d37eb0ca3e45abf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "500e565e26075bd386c1d4bee05343eba4664a0c19bce9b7d37eb0ca3e45abf7", kill_on_drop: false }` [INFO] [stdout] 500e565e26075bd386c1d4bee05343eba4664a0c19bce9b7d37eb0ca3e45abf7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c04d8ca350b289e0da38681c76725d31f566d74eb2f82f04a2e0d7a2abd649ea [INFO] running `Command { std: "docker" "start" "-a" "c04d8ca350b289e0da38681c76725d31f566d74eb2f82f04a2e0d7a2abd649ea", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling libloading v0.6.3 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling regex-syntax v0.6.18 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling termcolor v1.1.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling bindgen v0.55.1 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling aho-corasick v0.7.13 [INFO] [stderr] Compiling clang-sys v1.0.0 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling grok v1.2.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Compiling regex v1.3.9 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling onig_sys v69.6.0 [INFO] [stderr] Checking onig v6.1.1 [INFO] [stderr] Checking drain-rs v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `is_compiled` is never used [INFO] [stdout] --> src/lib.rs:559:8 [INFO] [stdout] | [INFO] [stdout] 413 | impl DrainTree { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 559 | fn is_compiled(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:28 [INFO] [stdout] | [INFO] [stdout] 256 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:256:28 [INFO] [stdout] | [INFO] [stdout] 256 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:293:27 [INFO] [stdout] | [INFO] [stdout] 293 | .map(|n| n.borrow()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `LogCluster` does not implement `Borrow`, so calling `borrow` on `&LogCluster` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 293 - .map(|n| n.borrow()) [INFO] [stdout] 293 + .map(|n| n) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `LogCluster`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 118 + #[derive(Clone)] [INFO] [stdout] 119 | pub struct LogCluster { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:293:27 [INFO] [stdout] | [INFO] [stdout] 293 | .map(|n| n.borrow()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `LogCluster` does not implement `Borrow`, so calling `borrow` on `&LogCluster` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 293 - .map(|n| n.borrow()) [INFO] [stdout] 293 + .map(|n| n) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `LogCluster`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 118 + #[derive(Clone)] [INFO] [stdout] 119 | pub struct LogCluster { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `drain-rs` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `drain-rs` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c04d8ca350b289e0da38681c76725d31f566d74eb2f82f04a2e0d7a2abd649ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c04d8ca350b289e0da38681c76725d31f566d74eb2f82f04a2e0d7a2abd649ea", kill_on_drop: false }` [INFO] [stdout] c04d8ca350b289e0da38681c76725d31f566d74eb2f82f04a2e0d7a2abd649ea