[INFO] fetching crate dprint-plugin-toml 0.6.2... [INFO] checking dprint-plugin-toml-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dprint-plugin-toml 0.6.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dprint-plugin-toml 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate dprint-plugin-toml 0.6.2 [INFO] finished tweaking crates.io crate dprint-plugin-toml 0.6.2 [INFO] tweaked toml for crates.io crate dprint-plugin-toml 0.6.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 108 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding deno_terminal v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding dprint-core v0.66.2 (latest: v0.67.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding file_test_runner v0.5.1 (latest: v0.7.2) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding logos v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding taplo v0.12.1 (latest: v0.13.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v2.0.1 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `taplo` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2f3b2efd4c5cc0a8c5476b71579e0a98324ec6272e36c2a744d06cf429168fe [INFO] running `Command { std: "docker" "start" "-a" "d2f3b2efd4c5cc0a8c5476b71579e0a98324ec6272e36c2a744d06cf429168fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2f3b2efd4c5cc0a8c5476b71579e0a98324ec6272e36c2a744d06cf429168fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2f3b2efd4c5cc0a8c5476b71579e0a98324ec6272e36c2a744d06cf429168fe", kill_on_drop: false }` [INFO] [stdout] d2f3b2efd4c5cc0a8c5476b71579e0a98324ec6272e36c2a744d06cf429168fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11c34dc08a6f8ddc50188ff02d95875ce19a048198cb050da02dfabe441ac47a [INFO] running `Command { std: "docker" "start" "-a" "11c34dc08a6f8ddc50188ff02d95875ce19a048198cb050da02dfabe441ac47a", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `taplo` dependency) [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking deno_terminal v0.1.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking rowan v0.15.16 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling dprint-core-macros v0.1.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking which v2.0.1 [INFO] [stderr] Checking debug-here v0.2.2 [INFO] [stderr] Checking file_test_runner v0.5.1 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking dprint-core v0.66.2 [INFO] [stderr] Checking taplo v0.12.1 [INFO] [stderr] Checking dprint-development v0.10.1 [INFO] [stderr] Checking dprint-plugin-toml v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | .and_then(|value| value.children().find(|child| child.kind() == SyntaxKind::ARRAY)); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | .all(|c| c.kind() == SyntaxKind::VALUE && c.children().all(|c| c.kind() == SyntaxKind::STRING)) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:47:67 [INFO] [stdout] | [INFO] [stdout] 47 | sort_nodes(&value, section_children, &|left, right| left.text().to_string().cmp(&right.text().to_string())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:47:96 [INFO] [stdout] | [INFO] [stdout] 47 | sort_nodes(&value, section_children, &|left, right| left.text().to_string().cmp(&right.text().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:140:3 [INFO] [stdout] | [INFO] [stdout] 123 | fn sort_children(children: Vec, cmp: &impl Fn(&SyntaxNode, &SyntaxNode) -> Ordering) -> Vec { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut child_groups: Vec> = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | child_groups.into_iter().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format_text.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 23 | let node = parse_and_process_node(file_path, text, config)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | || generate(node, text, config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format_text.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 43 | let node = parse_taplo(text)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(if config.cargo_apply_conventions && cargo::is_cargo_toml_file(file_path) { [INFO] [stdout] | ______^ [INFO] [stdout] 46 | | cargo::apply_cargo_toml_conventions(node) [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | node [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn gen_array<'a>(node: SyntaxNode, context: &mut Context<'a>) -> PrintItemsResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let open_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_START)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let close_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_END)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / |context| { [INFO] [stdout] 157 | | gen_comma_separated_values( [INFO] [stdout] 158 | | ParseCommaSeparatedValuesOptions { [INFO] [stdout] 159 | | nodes: values.into_iter().map(|v| v.into()).collect::>(), [INFO] [stdout] ... | [INFO] [stdout] 170 | | ) [INFO] [stdout] 171 | | }, [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn gen_array<'a>(node: SyntaxNode, context: &mut Context<'a>) -> PrintItemsResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let open_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_START)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let close_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_END)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | ParseSurroundedByTokensParams { open_token, close_token }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | / ParseCommaSeparatedValuesOptions { [INFO] [stdout] 159 | | nodes: values.into_iter().map(|v| v.into()).collect::>(), [INFO] [stdout] 160 | | prefer_hanging: false, [INFO] [stdout] 161 | | force_use_new_lines, [INFO] [stdout] ... | [INFO] [stdout] 167 | | force_possible_newline_at_start: false, [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 298 | fn gen_comma_separated_values<'a>(opts: ParseCommaSeparatedValuesOptions, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let nodes = opts.nodes; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | / |is_multi_line_ref| { [INFO] [stdout] 304 | | let mut generated_nodes = Vec::new(); [INFO] [stdout] 305 | | let nodes_count = nodes.len(); [INFO] [stdout] 306 | | for (i, value) in nodes.into_iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 334 | | generated_nodes [INFO] [stdout] 335 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 298 | fn gen_comma_separated_values<'a>(opts: ParseCommaSeparatedValuesOptions, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let nodes = opts.nodes; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | / ir_helpers::GenSeparatedValuesOptions { [INFO] [stdout] 337 | | prefer_hanging: opts.prefer_hanging, [INFO] [stdout] 338 | | force_use_new_lines: opts.force_use_new_lines, [INFO] [stdout] 339 | | allow_blank_lines: opts.allow_blank_lines, [INFO] [stdout] ... | [INFO] [stdout] 347 | | force_possible_newline_at_start: opts.force_possible_newline_at_start, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 372 | fn gen_trailing_comment<'a>(element: SyntaxElement, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | match get_trailing_comment(element) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:524:3 [INFO] [stdout] | [INFO] [stdout] 523 | fn get_children_with_non_trivia_tokens(node: SyntaxNode) -> impl Iterator { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 524 | node.children_with_tokens().filter_map(|c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 536 | fn get_child_with_kind(node: SyntaxNode, kind: SyntaxKind) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | match node.children().find(|c| c.kind() == kind) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 543 | fn get_token_with_kind(node: SyntaxNode, kind: SyntaxKind) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | match node.children_with_tokens().find(|c| c.kind() == kind) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | .and_then(|value| value.children().find(|child| child.kind() == SyntaxKind::ARRAY)); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | .all(|c| c.kind() == SyntaxKind::VALUE && c.children().all(|c| c.kind() == SyntaxKind::STRING)) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:47:67 [INFO] [stdout] | [INFO] [stdout] 47 | sort_nodes(&value, section_children, &|left, right| left.text().to_string().cmp(&right.text().to_string())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:47:96 [INFO] [stdout] | [INFO] [stdout] 47 | sort_nodes(&value, section_children, &|left, right| left.text().to_string().cmp(&right.text().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo.rs:140:3 [INFO] [stdout] | [INFO] [stdout] 123 | fn sort_children(children: Vec, cmp: &impl Fn(&SyntaxNode, &SyntaxNode) -> Ordering) -> Vec { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut child_groups: Vec> = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | child_groups.into_iter().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format_text.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 23 | let node = parse_and_process_node(file_path, text, config)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | || generate(node, text, config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format_text.rs:45:6 [INFO] [stdout] | [INFO] [stdout] 43 | let node = parse_taplo(text)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(if config.cargo_apply_conventions && cargo::is_cargo_toml_file(file_path) { [INFO] [stdout] | ______^ [INFO] [stdout] 46 | | cargo::apply_cargo_toml_conventions(node) [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | node [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn gen_array<'a>(node: SyntaxNode, context: &mut Context<'a>) -> PrintItemsResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let open_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_START)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let close_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_END)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / |context| { [INFO] [stdout] 157 | | gen_comma_separated_values( [INFO] [stdout] 158 | | ParseCommaSeparatedValuesOptions { [INFO] [stdout] 159 | | nodes: values.into_iter().map(|v| v.into()).collect::>(), [INFO] [stdout] ... | [INFO] [stdout] 170 | | ) [INFO] [stdout] 171 | | }, [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 147 | fn gen_array<'a>(node: SyntaxNode, context: &mut Context<'a>) -> PrintItemsResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | let open_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_START)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let close_token = get_token_with_kind(node.clone(), SyntaxKind::BRACKET_END)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | ParseSurroundedByTokensParams { open_token, close_token }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 148 | let values = node.children(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | / ParseCommaSeparatedValuesOptions { [INFO] [stdout] 159 | | nodes: values.into_iter().map(|v| v.into()).collect::>(), [INFO] [stdout] 160 | | prefer_hanging: false, [INFO] [stdout] 161 | | force_use_new_lines, [INFO] [stdout] ... | [INFO] [stdout] 167 | | force_possible_newline_at_start: false, [INFO] [stdout] 168 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 298 | fn gen_comma_separated_values<'a>(opts: ParseCommaSeparatedValuesOptions, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let nodes = opts.nodes; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | / |is_multi_line_ref| { [INFO] [stdout] 304 | | let mut generated_nodes = Vec::new(); [INFO] [stdout] 305 | | let nodes_count = nodes.len(); [INFO] [stdout] 306 | | for (i, value) in nodes.into_iter().enumerate() { [INFO] [stdout] ... | [INFO] [stdout] 334 | | generated_nodes [INFO] [stdout] 335 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dprint-plugin-toml` (lib test) due to 17 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 298 | fn gen_comma_separated_values<'a>(opts: ParseCommaSeparatedValuesOptions, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let nodes = opts.nodes; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | / ir_helpers::GenSeparatedValuesOptions { [INFO] [stdout] 337 | | prefer_hanging: opts.prefer_hanging, [INFO] [stdout] 338 | | force_use_new_lines: opts.force_use_new_lines, [INFO] [stdout] 339 | | allow_blank_lines: opts.allow_blank_lines, [INFO] [stdout] ... | [INFO] [stdout] 347 | | force_possible_newline_at_start: opts.force_possible_newline_at_start, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 372 | fn gen_trailing_comment<'a>(element: SyntaxElement, context: &mut Context<'a>) -> PrintItems { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | match get_trailing_comment(element) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:524:3 [INFO] [stdout] | [INFO] [stdout] 523 | fn get_children_with_non_trivia_tokens(node: SyntaxNode) -> impl Iterator { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 524 | node.children_with_tokens().filter_map(|c| match c { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 536 | fn get_child_with_kind(node: SyntaxNode, kind: SyntaxKind) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 537 | match node.children().find(|c| c.kind() == kind) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generation/generate.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 543 | fn get_token_with_kind(node: SyntaxNode, kind: SyntaxKind) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | match node.children_with_tokens().find(|c| c.kind() == kind) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dprint-plugin-toml` (lib) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "11c34dc08a6f8ddc50188ff02d95875ce19a048198cb050da02dfabe441ac47a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11c34dc08a6f8ddc50188ff02d95875ce19a048198cb050da02dfabe441ac47a", kill_on_drop: false }` [INFO] [stdout] 11c34dc08a6f8ddc50188ff02d95875ce19a048198cb050da02dfabe441ac47a