[INFO] fetching crate dprint-core 0.67.1... [INFO] checking dprint-core-0.67.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dprint-core 0.67.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate dprint-core 0.67.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dprint-core 0.67.1 [INFO] finished tweaking crates.io crate dprint-core 0.67.1 [INFO] tweaked toml for crates.io crate dprint-core 0.67.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45399179c612a5cbffc27207da611d810fa41208cbb92a0ed8d2c7e2e3da8049 [INFO] running `Command { std: "docker" "start" "-a" "45399179c612a5cbffc27207da611d810fa41208cbb92a0ed8d2c7e2e3da8049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45399179c612a5cbffc27207da611d810fa41208cbb92a0ed8d2c7e2e3da8049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45399179c612a5cbffc27207da611d810fa41208cbb92a0ed8d2c7e2e3da8049", kill_on_drop: false }` [INFO] [stdout] 45399179c612a5cbffc27207da611d810fa41208cbb92a0ed8d2c7e2e3da8049 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90b7dd0c1951725fd3fdf22d43d1aa01ddad7c3299b5b6724fb4f081406dd7f6 [INFO] running `Command { std: "docker" "start" "-a" "90b7dd0c1951725fd3fdf22d43d1aa01ddad7c3299b5b6724fb4f081406dd7f6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking dprint-core v0.67.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/actions.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn action(name: &'static str, action: impl Fn(&mut ConditionResolverContext) + 'static) -> PrintItems { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / Condition::new( [INFO] [stdout] 21 | | name, [INFO] [stdout] 22 | | ConditionProperties { [INFO] [stdout] 23 | | condition: Rc::new(move |context| { [INFO] [stdout] ... | [INFO] [stdout] 29 | | }, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn if_true(name: &'static str, resolver: ConditionResolver, true_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / ConditionProperties { [INFO] [stdout] 118 | | true_path: Some(true_path), [INFO] [stdout] 119 | | false_path: None, [INFO] [stdout] 120 | | condition: resolver, [INFO] [stdout] 121 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn if_true_or(name: &'static str, resolver: ConditionResolver, true_path: PrintItems, false_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / ConditionProperties { [INFO] [stdout] 129 | | true_path: Some(true_path), [INFO] [stdout] 130 | | false_path: Some(false_path), [INFO] [stdout] 131 | | condition: resolver, [INFO] [stdout] 132 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn if_false(name: &'static str, resolver: ConditionResolver, false_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | / ConditionProperties { [INFO] [stdout] 140 | | true_path: None, [INFO] [stdout] 141 | | false_path: Some(false_path), [INFO] [stdout] 142 | | condition: resolver, [INFO] [stdout] 143 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/thread_state.rs:111:23 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn with_bump_allocator(action: impl FnOnce(&mut BumpAllocator) -> TReturn) -> TReturn { [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | BUMP_ALLOCATOR.with(|bump_cell| unsafe { [INFO] [stdout] | _______________________^ [INFO] [stdout] 112 | | let bump = bump_cell.get(); [INFO] [stdout] 113 | | action(&mut *bump) [INFO] [stdout] 114 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/writer.rs:268:34 [INFO] [stdout] | [INFO] [stdout] 268 | self.state.items.map(|items| items.iter().rev()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:343:3 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn get_value(config: &mut ConfigKeyMap, key: &str, default_value: T, diagnostics: &mut Vec) -> T [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | get_nullable_value(config, key, diagnostics).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 381 | get_nullable_value: impl Fn(ConfigKeyValue, usize, &mut Vec) -> Option, [INFO] [stdout] | -------------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | match config.shift_remove(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dprint-core` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/actions.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn action(name: &'static str, action: impl Fn(&mut ConditionResolverContext) + 'static) -> PrintItems { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / Condition::new( [INFO] [stdout] 21 | | name, [INFO] [stdout] 22 | | ConditionProperties { [INFO] [stdout] 23 | | condition: Rc::new(move |context| { [INFO] [stdout] ... | [INFO] [stdout] 29 | | }, [INFO] [stdout] 30 | | ) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn if_true(name: &'static str, resolver: ConditionResolver, true_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | / ConditionProperties { [INFO] [stdout] 118 | | true_path: Some(true_path), [INFO] [stdout] 119 | | false_path: None, [INFO] [stdout] 120 | | condition: resolver, [INFO] [stdout] 121 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn if_true_or(name: &'static str, resolver: ConditionResolver, true_path: PrintItems, false_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / ConditionProperties { [INFO] [stdout] 129 | | true_path: Some(true_path), [INFO] [stdout] 130 | | false_path: Some(false_path), [INFO] [stdout] 131 | | condition: resolver, [INFO] [stdout] 132 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/conditions.rs:139:5 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn if_false(name: &'static str, resolver: ConditionResolver, false_path: PrintItems) -> Condition { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | / ConditionProperties { [INFO] [stdout] 140 | | true_path: None, [INFO] [stdout] 141 | | false_path: Some(false_path), [INFO] [stdout] 142 | | condition: resolver, [INFO] [stdout] 143 | | }, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/thread_state.rs:111:23 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn with_bump_allocator(action: impl FnOnce(&mut BumpAllocator) -> TReturn) -> TReturn { [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | BUMP_ALLOCATOR.with(|bump_cell| unsafe { [INFO] [stdout] | _______________________^ [INFO] [stdout] 112 | | let bump = bump_cell.get(); [INFO] [stdout] 113 | | action(&mut *bump) [INFO] [stdout] 114 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formatting/writer.rs:268:34 [INFO] [stdout] | [INFO] [stdout] 268 | self.state.items.map(|items| items.iter().rev()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:343:3 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn get_value(config: &mut ConfigKeyMap, key: &str, default_value: T, diagnostics: &mut Vec) -> T [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | get_nullable_value(config, key, diagnostics).unwrap_or(default_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 381 | get_nullable_value: impl Fn(ConfigKeyValue, usize, &mut Vec) -> Option, [INFO] [stdout] | -------------------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | match config.shift_remove(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dprint-core` (lib test) due to 9 previous errors [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "90b7dd0c1951725fd3fdf22d43d1aa01ddad7c3299b5b6724fb4f081406dd7f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90b7dd0c1951725fd3fdf22d43d1aa01ddad7c3299b5b6724fb4f081406dd7f6", kill_on_drop: false }` [INFO] [stdout] 90b7dd0c1951725fd3fdf22d43d1aa01ddad7c3299b5b6724fb4f081406dd7f6