[INFO] fetching crate dpop 0.1.1... [INFO] checking dpop-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dpop 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dpop 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dpop 0.1.1 [INFO] finished tweaking crates.io crate dpop 0.1.1 [INFO] tweaked toml for crates.io crate dpop 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 141 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding headers v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding headers-core v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-serde v1.1.3 (latest: v2.1.1) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding rstest v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] da8aceb33433d43149aafaa920af4e20ddd141a6ea94e190d38aa3ff2c143c39 [INFO] running `Command { std: "docker" "start" "-a" "da8aceb33433d43149aafaa920af4e20ddd141a6ea94e190d38aa3ff2c143c39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da8aceb33433d43149aafaa920af4e20ddd141a6ea94e190d38aa3ff2c143c39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da8aceb33433d43149aafaa920af4e20ddd141a6ea94e190d38aa3ff2c143c39", kill_on_drop: false }` [INFO] [stdout] da8aceb33433d43149aafaa920af4e20ddd141a6ea94e190d38aa3ff2c143c39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a569380af2376f61f7bd9653627c265071d07f8c01223d1c8275461d2887ac34 [INFO] running `Command { std: "docker" "start" "-a" "a569380af2376f61f7bd9653627c265071d07f8c01223d1c8275461d2887ac34", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking frunk_core v0.4.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling claims v0.7.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking aes-kw v0.2.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking oid v0.2.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking gdp_rs v0.1.1 [INFO] [stderr] Checking iri-string v0.7.2 [INFO] [stderr] Checking http-serde v1.1.3 [INFO] [stderr] Checking picky-asn1 v0.9.0 [INFO] [stderr] Checking canonical_json v0.5.0 [INFO] [stderr] Checking picky-asn1-der v0.5.0 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking picky-asn1-x509 v0.13.0 [INFO] [stderr] Checking http_uri v1.0.1 [INFO] [stderr] Checking picky v7.0.0-rc.9 [INFO] [stderr] Checking dpop v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/essence.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 22 | fn from(essence: DPoPProofEssence) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | payload: serde_json::to_vec(&essence.claims).expect("Must be json serializable."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/essence.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | let claims = serde_json::from_slice::(&jws.payload)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | Ok(DPoPProofEssence { header, claims }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/payload/nonce.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | Lazy::new(|| Regex::new(r#"^[\x21\x23-\x5b\x5d-\x7e]+$"#).expect("Must be valid regex.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/payload/common/base64url_encoded.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | Lazy::new(|| Regex::new(r#"^[A-Za-z0-9_-]+$"#).expect("Must be valid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/raw.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | Ok(RawDPoPProof { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | compact_repr, [INFO] [stdout] 68 | | decoded_essence: jws.try_into()?, [INFO] [stdout] 69 | | decoded_signature, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/validated.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | raw_proof: RawDPoPProof<'static>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | context: DPoPProofContext, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> Result> { [INFO] [stdout] 35 | Ok(Self(Proven::try_new((raw_proof, context))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/essence.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 22 | fn from(essence: DPoPProofEssence) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | payload: serde_json::to_vec(&essence.claims).expect("Must be json serializable."), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/essence.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | let claims = serde_json::from_slice::(&jws.payload)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | Ok(DPoPProofEssence { header, claims }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/payload/nonce.rs:72:22 [INFO] [stdout] | [INFO] [stdout] 72 | Lazy::new(|| Regex::new(r#"^[\x21\x23-\x5b\x5d-\x7e]+$"#).expect("Must be valid regex.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/payload/common/base64url_encoded.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | Lazy::new(|| Regex::new(r#"^[A-Za-z0-9_-]+$"#).expect("Must be valid regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/raw.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | Ok(RawDPoPProof { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | compact_repr, [INFO] [stdout] 68 | | decoded_essence: jws.try_into()?, [INFO] [stdout] 69 | | decoded_signature, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof/validated.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 32 | raw_proof: RawDPoPProof<'static>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | context: DPoPProofContext, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> Result> { [INFO] [stdout] 35 | Ok(Self(Proven::try_new((raw_proof, context))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dpop` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dpop` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a569380af2376f61f7bd9653627c265071d07f8c01223d1c8275461d2887ac34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a569380af2376f61f7bd9653627c265071d07f8c01223d1c8275461d2887ac34", kill_on_drop: false }` [INFO] [stdout] a569380af2376f61f7bd9653627c265071d07f8c01223d1c8275461d2887ac34