[INFO] fetching crate dotbak 0.4.0-alpha.0... [INFO] checking dotbak-0.4.0-alpha.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dotbak 0.4.0-alpha.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dotbak 0.4.0-alpha.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dotbak 0.4.0-alpha.0 [INFO] finished tweaking crates.io crate dotbak 0.4.0-alpha.0 [INFO] tweaked toml for crates.io crate dotbak 0.4.0-alpha.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate dotbak 0.4.0-alpha.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4711d84e7af6a751c3efdf3eae829961238b60c51179b2a4b58261ae27d82b7 [INFO] running `Command { std: "docker" "start" "-a" "e4711d84e7af6a751c3efdf3eae829961238b60c51179b2a4b58261ae27d82b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4711d84e7af6a751c3efdf3eae829961238b60c51179b2a4b58261ae27d82b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4711d84e7af6a751c3efdf3eae829961238b60c51179b2a4b58261ae27d82b7", kill_on_drop: false }` [INFO] [stdout] e4711d84e7af6a751c3efdf3eae829961238b60c51179b2a4b58261ae27d82b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f2267796c3dc27a31fb7a8018f1e98e525a21996c1f74a0bf5e4f29a2801b85 [INFO] running `Command { std: "docker" "start" "-a" "1f2267796c3dc27a31fb7a8018f1e98e525a21996c1f74a0bf5e4f29a2801b85", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling syn v2.0.69 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking assert_fs v1.1.1 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking dotbak v0.4.0-alpha.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ExitStatus` [INFO] [stdout] --> src/dotbak/daemon.rs:7:29 [INFO] [stdout] | [INFO] [stdout] 7 | use std::process::{Command, ExitStatus}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ExitStatus` [INFO] [stdout] --> src/dotbak/daemon.rs:7:29 [INFO] [stdout] | [INFO] [stdout] 7 | use std::process::{Command, ExitStatus}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `undo` is never used [INFO] [stdout] --> src/dotbak/mod.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl Dotbak { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 240 | pub fn undo(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `term` is never read [INFO] [stdout] --> src/ui/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Interface { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 18 | /// The terminal to draw to. [INFO] [stdout] 19 | term: Term, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interface` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `println` and `warn` are never used [INFO] [stdout] --> src/ui/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Interface { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn println(&self, message: S) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn warn(&self, message: S) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UNDO_MSG` is never used [INFO] [stdout] --> src/ui/messages.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub const UNDO_MSG: &str = "⏪ Undoing last commit"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:424:12 [INFO] [stdout] | [INFO] [stdout] 395 | fn init_into_dirs(home: P1, config: P2, repo: P3, verbose: bool) -> Result [INFO] [stdout] | -------- ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 425 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 426 | | config, [INFO] [stdout] 427 | | repo, [INFO] [stdout] 428 | | logger: Logger::new(verbose), [INFO] [stdout] 429 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 430 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 436 | home: P1, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | config: P2, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | repo: P3, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 472 | | config, [INFO] [stdout] 473 | | repo, [INFO] [stdout] 474 | | logger: Logger::new(verbose), [INFO] [stdout] 475 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 476 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:495:12 [INFO] [stdout] | [INFO] [stdout] 481 | fn load_into_dirs(home: P1, config: P2, repo: P3, verbose: bool) -> Result [INFO] [stdout] | -------- ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 495 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 496 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 497 | | config, [INFO] [stdout] 498 | | repo, [INFO] [stdout] ... | [INFO] [stdout] 507 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 508 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/daemon.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | let stdout = File::create("/tmp/dotbak-daemon.out").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let stderr = File::create("/tmp/dotbak-daemon.err").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let dotbak = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let daemonize = Daemonize::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Daemon { dotbak, daemonize }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/logger.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new_with_streams(verbose: bool, stdout: Box, stderr: Box) -> Self { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | stdout: RefCell::new(stdout), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/logger.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new_with_streams(verbose: bool, stdout: Box, stderr: Box) -> Self { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | stderr: RefCell::new(stderr), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn is_managed_in_home

(&self, file: P) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | / fs::symlink_metadata(&home_path) [INFO] [stdout] 45 | | .and_then(|meta| match meta.file_type().is_symlink() { [INFO] [stdout] 46 | | // If it's a symlink, then check if it's symlinked to `file_dir`. [INFO] [stdout] 47 | | true => { [INFO] [stdout] ... | [INFO] [stdout] 56 | | false => Ok(false), [INFO] [stdout] 57 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 34 | let term = Term::stdout(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let draw_target = ProgressDrawTarget::term(term.clone(), 30); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | mp: MultiProgress::with_draw_target(draw_target), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotbak` (bin "dotbak") due to 9 previous errors; 5 warnings emitted [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `undo` is never used [INFO] [stdout] --> src/dotbak/mod.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl Dotbak { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 240 | pub fn undo(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `term` is never read [INFO] [stdout] --> src/ui/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Interface { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 18 | /// The terminal to draw to. [INFO] [stdout] 19 | term: Term, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interface` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `println` and `warn` are never used [INFO] [stdout] --> src/ui/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 31 | impl Interface { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn println(&self, message: S) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn warn(&self, message: S) [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `UNDO_MSG` is never used [INFO] [stdout] --> src/ui/messages.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub const UNDO_MSG: &str = "⏪ Undoing last commit"; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:424:12 [INFO] [stdout] | [INFO] [stdout] 395 | fn init_into_dirs(home: P1, config: P2, repo: P3, verbose: bool) -> Result [INFO] [stdout] | -------- ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 425 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 426 | | config, [INFO] [stdout] 427 | | repo, [INFO] [stdout] 428 | | logger: Logger::new(verbose), [INFO] [stdout] 429 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 430 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 436 | home: P1, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | config: P2, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | repo: P3, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | Err(err) => return Err(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 472 | | config, [INFO] [stdout] 473 | | repo, [INFO] [stdout] 474 | | logger: Logger::new(verbose), [INFO] [stdout] 475 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 476 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/mod.rs:495:12 [INFO] [stdout] | [INFO] [stdout] 481 | fn load_into_dirs(home: P1, config: P2, repo: P3, verbose: bool) -> Result [INFO] [stdout] | -------- ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 495 | Ok(Dotbak { [INFO] [stdout] | ____________^ [INFO] [stdout] 496 | | dotfiles: Files::init(home_path, repo_path), [INFO] [stdout] 497 | | config, [INFO] [stdout] 498 | | repo, [INFO] [stdout] ... | [INFO] [stdout] 507 | | interface: Interface::new(MAX_MSG_LEN), [INFO] [stdout] 508 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/daemon.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | let stdout = File::create("/tmp/dotbak-daemon.out").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let stderr = File::create("/tmp/dotbak-daemon.err").unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let dotbak = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let daemonize = Daemonize::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Daemon { dotbak, daemonize }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/logger.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new_with_streams(verbose: bool, stdout: Box, stderr: Box) -> Self { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | stdout: RefCell::new(stdout), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dotbak/logger.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new_with_streams(verbose: bool, stdout: Box, stderr: Box) -> Self { [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | stderr: RefCell::new(stderr), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn is_managed_in_home

(&self, file: P) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | / fs::symlink_metadata(&home_path) [INFO] [stdout] 45 | | .and_then(|meta| match meta.file_type().is_symlink() { [INFO] [stdout] 46 | | // If it's a symlink, then check if it's symlinked to `file_dir`. [INFO] [stdout] 47 | | true => { [INFO] [stdout] ... | [INFO] [stdout] 56 | | false => Ok(false), [INFO] [stdout] 57 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 34 | let term = Term::stdout(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let draw_target = ProgressDrawTarget::term(term.clone(), 30); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | mp: MultiProgress::with_draw_target(draw_target), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dotbak` (bin "dotbak" test) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f2267796c3dc27a31fb7a8018f1e98e525a21996c1f74a0bf5e4f29a2801b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f2267796c3dc27a31fb7a8018f1e98e525a21996c1f74a0bf5e4f29a2801b85", kill_on_drop: false }` [INFO] [stdout] 1f2267796c3dc27a31fb7a8018f1e98e525a21996c1f74a0bf5e4f29a2801b85