[INFO] fetching crate dota-gsi 0.1.4... [INFO] checking dota-gsi-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dota-gsi 0.1.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dota-gsi 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dota-gsi 0.1.4 [INFO] finished tweaking crates.io crate dota-gsi 0.1.4 [INFO] tweaked toml for crates.io crate dota-gsi 0.1.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate dota-gsi 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c191d7b8430f53de4d9292185eee1a9767eda02e872019b227d2c5e05fa64217 [INFO] running `Command { std: "docker" "start" "-a" "c191d7b8430f53de4d9292185eee1a9767eda02e872019b227d2c5e05fa64217", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c191d7b8430f53de4d9292185eee1a9767eda02e872019b227d2c5e05fa64217", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c191d7b8430f53de4d9292185eee1a9767eda02e872019b227d2c5e05fa64217", kill_on_drop: false }` [INFO] [stdout] c191d7b8430f53de4d9292185eee1a9767eda02e872019b227d2c5e05fa64217 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bef2ec654de2e1427e654389bb68eacaffc90a87b9d276a9338350fa1e6f36f7 [INFO] running `Command { std: "docker" "start" "-a" "bef2ec654de2e1427e654389bb68eacaffc90a87b9d276a9338350fa1e6f36f7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling rustix v0.38.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.147 [INFO] [stderr] Compiling serde v1.0.147 [INFO] [stderr] Compiling tokio v1.21.2 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Compiling serde_json v1.0.87 [INFO] [stderr] Compiling async-trait v0.1.70 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.14.0 [INFO] [stderr] Checking once_cell v1.16.0 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking itoa v1.0.4 [INFO] [stderr] Checking chrono v0.4.23 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Checking is-terminal v0.4.8 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking dota-gsi v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/abilities.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 47 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Err(D::Error::custom(AbilitiesError::ParseIDError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/items.rs:146:10 [INFO] [stdout] | [INFO] [stdout] 146 | #[derive(Deserialize, Serialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/players.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 55 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Err(D::Error::custom(PlayersError::ParseIDError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/wearables.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 135 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Err(D::Error::custom(WearablesError::ParseSlotError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dota-gsi` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/abilities.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 47 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Err(D::Error::custom(AbilitiesError::ParseIDError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/items.rs:146:10 [INFO] [stdout] | [INFO] [stdout] 146 | #[derive(Deserialize, Serialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/players.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 55 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Err(D::Error::custom(PlayersError::ParseIDError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/wearables.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 135 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Err(D::Error::custom(WearablesError::ParseSlotError(s))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dota-gsi` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bef2ec654de2e1427e654389bb68eacaffc90a87b9d276a9338350fa1e6f36f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bef2ec654de2e1427e654389bb68eacaffc90a87b9d276a9338350fa1e6f36f7", kill_on_drop: false }` [INFO] [stdout] bef2ec654de2e1427e654389bb68eacaffc90a87b9d276a9338350fa1e6f36f7