[INFO] fetching crate dora-ssr 0.4.3... [INFO] checking dora-ssr-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dora-ssr 0.4.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dora-ssr 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dora-ssr 0.4.3 [INFO] finished tweaking crates.io crate dora-ssr 0.4.3 [INFO] tweaked toml for crates.io crate dora-ssr 0.4.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d268e6ca3035e7c3bf16b0e52d9145947b469dcd5c6585cd47e9cb4cbc92ac5 [INFO] running `Command { std: "docker" "start" "-a" "3d268e6ca3035e7c3bf16b0e52d9145947b469dcd5c6585cd47e9cb4cbc92ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d268e6ca3035e7c3bf16b0e52d9145947b469dcd5c6585cd47e9cb4cbc92ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d268e6ca3035e7c3bf16b0e52d9145947b469dcd5c6585cd47e9cb4cbc92ac5", kill_on_drop: false }` [INFO] [stdout] 3d268e6ca3035e7c3bf16b0e52d9145947b469dcd5c6585cd47e9cb4cbc92ac5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 61c24b5517604a8249f888254495fb90d58c89d4b18c8b0c4264ea997d3c08eb [INFO] running `Command { std: "docker" "start" "-a" "61c24b5517604a8249f888254495fb90d58c89d4b18c8b0c4264ea997d3c08eb", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking dora-ssr v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:2126:9 [INFO] [stdout] | [INFO] [stdout] 2125 | pub fn each(&self, func: Box bool>) -> bool { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2126 | match self.find(func) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:2824:33 [INFO] [stdout] | [INFO] [stdout] 2823 | pub fn from_update(mut update: Box bool>) -> platformer::ActionUpdate { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2824 | platformer::ActionUpdate::new(Box::new(move |_, _, dt| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2825 | | update(dt as f64) [INFO] [stdout] 2826 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:3944:8 [INFO] [stdout] | [INFO] [stdout] 3939 | fn new(closure: C) -> Self where [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3944 | co: Box::pin(closure(co)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:3966:11 [INFO] [stdout] | [INFO] [stdout] 3962 | pub fn once(closure: C) -> Box bool> where [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3965 | let mut executor = Executor::new(closure); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3966 | Box::new(move |_| { [INFO] [stdout] | ______________^ [INFO] [stdout] 3967 | | executor.update() [INFO] [stdout] 3968 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora/db.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn query_with_params_async(sql: &str, params: &crate::dora::Array, with_columns: bool, mut callback: Box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora/platformer/unit_action.rs:99:10 [INFO] [stdout] | [INFO] [stdout] 83 | ...d(name: &str, priority: i32, reaction: f32, recovery: f32, queued: bool, mut available: Box bool>, mut create: Box crate::dora::platformer::ActionUpdate>, mut stop: B... [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | ...ut stack2 = crate::dora::CallStack::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | ...top(&stack2.pop_cast::().unwrap(), &crate::dora::platformer::UnitAction::from(stack2.pop_i64().unwrap()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dora-ssr` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:2126:9 [INFO] [stdout] | [INFO] [stdout] 2125 | pub fn each(&self, func: Box bool>) -> bool { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2126 | match self.find(func) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:2824:33 [INFO] [stdout] | [INFO] [stdout] 2823 | pub fn from_update(mut update: Box bool>) -> platformer::ActionUpdate { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2824 | platformer::ActionUpdate::new(Box::new(move |_, _, dt| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2825 | | update(dt as f64) [INFO] [stdout] 2826 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:3944:8 [INFO] [stdout] | [INFO] [stdout] 3939 | fn new(closure: C) -> Self where [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3944 | co: Box::pin(closure(co)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora.rs:3966:11 [INFO] [stdout] | [INFO] [stdout] 3962 | pub fn once(closure: C) -> Box bool> where [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3965 | let mut executor = Executor::new(closure); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3966 | Box::new(move |_| { [INFO] [stdout] | ______________^ [INFO] [stdout] 3967 | | executor.update() [INFO] [stdout] 3968 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora/db.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn query_with_params_async(sql: &str, params: &crate::dora::Array, with_columns: bool, mut callback: Box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dora/platformer/unit_action.rs:99:10 [INFO] [stdout] | [INFO] [stdout] 83 | ...d(name: &str, priority: i32, reaction: f32, recovery: f32, queued: bool, mut available: Box bool>, mut create: Box crate::dora::platformer::ActionUpdate>, mut stop: B... [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | ...ut stack2 = crate::dora::CallStack::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | ...top(&stack2.pop_cast::().unwrap(), &crate::dora::platformer::UnitAction::from(stack2.pop_i64().unwrap()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dora-ssr` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "61c24b5517604a8249f888254495fb90d58c89d4b18c8b0c4264ea997d3c08eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61c24b5517604a8249f888254495fb90d58c89d4b18c8b0c4264ea997d3c08eb", kill_on_drop: false }` [INFO] [stdout] 61c24b5517604a8249f888254495fb90d58c89d4b18c8b0c4264ea997d3c08eb