[INFO] fetching crate dom_query 0.3.6... [INFO] checking dom_query-0.3.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dom_query 0.3.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate dom_query 0.3.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dom_query 0.3.6 [INFO] finished tweaking crates.io crate dom_query 0.3.6 [INFO] tweaked toml for crates.io crate dom_query 0.3.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate dom_query 0.3.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fab2a0b74e5861cde95f8338bdca6688657262391ac5115c86cbdb6d11c9905 [INFO] running `Command { std: "docker" "start" "-a" "7fab2a0b74e5861cde95f8338bdca6688657262391ac5115c86cbdb6d11c9905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fab2a0b74e5861cde95f8338bdca6688657262391ac5115c86cbdb6d11c9905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fab2a0b74e5861cde95f8338bdca6688657262391ac5115c86cbdb6d11c9905", kill_on_drop: false }` [INFO] [stdout] 7fab2a0b74e5861cde95f8338bdca6688657262391ac5115c86cbdb6d11c9905 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fd8a75607edc182a1f321e4979524bab71ff970e3657f6fec8f7999b4fb8e73 [INFO] running `Command { std: "docker" "start" "-a" "3fd8a75607edc182a1f321e4979524bab71ff970e3657f6fec8f7999b4fb8e73", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rustls v0.23.11 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking dtoa-short v0.3.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling syn v2.0.42 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking string_cache v0.8.4 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking xml5ever v0.17.0 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking rustls-webpki v0.102.5 [INFO] [stderr] Checking markup5ever_rcdom v0.2.0 [INFO] [stderr] Checking readability v0.3.0 [INFO] [stderr] Checking dom_query v0.3.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/document.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 43 | fn from(html: StrTendril) -> Document { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | parse_document(Document::default(), Default::default()).one(html) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/document.rs:160:31 [INFO] [stdout] | [INFO] [stdout] 159 | fn create_comment(&mut self, text: StrTendril) -> NodeId { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | self.tree.create_node(NodeData::Comment { contents: text }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/document.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 165 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> NodeId { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | self.tree.create_node(NodeData::ProcessingInstruction { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 167 | | target, [INFO] [stdout] 168 | | contents: data, [INFO] [stdout] 169 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom_tree.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 57 | let nodes = self.nodes.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self { [INFO] [stdout] 59 | nodes: RefCell::new(nodes.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom_tree.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 57 | let nodes = self.nodes.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | names: self.names.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom_tree.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(root: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | nodes: RefCell::new(vec![InnerNode::new(root_id, root)]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom_tree.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(root: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | names: NodeIdMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dom_tree.rs:511:14 [INFO] [stdout] | [INFO] [stdout] 503 | pub fn compare_node(&self, a: &NodeId, b: &NodeId, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | let nodes = self.nodes.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | Some(f(node_a, node_b)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | let mut input = cssparser::ParserInput::new(sel); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let mut parser = cssparser::Parser::new(&mut input); [INFO] [stdout] 23 | / selectors::parser::SelectorList::parse( [INFO] [stdout] 24 | | &InnerSelectorParser, [INFO] [stdout] 25 | | &mut parser, [INFO] [stdout] 26 | | parser::ParseRelative::ForNesting, [INFO] [stdout] 27 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn from_one(node: T, matcher: &'a Matcher, match_scope: MatchScope) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | set: NodeIdSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 78 | nodes: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | roots: nodes.collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 78 | nodes: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | set: NodeIdSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dom_query` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3fd8a75607edc182a1f321e4979524bab71ff970e3657f6fec8f7999b4fb8e73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fd8a75607edc182a1f321e4979524bab71ff970e3657f6fec8f7999b4fb8e73", kill_on_drop: false }` [INFO] [stdout] 3fd8a75607edc182a1f321e4979524bab71ff970e3657f6fec8f7999b4fb8e73