[INFO] fetching crate dom-manipulator 0.1.0... [INFO] checking dom-manipulator-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dom-manipulator 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dom-manipulator 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dom-manipulator 0.1.0 [INFO] finished tweaking crates.io crate dom-manipulator 0.1.0 [INFO] tweaked toml for crates.io crate dom-manipulator 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate dom-manipulator 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac3233853901fa927aee6cde189282a595508ffc2de2530ebf8daf2a735e1787 [INFO] running `Command { std: "docker" "start" "-a" "ac3233853901fa927aee6cde189282a595508ffc2de2530ebf8daf2a735e1787", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac3233853901fa927aee6cde189282a595508ffc2de2530ebf8daf2a735e1787", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac3233853901fa927aee6cde189282a595508ffc2de2530ebf8daf2a735e1787", kill_on_drop: false }` [INFO] [stdout] ac3233853901fa927aee6cde189282a595508ffc2de2530ebf8daf2a735e1787 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3eebe93703f935b7bc56f3a4c3bae58d4793dc52adbdb7a3ae1be09f2496b661 [INFO] running `Command { std: "docker" "start" "-a" "3eebe93703f935b7bc56f3a4c3bae58d4793dc52adbdb7a3ae1be09f2496b661", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking dtoa-short v0.3.3 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Compiling getrandom v0.2.7 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking string_cache v0.8.4 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling cssparser-macros v0.6.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking dom-manipulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/html/mod.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | traversal_scope: html5ever::serialize::TraversalScope::IncludeNode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 110 - traversal_scope: html5ever::serialize::TraversalScope::IncludeNode, [INFO] [stdout] 110 + traversal_scope: serialize::TraversalScope::IncludeNode, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 75 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.tree [INFO] [stdout] 77 | .orphan(Node::Comment(Comment { comment: text })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:210:21 [INFO] [stdout] | [INFO] [stdout] 208 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | self.tree [INFO] [stdout] 210 | .orphan(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | _____________________^ [INFO] [stdout] 211 | | target, [INFO] [stdout] 212 | | data, [INFO] [stdout] 213 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(name: QualName, attrs: Vec) -> Self { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let id = attrs [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let classes: HashSet = attrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | attrs: attrs.into_iter().map(|a| (a.name, a.value)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selector.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | let mut parser_input = cssparser::ParserInput::new(selectors); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut parser = cssparser::Parser::new(&mut parser_input); [INFO] [stdout] 31 | parser::SelectorList::parse(&Parser, &mut parser).map(|list| Selector { selectors: list.0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dom-manipulator` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/html/mod.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | traversal_scope: html5ever::serialize::TraversalScope::IncludeNode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 110 - traversal_scope: html5ever::serialize::TraversalScope::IncludeNode, [INFO] [stdout] 110 + traversal_scope: serialize::TraversalScope::IncludeNode, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 75 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.tree [INFO] [stdout] 77 | .orphan(Node::Comment(Comment { comment: text })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:210:21 [INFO] [stdout] | [INFO] [stdout] 208 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | self.tree [INFO] [stdout] 210 | .orphan(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | _____________________^ [INFO] [stdout] 211 | | target, [INFO] [stdout] 212 | | data, [INFO] [stdout] 213 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(name: QualName, attrs: Vec) -> Self { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | let id = attrs [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let classes: HashSet = attrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | attrs: attrs.into_iter().map(|a| (a.name, a.value)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selector.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | let mut parser_input = cssparser::ParserInput::new(selectors); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut parser = cssparser::Parser::new(&mut parser_input); [INFO] [stdout] 31 | parser::SelectorList::parse(&Parser, &mut parser).map(|list| Selector { selectors: list.0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dom-manipulator` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3eebe93703f935b7bc56f3a4c3bae58d4793dc52adbdb7a3ae1be09f2496b661", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eebe93703f935b7bc56f3a4c3bae58d4793dc52adbdb7a3ae1be09f2496b661", kill_on_drop: false }` [INFO] [stdout] 3eebe93703f935b7bc56f3a4c3bae58d4793dc52adbdb7a3ae1be09f2496b661