[INFO] fetching crate doitlater 0.3.0... [INFO] checking doitlater-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate doitlater 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate doitlater 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate doitlater 0.3.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate doitlater 0.3.0 [INFO] tweaked toml for crates.io crate doitlater 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate doitlater 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45aa4e1e0f399bce34b694e5b3bc5896e1b7001ab5a8152431f11295a9072ef0 [INFO] running `Command { std: "docker" "start" "-a" "45aa4e1e0f399bce34b694e5b3bc5896e1b7001ab5a8152431f11295a9072ef0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45aa4e1e0f399bce34b694e5b3bc5896e1b7001ab5a8152431f11295a9072ef0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45aa4e1e0f399bce34b694e5b3bc5896e1b7001ab5a8152431f11295a9072ef0", kill_on_drop: false }` [INFO] [stdout] 45aa4e1e0f399bce34b694e5b3bc5896e1b7001ab5a8152431f11295a9072ef0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c0918572b6363ab8d2b189d330667cbbf0073d64fe69cc9b970255af29a9c4c [INFO] running `Command { std: "docker" "start" "-a" "7c0918572b6363ab8d2b189d330667cbbf0073d64fe69cc9b970255af29a9c4c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking inventory v0.3.13 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking combine v4.6.6 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking cron-parser v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling typetag-impl v0.2.14 [INFO] [stderr] Checking redis v0.24.0 [INFO] [stderr] Checking erased-serde v0.4.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking typetag v0.2.14 [INFO] [stderr] Checking doitlater v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/queue.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn enqueue(&mut self, name: &str, executable: Box) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/queue.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | .query(&mut self.redis_conn)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/queue.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn delete_job_data(&mut self, name: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/queue.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | self.redis_conn.hdel(self.jobs_storage_key(), name)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/scheduler.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn tick(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/scheduler.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | .zrembyscore(self.scheduled_jobs_key(), 0, current_timestamp)?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/scheduler.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn job_succeeded(&mut self, name: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/scheduler.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | self.redis_connection.zadd( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/queue.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn enqueue(&mut self, name: &str, executable: Box) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/queue.rs:61:18 [INFO] [stdout] | [INFO] [stdout] 61 | .query(&mut self.redis_conn)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/queue.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn delete_job_data(&mut self, name: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/queue.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | self.redis_conn.hdel(self.jobs_storage_key(), name)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/scheduler.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn tick(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/scheduler.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | .zrembyscore(self.scheduled_jobs_key(), 0, current_timestamp)?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/scheduler.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn job_succeeded(&mut self, name: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/scheduler.rs:75:35 [INFO] [stdout] | [INFO] [stdout] 75 | self.redis_connection.zadd( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executable.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 15 | fn enqueue_into(self, queue: &mut Queue, name: &str) -> crate::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | queue.enqueue(name, Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | let conn = client.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Queue { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | qname: name.to_string(), [INFO] [stdout] 18 | | redis_conn: conn, [INFO] [stdout] 19 | | client, [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | let conn = client.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Queue { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | qname: name.to_string(), [INFO] [stdout] 27 | | redis_conn: conn, [INFO] [stdout] 28 | | client, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doitlater` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executable.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 15 | fn enqueue_into(self, queue: &mut Queue, name: &str) -> crate::Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | queue.enqueue(name, Box::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | let conn = client.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Queue { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | qname: name.to_string(), [INFO] [stdout] 18 | | redis_conn: conn, [INFO] [stdout] 19 | | client, [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queue.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | let conn = client.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(Queue { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | qname: name.to_string(), [INFO] [stdout] 27 | | redis_conn: conn, [INFO] [stdout] 28 | | client, [INFO] [stdout] 29 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doitlater` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7c0918572b6363ab8d2b189d330667cbbf0073d64fe69cc9b970255af29a9c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c0918572b6363ab8d2b189d330667cbbf0073d64fe69cc9b970255af29a9c4c", kill_on_drop: false }` [INFO] [stdout] 7c0918572b6363ab8d2b189d330667cbbf0073d64fe69cc9b970255af29a9c4c