[INFO] fetching crate dogear 0.5.0... [INFO] checking dogear-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dogear 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate dogear 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dogear 0.5.0 [INFO] finished tweaking crates.io crate dogear 0.5.0 [INFO] tweaked toml for crates.io crate dogear 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.5.13 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb08630a2de46db7bb1b3a1dfd791d16185ba0fc7e532a5a274b22fca08d137c [INFO] running `Command { std: "docker" "start" "-a" "fb08630a2de46db7bb1b3a1dfd791d16185ba0fc7e532a5a274b22fca08d137c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb08630a2de46db7bb1b3a1dfd791d16185ba0fc7e532a5a274b22fca08d137c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb08630a2de46db7bb1b3a1dfd791d16185ba0fc7e532a5a274b22fca08d137c", kill_on_drop: false }` [INFO] [stdout] fb08630a2de46db7bb1b3a1dfd791d16185ba0fc7e532a5a274b22fca08d137c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87ef8ba04f1de6620ff1a3acd723fd9753fed2a4ae943bb431083e4cb77948bf [INFO] running `Command { std: "docker" "start" "-a" "87ef8ba04f1de6620ff1a3acd723fd9753fed2a4ae943bb431083e4cb77948bf", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking smallbitvec v2.5.3 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking dogear v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `merged_guids` is never read [INFO] [stdout] --> src/merge.rs:1763:5 [INFO] [stdout] | [INFO] [stdout] 1759 | pub struct MergedRoot<'t> { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 1763 | merged_guids: HashSet, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MergedRoot` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guid.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 75 | let repr = if b.is_valid_guid() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Guid(repr)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guid.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 90 | let repr = if b.is_valid_guid() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Guid(repr)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn merge(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let merged_root_node = { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(MergedRoot { [INFO] [stdout] | ____________^ [INFO] [stdout] 191 | | local_tree: self.local_tree, [INFO] [stdout] 192 | | remote_tree: self.remote_tree, [INFO] [stdout] 193 | | node: merged_root_node, [INFO] [stdout] ... | [INFO] [stdout] 197 | | structure_counts: self.structure_counts, [INFO] [stdout] 198 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:1641:12 [INFO] [stdout] | [INFO] [stdout] 1560 | let mut local_to_remote = HashMap::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1561 | let mut remote_to_local = HashMap::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1641 | Ok((local_to_remote, remote_to_local)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 114 | fn with_timing(run: impl FnOnce() -> Result) -> Result<(T, Duration), E> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let now = Instant::now(); [INFO] [stdout] 116 | run().map(|value| (value, now.elapsed())) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn with_root(root: Item) -> Builder { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut entry_index_by_guid = HashMap::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | deleted_guids: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:63:34 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn with_root(root: Item) -> Builder { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut entry_index_by_guid = HashMap::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | reparent_orphans_to: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:473:12 [INFO] [stdout] | [INFO] [stdout] 320 | fn try_from(mut builder: Builder) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let mut problems = Problems::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | let mut zombies = SmallBitVec::from_elem(builder.entries.len(), false); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | let mut entries = Vec::with_capacity(builder.entries.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 473 | Ok(Tree { [INFO] [stdout] | ____________^ [INFO] [stdout] 474 | | entry_index_by_guid: builder.entry_index_by_guid, [INFO] [stdout] 475 | | entries, [INFO] [stdout] 476 | | deleted_guids: builder.deleted_guids, [INFO] [stdout] 477 | | problems, [INFO] [stdout] 478 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:1782:30 [INFO] [stdout] | [INFO] [stdout] 1778 | pub fn new(guid: Guid, merge_state: MergeState<'t>) -> MergedNode<'t> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1782 | merged_children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dogear` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "87ef8ba04f1de6620ff1a3acd723fd9753fed2a4ae943bb431083e4cb77948bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87ef8ba04f1de6620ff1a3acd723fd9753fed2a4ae943bb431083e4cb77948bf", kill_on_drop: false }` [INFO] [stdout] 87ef8ba04f1de6620ff1a3acd723fd9753fed2a4ae943bb431083e4cb77948bf