[INFO] fetching crate dodrio 0.2.0... [INFO] checking dodrio-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dodrio 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dodrio 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dodrio 0.2.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate dodrio 0.2.0 [INFO] tweaked toml for crates.io crate dodrio 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bumpalo v2.6.0 (latest: v3.16.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding console_log v0.2.2 (latest: v1.0.0) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a8c2aff45e3fa1ad19f56a87367a4ed1e3ac1a46bbea109641aff651be494d2 [INFO] running `Command { std: "docker" "start" "-a" "7a8c2aff45e3fa1ad19f56a87367a4ed1e3ac1a46bbea109641aff651be494d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a8c2aff45e3fa1ad19f56a87367a4ed1e3ac1a46bbea109641aff651be494d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a8c2aff45e3fa1ad19f56a87367a4ed1e3ac1a46bbea109641aff651be494d2", kill_on_drop: false }` [INFO] [stdout] 7a8c2aff45e3fa1ad19f56a87367a4ed1e3ac1a46bbea109641aff651be494d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1dca146fa41ec04be94f77483c338eb601c760740f6ad6bb5b973ce746248ba2 [INFO] running `Command { std: "docker" "start" "-a" "1dca146fa41ec04be94f77483c338eb601c760740f6ad6bb5b973ce746248ba2", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking longest-increasing-subsequence v0.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bumpalo v2.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.43 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking wasm-bindgen-test v0.3.43 [INFO] [stderr] Checking dodrio v0.2.0 [INFO] [stderr] Checking console_log v0.2.2 [INFO] [stderr] Checking dodrio v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `bump` is never read [INFO] [stdout] --> src/cached_set.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) struct CacheEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 28 | bump: Bump, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CacheEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_context.rs:86:59 [INFO] [stdout] | [INFO] [stdout] 86 | let cache_id = self.cache(true, None, |nested_cx| R::default().render(nested_cx)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdom.rs:161:49 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(container: &crate::Element, component: R) -> Vdom [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Self::with_boxed_root_render(container, Box::new(component) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdom.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn unmount(self) -> Box { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | / Rc::try_unwrap(self.inner.clone()) [INFO] [stdout] 245 | | .map_err(|_| ()) [INFO] [stdout] 246 | | .unwrap_throw() [INFO] [stdout] 247 | | .exclusive [INFO] [stdout] 248 | | .into_inner() [INFO] [stdout] 249 | | .component [INFO] [stdout] 250 | | .take() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdom.rs:470:13 [INFO] [stdout] | [INFO] [stdout] 435 | let inner = self.inner.upgrade(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | let inner = inner.ok_or(VdomDroppedError {})?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | [INFO] [stdout] 440 | let promise = inner.shared.render_scheduled.take().unwrap_or_else(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | / JsFuture::from(promise) [INFO] [stdout] 471 | | .await [INFO] [stdout] 472 | | .map(drop) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vdom.rs:446:56 [INFO] [stdout] | [INFO] [stdout] 441 | js_sys::Promise::new(&mut |resolve, reject| { [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let vdom = VdomWeak { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | with_animation_frame(move || match vdom.inner.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dodrio` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1dca146fa41ec04be94f77483c338eb601c760740f6ad6bb5b973ce746248ba2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dca146fa41ec04be94f77483c338eb601c760740f6ad6bb5b973ce746248ba2", kill_on_drop: false }` [INFO] [stdout] 1dca146fa41ec04be94f77483c338eb601c760740f6ad6bb5b973ce746248ba2