[INFO] fetching crate docuglot 0.7.0... [INFO] checking docuglot-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate docuglot 0.7.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate docuglot 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate docuglot 0.7.0 [INFO] finished tweaking crates.io crate docuglot 0.7.0 [INFO] tweaked toml for crates.io crate docuglot 0.7.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cur v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding cur_macro v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lsp-types v0.88.0 (latest: v0.97.0) [INFO] [stderr] Adding market v0.26.0 (latest: v0.30.1) [INFO] [stderr] Adding parse-display v0.1.2 (latest: v0.10.0) [INFO] [stderr] Adding parse-display-derive v0.1.2 (latest: v0.10.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 736d45f423ea07ef4b87703ec55c5fc71cdd1d87ea6cb8068a7f849c5f81122c [INFO] running `Command { std: "docker" "start" "-a" "736d45f423ea07ef4b87703ec55c5fc71cdd1d87ea6cb8068a7f849c5f81122c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "736d45f423ea07ef4b87703ec55c5fc71cdd1d87ea6cb8068a7f849c5f81122c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "736d45f423ea07ef4b87703ec55c5fc71cdd1d87ea6cb8068a7f849c5f81122c", kill_on_drop: false }` [INFO] [stdout] 736d45f423ea07ef4b87703ec55c5fc71cdd1d87ea6cb8068a7f849c5f81122c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fc2676ede059feb43332fdd7fb5e6b53d4027b8bc4d78f74b9ceb0129e10892 [INFO] running `Command { std: "docker" "start" "-a" "2fc2676ede059feb43332fdd7fb5e6b53d4027b8bc4d78f74b9ceb0129e10892", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling fehler-macros v1.0.0 [INFO] [stderr] Compiling market_derive v0.1.0 [INFO] [stderr] Compiling cur_macro v0.4.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking cur v0.4.0 [INFO] [stderr] Checking fehler v1.0.0 [INFO] [stderr] Checking conventus v0.3.0 [INFO] [stderr] Compiling parse-display-derive v0.1.2 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking parse-display v0.1.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking market v0.26.0 [INFO] [stderr] Checking lsp-types v0.88.0 [INFO] [stderr] Checking docuglot v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `status_consumer` is never read [INFO] [stdout] --> src/lib.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct Tongue { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | status_consumer: CrossbeamConsumer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tongue` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 76 | let (transmitter, transmission_consumer) = create::>( [INFO] [stdout] | ----------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let (reception_producer, receiver) = [INFO] [stdout] | ------------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | create::>("Tongue Reception Channel".to_string(), Size::Infinite); [INFO] [stdout] 82 | let (status_producer, status_consumer) = [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | create::>("Tongue Status Channel".to_string(), Size::Infinite); [INFO] [stdout] 84 | let params = TongueThreadParams { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | thread: Thread::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 93 | | "docuglot tongue".to_string(), [INFO] [stdout] 94 | | thread::Kind::Single, [INFO] [stdout] 95 | | params, [INFO] [stdout] 96 | | Self::thread_fn, [INFO] [stdout] 97 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|t| t.borrow().is_waiting_exit()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 266 | pub(crate) fn new(command: Command, root_dir: Url) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | / Self { [INFO] [stdout] 268 | | lsp_server: market::process::Process::new(command)?, [INFO] [stdout] 269 | | state: State::Uninitialized { root_dir }, [INFO] [stdout] 270 | | rpc_client: json_rpc::Client::new(), [INFO] [stdout] ... | [INFO] [stdout] 273 | | }])?, [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 279 | pub(crate) fn new_finished(command: Command) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | / Self { [INFO] [stdout] 281 | | lsp_server: market::process::Process::new(command)?, [INFO] [stdout] 282 | | state: State::WaitingExit, [INFO] [stdout] 283 | | rpc_client: json_rpc::Client::new(), [INFO] [stdout] ... | [INFO] [stdout] 286 | | }])?, [INFO] [stdout] 287 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:439:29 [INFO] [stdout] | [INFO] [stdout] 439 | |_, value| Some(serde_json::from_value(value).map(Event::DocumentSymbol)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:613:63 [INFO] [stdout] | [INFO] [stdout] 612 | serde_json::from_str(content).map_err(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | conventus::AssembleFailure::Error(AssembleMessageError::from(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docuglot` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `status_consumer` is never read [INFO] [stdout] --> src/lib.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 60 | pub struct Tongue { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | status_consumer: CrossbeamConsumer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tongue` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 76 | let (transmitter, transmission_consumer) = create::>( [INFO] [stdout] | ----------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let (reception_producer, receiver) = [INFO] [stdout] | ------------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | create::>("Tongue Reception Channel".to_string(), Size::Infinite); [INFO] [stdout] 82 | let (status_producer, status_consumer) = [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | create::>("Tongue Status Channel".to_string(), Size::Infinite); [INFO] [stdout] 84 | let params = TongueThreadParams { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | thread: Thread::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 93 | | "docuglot tongue".to_string(), [INFO] [stdout] 94 | | thread::Kind::Single, [INFO] [stdout] 95 | | params, [INFO] [stdout] 96 | | Self::thread_fn, [INFO] [stdout] 97 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | .map(|t| t.borrow().is_waiting_exit()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 266 | pub(crate) fn new(command: Command, root_dir: Url) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | / Self { [INFO] [stdout] 268 | | lsp_server: market::process::Process::new(command)?, [INFO] [stdout] 269 | | state: State::Uninitialized { root_dir }, [INFO] [stdout] 270 | | rpc_client: json_rpc::Client::new(), [INFO] [stdout] ... | [INFO] [stdout] 273 | | }])?, [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 279 | pub(crate) fn new_finished(command: Command) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | / Self { [INFO] [stdout] 281 | | lsp_server: market::process::Process::new(command)?, [INFO] [stdout] 282 | | state: State::WaitingExit, [INFO] [stdout] 283 | | rpc_client: json_rpc::Client::new(), [INFO] [stdout] ... | [INFO] [stdout] 286 | | }])?, [INFO] [stdout] 287 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:439:29 [INFO] [stdout] | [INFO] [stdout] 439 | |_, value| Some(serde_json::from_value(value).map(Event::DocumentSymbol)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsp.rs:613:63 [INFO] [stdout] | [INFO] [stdout] 612 | serde_json::from_str(content).map_err(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 613 | conventus::AssembleFailure::Error(AssembleMessageError::from(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docuglot` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2fc2676ede059feb43332fdd7fb5e6b53d4027b8bc4d78f74b9ceb0129e10892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fc2676ede059feb43332fdd7fb5e6b53d4027b8bc4d78f74b9ceb0129e10892", kill_on_drop: false }` [INFO] [stdout] 2fc2676ede059feb43332fdd7fb5e6b53d4027b8bc4d78f74b9ceb0129e10892