[INFO] fetching crate doctor-syn 0.1.0... [INFO] checking doctor-syn-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate doctor-syn 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate doctor-syn 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate doctor-syn 0.1.0 [INFO] finished tweaking crates.io crate doctor-syn 0.1.0 [INFO] tweaked toml for crates.io crate doctor-syn 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate doctor-syn 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d33dcfb8e676a055e508e7795af7c7657edd72255241e9dc0ea828ebe9531a9f [INFO] running `Command { std: "docker" "start" "-a" "d33dcfb8e676a055e508e7795af7c7657edd72255241e9dc0ea828ebe9531a9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d33dcfb8e676a055e508e7795af7c7657edd72255241e9dc0ea828ebe9531a9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d33dcfb8e676a055e508e7795af7c7657edd72255241e9dc0ea828ebe9531a9f", kill_on_drop: false }` [INFO] [stdout] d33dcfb8e676a055e508e7795af7c7657edd72255241e9dc0ea828ebe9531a9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d5d139174da26d30c1616816a47d1764be2fb2175dcf86bfc25b1325da1ea01 [INFO] running `Command { std: "docker" "start" "-a" "8d5d139174da26d30c1616816a47d1764be2fb2175dcf86bfc25b1325da1ea01", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking quote v1.0.9 [INFO] [stderr] Checking doctor-syn v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `variable` is never read [INFO] [stdout] --> src/transformation/collect.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Collect { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 11 | pub(crate) variable: Name, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Collect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | let inner: ExprLit = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | syn::parse_str(s.as_str()).map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | inner: inner.into(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let inner: ExprLit = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | syn::parse_str(s.as_str()).map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | inner: inner.into(), [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 147 | let inner : Expr = syn::parse_str(s) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | .map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 149 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn subst(&self, variables: VariableList) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok(Subst { variables }.visit_expr(&self.inner)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 191 | let expr: Expr = Eval:: { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | Ok(Expression::from(expr).try_into()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn collect_terms(&self, variable: Name) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Ok(Collect { variable }.visit_expr(&self.inner)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/approx.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 65 | variable: Name, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | mul_add_polynomial(poly.terms(), parity, expr.span()).map(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/expand.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 68 | let mut sum = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let expr : Expr = exprbinary.clone().into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | match_sum(&expr, &mut sum, false)?; [INFO] [stdout] 71 | Ok(make_sum(&*sum)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/paren.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | let expr = self.visit_expr_core(expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(match expr { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | Expr::Binary(ExprBinary{ left, right, op, ..}) => { [INFO] [stdout] 23 | | let left = parenthesise_op(*left.clone()); [INFO] [stdout] 24 | | let right = parenthesise_op(*right.clone()); [INFO] [stdout] ... | [INFO] [stdout] 32 | | _ => expr [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn make_paren(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | / ExprParen { [INFO] [stdout] 66 | | attrs: vec![], [INFO] [stdout] 67 | | paren_token: syn::token::Paren(expr.span()), [INFO] [stdout] 68 | | expr: Box::new(expr), [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn make_binary(left: Expr, op: BinOp, right: Expr) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / ExprBinary { [INFO] [stdout] 75 | | attrs: vec![], [INFO] [stdout] 76 | | left: Box::new(left), [INFO] [stdout] 77 | | op: op, [INFO] [stdout] 78 | | right: Box::new(right), [INFO] [stdout] 79 | | }.into() [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn make_unary(op: UnOp, expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | / ExprUnary { [INFO] [stdout] 84 | | attrs: vec![], [INFO] [stdout] 85 | | op: op, [INFO] [stdout] 86 | | expr: Box::new(expr), [INFO] [stdout] 87 | | }.into() [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variablelist.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(vec: Vec<(Name, Expression)>) -> VariableList { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | VariableList { [INFO] [stdout] 11 | inner: vec.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 16 | let receiver = self.visit_expr(&expr.receiver)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let args: Punctuated = expr [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(ExprMethodCall { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | attrs: expr.attrs.clone(), [INFO] [stdout] 24 | | receiver: Box::new(receiver), [INFO] [stdout] 25 | | dot_token: expr.dot_token.clone(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | .into()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | let base = self.visit_expr(&exprfield.base)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(ExprField { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | attrs: exprfield.attrs.clone(), [INFO] [stdout] 49 | | base: Box::new(base), [INFO] [stdout] 50 | | dot_token: exprfield.dot_token, [INFO] [stdout] 51 | | member: exprfield.member.clone(), [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 58 | let expr = self.visit_expr(&exprparen.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(ExprParen { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | attrs: exprparen.attrs.clone(), [INFO] [stdout] 61 | | paren_token: exprparen.paren_token.clone(), [INFO] [stdout] 62 | | expr: Box::new(expr), [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | let left = self.visit_expr(&exprbinary.left)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let right = self.visit_expr(&exprbinary.right)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Ok(ExprBinary { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | attrs: exprbinary.attrs.clone(), [INFO] [stdout] 92 | | left: Box::new(left), [INFO] [stdout] 93 | | op: exprbinary.op.clone(), [INFO] [stdout] 94 | | right: Box::new(right), [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | .into()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 100 | let expr = self.visit_expr(&exprunary.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Ok(ExprUnary { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | attrs: exprunary.attrs.clone(), [INFO] [stdout] 103 | | op: exprunary.op, [INFO] [stdout] 104 | | expr: Box::new(expr), [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doctor-syn` (lib) due to 19 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `variable` is never read [INFO] [stdout] --> src/transformation/collect.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Collect { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 11 | pub(crate) variable: Name, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Collect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | let inner: ExprLit = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | syn::parse_str(s.as_str()).map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | inner: inner.into(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let inner: ExprLit = [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | syn::parse_str(s.as_str()).map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 51 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | inner: inner.into(), [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 147 | let inner : Expr = syn::parse_str(s) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | .map_err(|_| Error::CouldNotParse(Span::call_site()))?; [INFO] [stdout] 149 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn subst(&self, variables: VariableList) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok(Subst { variables }.visit_expr(&self.inner)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 191 | let expr: Expr = Eval:: { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | Ok(Expression::from(expr).try_into()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn collect_terms(&self, variable: Name) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Ok(Collect { variable }.visit_expr(&self.inner)?.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/approx.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 65 | variable: Name, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | mul_add_polynomial(poly.terms(), parity, expr.span()).map(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/expand.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 68 | let mut sum = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let expr : Expr = exprbinary.clone().into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | match_sum(&expr, &mut sum, false)?; [INFO] [stdout] 71 | Ok(make_sum(&*sum)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/paren.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | let expr = self.visit_expr_core(expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(match expr { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | Expr::Binary(ExprBinary{ left, right, op, ..}) => { [INFO] [stdout] 23 | | let left = parenthesise_op(*left.clone()); [INFO] [stdout] 24 | | let right = parenthesise_op(*right.clone()); [INFO] [stdout] ... | [INFO] [stdout] 32 | | _ => expr [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn make_paren(expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | / ExprParen { [INFO] [stdout] 66 | | attrs: vec![], [INFO] [stdout] 67 | | paren_token: syn::token::Paren(expr.span()), [INFO] [stdout] 68 | | expr: Box::new(expr), [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn make_binary(left: Expr, op: BinOp, right: Expr) -> Expr { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / ExprBinary { [INFO] [stdout] 75 | | attrs: vec![], [INFO] [stdout] 76 | | left: Box::new(left), [INFO] [stdout] 77 | | op: op, [INFO] [stdout] 78 | | right: Box::new(right), [INFO] [stdout] 79 | | }.into() [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transformation/tools.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn make_unary(op: UnOp, expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | / ExprUnary { [INFO] [stdout] 84 | | attrs: vec![], [INFO] [stdout] 85 | | op: op, [INFO] [stdout] 86 | | expr: Box::new(expr), [INFO] [stdout] 87 | | }.into() [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variablelist.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(vec: Vec<(Name, Expression)>) -> VariableList { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | VariableList { [INFO] [stdout] 11 | inner: vec.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 16 | let receiver = self.visit_expr(&expr.receiver)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let args: Punctuated = expr [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(ExprMethodCall { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | attrs: expr.attrs.clone(), [INFO] [stdout] 24 | | receiver: Box::new(receiver), [INFO] [stdout] 25 | | dot_token: expr.dot_token.clone(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | .into()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 46 | let base = self.visit_expr(&exprfield.base)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(ExprField { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | attrs: exprfield.attrs.clone(), [INFO] [stdout] 49 | | base: Box::new(base), [INFO] [stdout] 50 | | dot_token: exprfield.dot_token, [INFO] [stdout] 51 | | member: exprfield.member.clone(), [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 58 | let expr = self.visit_expr(&exprparen.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(ExprParen { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | attrs: exprparen.attrs.clone(), [INFO] [stdout] 61 | | paren_token: exprparen.paren_token.clone(), [INFO] [stdout] 62 | | expr: Box::new(expr), [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | let left = self.visit_expr(&exprbinary.left)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let right = self.visit_expr(&exprbinary.right)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Ok(ExprBinary { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | attrs: exprbinary.attrs.clone(), [INFO] [stdout] 92 | | left: Box::new(left), [INFO] [stdout] 93 | | op: exprbinary.op.clone(), [INFO] [stdout] 94 | | right: Box::new(right), [INFO] [stdout] 95 | | } [INFO] [stdout] 96 | | .into()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 100 | let expr = self.visit_expr(&exprunary.expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Ok(ExprUnary { [INFO] [stdout] | ____________^ [INFO] [stdout] 102 | | attrs: exprunary.attrs.clone(), [INFO] [stdout] 103 | | op: exprunary.op, [INFO] [stdout] 104 | | expr: Box::new(expr), [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doctor-syn` (lib test) due to 19 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8d5d139174da26d30c1616816a47d1764be2fb2175dcf86bfc25b1325da1ea01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d5d139174da26d30c1616816a47d1764be2fb2175dcf86bfc25b1325da1ea01", kill_on_drop: false }` [INFO] [stdout] 8d5d139174da26d30c1616816a47d1764be2fb2175dcf86bfc25b1325da1ea01