[INFO] fetching crate docket 0.7.1... [INFO] checking docket-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate docket 0.7.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate docket 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate docket 0.7.1 [INFO] finished tweaking crates.io crate docket 0.7.1 [INFO] tweaked toml for crates.io crate docket 0.7.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate docket 0.7.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `pulldown-cmark` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce2360f8ad9e93b9c504dc944517a405da9aaf0858ff17a52cdcb1bbb7cbcab4 [INFO] running `Command { std: "docker" "start" "-a" "ce2360f8ad9e93b9c504dc944517a405da9aaf0858ff17a52cdcb1bbb7cbcab4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce2360f8ad9e93b9c504dc944517a405da9aaf0858ff17a52cdcb1bbb7cbcab4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce2360f8ad9e93b9c504dc944517a405da9aaf0858ff17a52cdcb1bbb7cbcab4", kill_on_drop: false }` [INFO] [stdout] ce2360f8ad9e93b9c504dc944517a405da9aaf0858ff17a52cdcb1bbb7cbcab4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cf0bd7a271284c5e03c21e786990cca626359acc65ac1b32969ea3500542bec [INFO] running `Command { std: "docker" "start" "-a" "2cf0bd7a271284c5e03c21e786990cca626359acc65ac1b32969ea3500542bec", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `pulldown-cmark` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling serde_derive v1.0.139 [INFO] [stderr] Compiling serde v1.0.139 [INFO] [stderr] Compiling onig_sys v69.8.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Compiling pulldown-cmark v0.9.1 [INFO] [stderr] Checking time v0.3.11 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking onig v6.3.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking plist v1.3.1 [INFO] [stderr] Checking docopt v1.1.1 [INFO] [stderr] Checking syntect v5.0.0 [INFO] [stderr] Checking docket v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `write_header` is never used [INFO] [stdout] --> src/highlight.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) trait Highlighter { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn write_header(&self, out: &mut dyn Write) -> std::io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docket` (bin "docket") due to 8 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:42:33 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 43 | | d.argv(argv) [INFO] [stdout] 44 | | .help(true) [INFO] [stdout] 45 | | .version(Some(format!("Docket {}", env!("CARGO_PKG_VERSION")))) [INFO] [stdout] 46 | | .deserialize() [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | / d.argv(argv) [INFO] [stdout] 44 | | .help(true) [INFO] [stdout] 45 | | .version(Some(format!("Docket {}", env!("CARGO_PKG_VERSION")))) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn annotated(anno: S, err: E) -> Self [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Error::Annotated(anno.into(), Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn annotate_err(self, anno: A) -> Result { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.map_err(|err| Error::annotated(anno, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:228:28 [INFO] [stdout] | [INFO] [stdout] 226 | fn nested(slug: &str, inner: RenderedItem) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let slug = format!("{}/{}", slug, inner.slug()); [INFO] [stdout] 228 | Self::Nested(slug, Box::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toc.rs:281:35 [INFO] [stdout] | [INFO] [stdout] 277 | fn parse_toc_events<'a, I>(events: I) -> Vec [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | parse_toc_at_level(None, &mut events.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_header` is never used [INFO] [stdout] --> src/highlight.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) trait Highlighter { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 24 | fn write_header(&self, out: &mut dyn Write) -> std::io::Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:42:33 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 43 | | d.argv(argv) [INFO] [stdout] 44 | | .help(true) [INFO] [stdout] 45 | | .version(Some(format!("Docket {}", env!("CARGO_PKG_VERSION")))) [INFO] [stdout] 46 | | .deserialize() [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 40 | argv: I, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Result { [INFO] [stdout] 42 | Docopt::new(USAGE).and_then(|d| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | / d.argv(argv) [INFO] [stdout] 44 | | .help(true) [INFO] [stdout] 45 | | .version(Some(format!("Docket {}", env!("CARGO_PKG_VERSION")))) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn annotated(anno: S, err: E) -> Self [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Error::Annotated(anno.into(), Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 75 | fn annotate_err(self, anno: A) -> Result { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.map_err(|err| Error::annotated(anno, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:228:28 [INFO] [stdout] | [INFO] [stdout] 226 | fn nested(slug: &str, inner: RenderedItem) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | let slug = format!("{}/{}", slug, inner.slug()); [INFO] [stdout] 228 | Self::Nested(slug, Box::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/toc.rs:281:35 [INFO] [stdout] | [INFO] [stdout] 277 | fn parse_toc_events<'a, I>(events: I) -> Vec [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | parse_toc_at_level(None, &mut events.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docket` (bin "docket" test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2cf0bd7a271284c5e03c21e786990cca626359acc65ac1b32969ea3500542bec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cf0bd7a271284c5e03c21e786990cca626359acc65ac1b32969ea3500542bec", kill_on_drop: false }` [INFO] [stdout] 2cf0bd7a271284c5e03c21e786990cca626359acc65ac1b32969ea3500542bec