[INFO] fetching crate docbot 0.3.0-alpha.2... [INFO] checking docbot-0.3.0-alpha.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate docbot 0.3.0-alpha.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate docbot 0.3.0-alpha.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate docbot 0.3.0-alpha.2 [INFO] finished tweaking crates.io crate docbot 0.3.0-alpha.2 [INFO] tweaked toml for crates.io crate docbot 0.3.0-alpha.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad2e8859a80cb4d965ab0a724976de72ea47874acfb98013ce690bb5f9f3375a [INFO] running `Command { std: "docker" "start" "-a" "ad2e8859a80cb4d965ab0a724976de72ea47874acfb98013ce690bb5f9f3375a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad2e8859a80cb4d965ab0a724976de72ea47874acfb98013ce690bb5f9f3375a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad2e8859a80cb4d965ab0a724976de72ea47874acfb98013ce690bb5f9f3375a", kill_on_drop: false }` [INFO] [stdout] ad2e8859a80cb4d965ab0a724976de72ea47874acfb98013ce690bb5f9f3375a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68a8814db1cff567e9ee4cce1365099d127f091bdf2e160932de2f2e69a227c2 [INFO] running `Command { std: "docker" "start" "-a" "68a8814db1cff567e9ee4cce1365099d127f091bdf2e160932de2f2e69a227c2", kill_on_drop: false }` [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling docbot-derive v0.3.0-alpha.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking docbot v0.3.0-alpha.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | iter: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ) -> Result, PathParseError> { [INFO] [stdout] 151 | Self::parse(iter).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | |p| Ok(Some(p)), [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> did_you_mean.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 24 | given: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | options: impl IntoIterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut heap = options [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / std::iter::from_fn(move || heap.pop()) [INFO] [stdout] 44 | | .take_while(|DidYouMean(s, _)| *s >= 0.3) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | fn from(anyhow: Anyhow) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | (@cls $then:expr, $($else:expr),+) => { |e| try_downcast!(@map e => $then, $($else),+) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | (@cls $then:expr, $($else:expr),+) => { |e| try_downcast!(@map e => $then, $($else),+) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn fold_anyhow(&self, err: Anyhow) -> Self::Output { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match err.into() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 143 | mut w: impl Write, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | opts: impl IntoIterator, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | ) -> fmt::Result { [INFO] [stdout] 146 | opts.into_iter().enumerate().try_for_each(|(i, opt)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docbot` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | iter: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ) -> Result, PathParseError> { [INFO] [stdout] 151 | Self::parse(iter).map_or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 156 | |p| Ok(Some(p)), [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> did_you_mean.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 24 | given: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | options: impl IntoIterator, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let mut heap = options [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / std::iter::from_fn(move || heap.pop()) [INFO] [stdout] 44 | | .take_while(|DidYouMean(s, _)| *s >= 0.3) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | fn from(anyhow: Anyhow) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | (@cls $then:expr, $($else:expr),+) => { |e| try_downcast!(@map e => $then, $($else),+) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | $id.downcast().map_or_else(try_downcast!(@cls $($else),+), $then) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | (@cls $then:expr, $($else:expr),+) => { |e| try_downcast!(@map e => $then, $($else),+) }; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / try_downcast!(anyhow => [INFO] [stdout] 32 | | Self::CommandParse, [INFO] [stdout] 33 | | Self::IdParse, [INFO] [stdout] 34 | | Self::PathParse, [INFO] [stdout] 35 | | Self::Other, [INFO] [stdout] 36 | | ) [INFO] [stdout] | |_________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try_downcast` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn fold_anyhow(&self, err: Anyhow) -> Self::Output { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | match err.into() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> fold_error.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 143 | mut w: impl Write, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | opts: impl IntoIterator, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | ) -> fmt::Result { [INFO] [stdout] 146 | opts.into_iter().enumerate().try_for_each(|(i, opt)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `docbot` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "68a8814db1cff567e9ee4cce1365099d127f091bdf2e160932de2f2e69a227c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68a8814db1cff567e9ee4cce1365099d127f091bdf2e160932de2f2e69a227c2", kill_on_drop: false }` [INFO] [stdout] 68a8814db1cff567e9ee4cce1365099d127f091bdf2e160932de2f2e69a227c2