[INFO] fetching crate doc-sync 0.1.2... [INFO] checking doc-sync-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate doc-sync 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate doc-sync 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate doc-sync 0.1.2 [INFO] finished tweaking crates.io crate doc-sync 0.1.2 [INFO] tweaked toml for crates.io crate doc-sync 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate doc-sync 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 838af995ce6fd1007678893d5f89a6d6ed044b9df5b25cf034cc1fc06e12ff51 [INFO] running `Command { std: "docker" "start" "-a" "838af995ce6fd1007678893d5f89a6d6ed044b9df5b25cf034cc1fc06e12ff51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "838af995ce6fd1007678893d5f89a6d6ed044b9df5b25cf034cc1fc06e12ff51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "838af995ce6fd1007678893d5f89a6d6ed044b9df5b25cf034cc1fc06e12ff51", kill_on_drop: false }` [INFO] [stdout] 838af995ce6fd1007678893d5f89a6d6ed044b9df5b25cf034cc1fc06e12ff51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3de8646944e46012790a6bad17ad69ceab01933aad80ac94f2eb928daf76feb [INFO] running `Command { std: "docker" "start" "-a" "e3de8646944e46012790a6bad17ad69ceab01933aad80ac94f2eb928daf76feb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Compiling serde v1.0.180 [INFO] [stderr] Compiling serde_derive v1.0.180 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling rustix v0.38.6 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling prettyplease v0.2.12 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking winnow v0.5.3 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling xshell-macros v0.2.5 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Compiling easy-ext v1.0.1 [INFO] [stderr] Checking quote v1.0.32 [INFO] [stderr] Checking normalize-path v0.2.1 [INFO] [stderr] Checking cli-failure v1.0.0 [INFO] [stderr] Checking xshell v0.2.5 [INFO] [stderr] Checking syn v2.0.28 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Checking regex-automata v0.3.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking rustdoc-types v0.22.0 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking toml_edit v0.19.14 [INFO] [stderr] Compiling custom_debug_derive v0.5.1 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling wrap-match-impl v1.0.7 [INFO] [stderr] Checking toml v0.7.6 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking wrap-match v1.0.7 [INFO] [stderr] Compiling pest v2.7.2 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Compiling pest_meta v2.7.2 [INFO] [stderr] Compiling pest_generator v2.7.2 [INFO] [stderr] Compiling pest_derive v2.7.2 [INFO] [stderr] Checking doc-sync v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/doc_comment_parser.rs:65:34 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct InvalidDocCommentType(String); [INFO] [stdout] | --------------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidDocCommentType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rustdoc_item` is never read [INFO] [stdout] --> src/from_markdown/item_info.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct ItemInfo<'lt> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub rustdoc_item: &'lt rustdoc_types::Item, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let manifest = sh.read_file("./Cargo.toml")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | let manifest: Table = Table::from_str(&manifest)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | let git_output = cmd!(sh, "git status --short").output()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | let crate_name = get_crate_name(&sh)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | let json = sh.read_file(&json_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let json: Crate = serde_json::from_str(&json)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | for file in glob(&format!("{}/**/*.md", input_dir.display()))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | sh.write_file(input_dir.join(FROM_MARKDOWN_MARKER), "This file is created to tell doc-sync's to-markdown subcommand that it's probably safe to overwrite the generated markdown files as a safeguard against losing work."... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | cmd!(sh, "cargo fmt").run()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | let new_docs = sh.read_file(&file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 41 | let captures = id_capture [INFO] [stdout] | ____________________^ [INFO] [stdout] 42 | | .captures(&new_docs) [INFO] [stdout] 43 | | .ok_or_else(|| failure_raw!("No rustdoc ID found"))?; [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | let rustdoc_item = json.index.get(&id).ok_or_else(|| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 53 | | failure_raw!( [INFO] [stdout] 54 | | "No item found; did you re-run rustdoc in JSON output format since using to-markdown?" [INFO] [stdout] 55 | | ) [INFO] [stdout] 56 | | })?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | let file_path = rustdoc_item [INFO] [stdout] | _____________________^ [INFO] [stdout] 77 | | .span [INFO] [stdout] 78 | | .as_ref() [INFO] [stdout] 79 | | .ok_or_else(|| failure_raw!("No span for item"))? [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | let item_path = ItemPath::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 108 | | &file_module_path, [INFO] [stdout] 109 | | AbsoluteModulePath(&module_path), [INFO] [stdout] 110 | | &json, [INFO] [stdout] 111 | | ) [INFO] [stdout] 112 | | .ok_or_else(|| failure_raw!("Couldn't find item for part (see above); did you re-run rustdoc in JSON output format since using to-markdown?")... [INFO] [stdout] | |___________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | let mut file_contents = sh.read_file(&item.file_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | let syn_file = syn::parse_file(&file_contents)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let syn_item = resolve_item(&syn_file.items, item.item_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | sh.write_file(format!("target/{}", item.file_path), file_contents)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | sh.remove_path(&output_dir)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 43 | let crate_name = get_crate_name(&sh)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / cmd!( [INFO] [stdout] 56 | | sh, [INFO] [stdout] 57 | | "cargo {cargo_arguments} doc --no-deps {cargo_doc_arguments...}" [INFO] [stdout] 58 | | ) [INFO] [stdout] 59 | | .env("RUSTDOCFLAGS", rustdoc_arguments) [INFO] [stdout] 60 | | .env_remove("RUSTFLAGS") [INFO] [stdout] 61 | | .run()?; [INFO] [stdout] | |___________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | let json = sh.read_file(&json_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 68 | let json: Crate = serde_json::from_str(&json)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / handle_item( [INFO] [stdout] 74 | | &sh, [INFO] [stdout] 75 | | &json, [INFO] [stdout] 76 | | &output_dir, [INFO] [stdout] ... | [INFO] [stdout] 81 | | &item.kind, [INFO] [stdout] 82 | | )?; [INFO] [stdout] | |__________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doc-sync` (bin "doc-sync") due to 25 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/doc_comment_parser.rs:65:34 [INFO] [stdout] | [INFO] [stdout] 65 | pub struct InvalidDocCommentType(String); [INFO] [stdout] | --------------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `InvalidDocCommentType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rustdoc_item` is never read [INFO] [stdout] --> src/from_markdown/item_info.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct ItemInfo<'lt> { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 23 | pub rustdoc_item: &'lt rustdoc_types::Item, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | let manifest = sh.read_file("./Cargo.toml")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | let manifest: Table = Table::from_str(&manifest)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | let git_output = cmd!(sh, "git status --short").output()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | let crate_name = get_crate_name(&sh)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | let json = sh.read_file(&json_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let json: Crate = serde_json::from_str(&json)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | for file in glob(&format!("{}/**/*.md", input_dir.display()))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | sh.write_file(input_dir.join(FROM_MARKDOWN_MARKER), "This file is created to tell doc-sync's to-markdown subcommand that it's probably safe to overwrite the generated markdown files as a safeguard against losing work."... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/mod.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | cmd!(sh, "cargo fmt").run()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 40 | let new_docs = sh.read_file(&file)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 41 | let captures = id_capture [INFO] [stdout] | ____________________^ [INFO] [stdout] 42 | | .captures(&new_docs) [INFO] [stdout] 43 | | .ok_or_else(|| failure_raw!("No rustdoc ID found"))?; [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | let rustdoc_item = json.index.get(&id).ok_or_else(|| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 53 | | failure_raw!( [INFO] [stdout] 54 | | "No item found; did you re-run rustdoc in JSON output format since using to-markdown?" [INFO] [stdout] 55 | | ) [INFO] [stdout] 56 | | })?; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | let file_path = rustdoc_item [INFO] [stdout] | _____________________^ [INFO] [stdout] 77 | | .span [INFO] [stdout] 78 | | .as_ref() [INFO] [stdout] 79 | | .ok_or_else(|| failure_raw!("No span for item"))? [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/item_info.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | let item_path = ItemPath::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 108 | | &file_module_path, [INFO] [stdout] 109 | | AbsoluteModulePath(&module_path), [INFO] [stdout] 110 | | &json, [INFO] [stdout] 111 | | ) [INFO] [stdout] 112 | | .ok_or_else(|| failure_raw!("Couldn't find item for part (see above); did you re-run rustdoc in JSON output format since using to-markdown?")... [INFO] [stdout] | |___________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | let mut file_contents = sh.read_file(&item.file_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | let syn_file = syn::parse_file(&file_contents)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | let syn_item = resolve_item(&syn_file.items, item.item_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_markdown/update_docs/mod.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | sh.write_file(format!("target/{}", item.file_path), file_contents)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | sh.remove_path(&output_dir)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:43:22 [INFO] [stdout] | [INFO] [stdout] 43 | let crate_name = get_crate_name(&sh)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / cmd!( [INFO] [stdout] 56 | | sh, [INFO] [stdout] 57 | | "cargo {cargo_arguments} doc --no-deps {cargo_doc_arguments...}" [INFO] [stdout] 58 | | ) [INFO] [stdout] 59 | | .env("RUSTDOCFLAGS", rustdoc_arguments) [INFO] [stdout] 60 | | .env_remove("RUSTFLAGS") [INFO] [stdout] 61 | | .run()?; [INFO] [stdout] | |___________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | let json = sh.read_file(&json_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 68 | let json: Crate = serde_json::from_str(&json)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_markdown/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / handle_item( [INFO] [stdout] 74 | | &sh, [INFO] [stdout] 75 | | &json, [INFO] [stdout] 76 | | &output_dir, [INFO] [stdout] ... | [INFO] [stdout] 81 | | &item.kind, [INFO] [stdout] 82 | | )?; [INFO] [stdout] | |__________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `doc-sync` (bin "doc-sync" test) due to 25 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e3de8646944e46012790a6bad17ad69ceab01933aad80ac94f2eb928daf76feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3de8646944e46012790a6bad17ad69ceab01933aad80ac94f2eb928daf76feb", kill_on_drop: false }` [INFO] [stdout] e3de8646944e46012790a6bad17ad69ceab01933aad80ac94f2eb928daf76feb