[INFO] fetching crate dns-firewall 1.2.2... [INFO] checking dns-firewall-1.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dns-firewall 1.2.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dns-firewall 1.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dns-firewall 1.2.2 [INFO] finished tweaking crates.io crate dns-firewall 1.2.2 [INFO] tweaked toml for crates.io crate dns-firewall 1.2.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate dns-firewall 1.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d3041594edf71bbd53ae10cd65d1064c009f6dce171d710b7899edd7dc51c75 [INFO] running `Command { std: "docker" "start" "-a" "3d3041594edf71bbd53ae10cd65d1064c009f6dce171d710b7899edd7dc51c75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d3041594edf71bbd53ae10cd65d1064c009f6dce171d710b7899edd7dc51c75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d3041594edf71bbd53ae10cd65d1064c009f6dce171d710b7899edd7dc51c75", kill_on_drop: false }` [INFO] [stdout] 3d3041594edf71bbd53ae10cd65d1064c009f6dce171d710b7899edd7dc51c75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c98ee7681c78ce4c3bdd316ced5bd739ec6eb0ab861ceea2a606908799a38fc [INFO] running `Command { std: "docker" "start" "-a" "2c98ee7681c78ce4c3bdd316ced5bd739ec6eb0ab861ceea2a606908799a38fc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Compiling async-trait v0.1.75 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling thiserror v1.0.52 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Compiling anyhow v1.0.76 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.52 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Checking hickory-proto v0.24.0 [INFO] [stderr] Checking hickory-resolver v0.24.0 [INFO] [stderr] Checking dns-firewall v1.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access_control_list_parser.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 16 | let file = File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | parse_input(BufReader::new(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_server.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 88 | let request_permit = self.processing_limit.clone().acquire_owned().await.unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let proxy = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_server.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 182 | let connection_permit = self.processing_limit.clone().acquire_owned().await.unwrap(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let (stream, client_address) = self.tcp_listener.accept().await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let proxy = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_server.rs:282:30 [INFO] [stdout] | [INFO] [stdout] 282 | ... .await) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_server/message_processor.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 454 | let mut response = hickory_proto::op::Message::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | / response [INFO] [stdout] 467 | | .emit(&mut encoder) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dns-firewall` (bin "dns-firewall") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2c98ee7681c78ce4c3bdd316ced5bd739ec6eb0ab861ceea2a606908799a38fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c98ee7681c78ce4c3bdd316ced5bd739ec6eb0ab861ceea2a606908799a38fc", kill_on_drop: false }` [INFO] [stdout] 2c98ee7681c78ce4c3bdd316ced5bd739ec6eb0ab861ceea2a606908799a38fc