[INFO] fetching crate dmx-rdm 0.0.12-alpha... [INFO] checking dmx-rdm-0.0.12-alpha against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dmx-rdm 0.0.12-alpha into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate dmx-rdm 0.0.12-alpha on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dmx-rdm 0.0.12-alpha [INFO] finished tweaking crates.io crate dmx-rdm 0.0.12-alpha [INFO] tweaked toml for crates.io crate dmx-rdm 0.0.12-alpha written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21cfabe052ef7c5054929ac0ce9944c14984cdc47cea42773b98cc349bd0a0f8 [INFO] running `Command { std: "docker" "start" "-a" "21cfabe052ef7c5054929ac0ce9944c14984cdc47cea42773b98cc349bd0a0f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21cfabe052ef7c5054929ac0ce9944c14984cdc47cea42773b98cc349bd0a0f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21cfabe052ef7c5054929ac0ce9944c14984cdc47cea42773b98cc349bd0a0f8", kill_on_drop: false }` [INFO] [stdout] 21cfabe052ef7c5054929ac0ce9944c14984cdc47cea42773b98cc349bd0a0f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d79a865a0e2d8f7e59f61afcf060d9746c432b62a3b58f9b6580c4048a691a3b [INFO] running `Command { std: "docker" "start" "-a" "d79a865a0e2d8f7e59f61afcf060d9746c432b62a3b58f9b6580c4048a691a3b", kill_on_drop: false }` [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking binary-layout v4.0.2 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking dmx-rdm v0.0.12-alpha (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_controller.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 340 | let response_info = match self.rdm_get(RdmRequest::empty( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | RdmResponse::Response(response_info) => response_info, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | Ok(rdm_packages::deserialize_software_version_label( [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | &response_info.data, [INFO] [stdout] 350 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_driver.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | Ok(DmxFrame::from_slice(&buffer[..bytes_read]).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:255:28 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | message_queue: heapless::Deque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | status_vec: heapless::Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:257:34 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | last_queued_message: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:258:38 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | last_status_vec_message: DataPack::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_data.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 47 | response: DataPack, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(RdmResponseData { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | destination_uid: PackageAddress::Device(self.source_uid), [INFO] [stdout] 52 | | source_uid: match self.destination_uid { [INFO] [stdout] 53 | | PackageAddress::Device(uid) => uid, [INFO] [stdout] ... | [INFO] [stdout] 62 | | parameter_data: response, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_packages.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | response_info: RdmResponseInfo, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | ) -> Result { [INFO] [stdout] 78 | Ok(match response_info.parameter_id { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | pids::IDENTIFY_DEVICE => { [INFO] [stdout] 80 | | RdmResponsePackage::IdentifyDevice(deserialize_identify(&response_info.data)?) [INFO] [stdout] 81 | | }, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => Self::Custom(response_info), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmx-rdm` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_controller.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 340 | let response_info = match self.rdm_get(RdmRequest::empty( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | RdmResponse::Response(response_info) => response_info, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | Ok(rdm_packages::deserialize_software_version_label( [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | &response_info.data, [INFO] [stdout] 350 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_driver.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | Ok(DmxFrame::from_slice(&buffer[..bytes_read]).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:255:28 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 255 | message_queue: heapless::Deque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:256:25 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | status_vec: heapless::Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:257:34 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | last_queued_message: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:258:38 [INFO] [stdout] | [INFO] [stdout] 245 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | last_status_vec_message: DataPack::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_data.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 47 | response: DataPack, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(RdmResponseData { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | destination_uid: PackageAddress::Device(self.source_uid), [INFO] [stdout] 52 | | source_uid: match self.destination_uid { [INFO] [stdout] 53 | | PackageAddress::Device(uid) => uid, [INFO] [stdout] ... | [INFO] [stdout] 62 | | parameter_data: response, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_packages.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | response_info: RdmResponseInfo, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | ) -> Result { [INFO] [stdout] 78 | Ok(match response_info.parameter_id { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | pids::IDENTIFY_DEVICE => { [INFO] [stdout] 80 | | RdmResponsePackage::IdentifyDevice(deserialize_identify(&response_info.data)?) [INFO] [stdout] 81 | | }, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => Self::Custom(response_info), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmx-rdm` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "d79a865a0e2d8f7e59f61afcf060d9746c432b62a3b58f9b6580c4048a691a3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d79a865a0e2d8f7e59f61afcf060d9746c432b62a3b58f9b6580c4048a691a3b", kill_on_drop: false }` [INFO] [stdout] d79a865a0e2d8f7e59f61afcf060d9746c432b62a3b58f9b6580c4048a691a3b