[INFO] fetching crate dlauncher 0.1.1... [INFO] checking dlauncher-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dlauncher 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate dlauncher 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dlauncher 0.1.1 [INFO] finished tweaking crates.io crate dlauncher 0.1.1 [INFO] tweaked toml for crates.io crate dlauncher 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate dlauncher 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b2121655abc31c486cfe217888b6ad14ab19e9dea906b2ebaab12fbb443386a [INFO] running `Command { std: "docker" "start" "-a" "2b2121655abc31c486cfe217888b6ad14ab19e9dea906b2ebaab12fbb443386a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b2121655abc31c486cfe217888b6ad14ab19e9dea906b2ebaab12fbb443386a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b2121655abc31c486cfe217888b6ad14ab19e9dea906b2ebaab12fbb443386a", kill_on_drop: false }` [INFO] [stdout] 2b2121655abc31c486cfe217888b6ad14ab19e9dea906b2ebaab12fbb443386a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39e4fbbccbfb2d8e5431f61d1dea9bb4f189c3267772ef8810d26e21df43f265 [INFO] running `Command { std: "docker" "start" "-a" "39e4fbbccbfb2d8e5431f61d1dea9bb4f189c3267772ef8810d26e21df43f265", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling cfg-expr v0.10.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling gio v0.15.11 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling libdbus-sys v0.2.2 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling gtk v0.15.5 [INFO] [stderr] Compiling serde_json v1.0.80 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking dbus v0.9.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling field-offset v0.3.4 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Checking dbus-crossroads v0.5.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling system-deps v6.0.2 [INFO] [stderr] Compiling thiserror v1.0.30 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling glib-sys v0.15.10 [INFO] [stderr] Compiling gobject-sys v0.15.10 [INFO] [stderr] Compiling gio-sys v0.15.10 [INFO] [stderr] Compiling atk-sys v0.15.1 [INFO] [stderr] Compiling cairo-sys-rs v0.15.1 [INFO] [stderr] Compiling gdk-sys v0.15.1 [INFO] [stderr] Compiling glib-macros v0.15.11 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.15.10 [INFO] [stderr] Compiling pango-sys v0.15.10 [INFO] [stderr] Compiling gtk-sys v0.15.3 [INFO] [stderr] Compiling gtk3-macros v0.15.4 [INFO] [stderr] Checking glib v0.15.11 [INFO] [stderr] Checking dashmap v5.3.3 [INFO] [stderr] Checking pango v0.15.10 [INFO] [stderr] Checking cairo-rs v0.15.11 [INFO] [stderr] Checking atk v0.15.1 [INFO] [stderr] Checking gdk-pixbuf v0.15.11 [INFO] [stderr] Checking gdk v0.15.4 [INFO] [stderr] Checking dlauncher v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: `extern` fn uses type `ExtensionContext`, which is not FFI-safe [INFO] [stdout] --> src/extension/mod.rs:18:32 [INFO] [stdout] | [INFO] [stdout] 18 | pub type ExtensionOutputFunc = unsafe extern "C" fn(ExtensionContext) -> ExtensionExitCode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] note: the type is defined here [INFO] [stdout] --> src/extension/mod.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct ExtensionContext { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/config.rs:104:35 [INFO] [stdout] | [INFO] [stdout] 104 | self.map.get(key).map(|value| value.value().clone().into()) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/config.rs:206:33 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|ext| Extension::new(window.clone(), self.clone(), ext.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/query_history.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn find(&self, query: impl Into) -> Option { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.map.get(&query.into()).map(|t| t.value().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/recent.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn to_result(&self, window: Window, apps: Arc>>) -> Option { [INFO] [stdout] | -------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let apps = apps.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let app = apps.iter().find(|app| app.file == self.file); [INFO] [stdout] 61 | app.map(|app| ResultWidget::new(ResultEntry::App(app.clone()), window, no_match())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/recent.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn to_result(&self, window: Window, apps: Arc>>) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | app.map(|app| ResultWidget::new(ResultEntry::App(app.clone()), window, no_match())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/window.rs:263:40 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|recent| recent.to_result(self.clone(), self.state.apps.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/window.rs:263:54 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|recent| recent.to_result(self.clone(), self.state.apps.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dlauncher` (lib test) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: `extern` fn uses type `ExtensionContext`, which is not FFI-safe [INFO] [stdout] --> src/extension/mod.rs:18:32 [INFO] [stdout] | [INFO] [stdout] 18 | pub type ExtensionOutputFunc = unsafe extern "C" fn(ExtensionContext) -> ExtensionExitCode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] note: the type is defined here [INFO] [stdout] --> src/extension/mod.rs:46:1 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct ExtensionContext { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/config.rs:104:35 [INFO] [stdout] | [INFO] [stdout] 104 | self.map.get(key).map(|value| value.value().clone().into()) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/config.rs:206:33 [INFO] [stdout] | [INFO] [stdout] 206 | .map(|ext| Extension::new(window.clone(), self.clone(), ext.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/query_history.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn find(&self, query: impl Into) -> Option { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.map.get(&query.into()).map(|t| t.value().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/recent.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn to_result(&self, window: Window, apps: Arc>>) -> Option { [INFO] [stdout] | -------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let apps = apps.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let app = apps.iter().find(|app| app.file == self.file); [INFO] [stdout] 61 | app.map(|app| ResultWidget::new(ResultEntry::App(app.clone()), window, no_match())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/util/recent.rs:61:37 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn to_result(&self, window: Window, apps: Arc>>) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | app.map(|app| ResultWidget::new(ResultEntry::App(app.clone()), window, no_match())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/window.rs:263:40 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|recent| recent.to_result(self.clone(), self.state.apps.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/launcher/window.rs:263:54 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|recent| recent.to_result(self.clone(), self.state.apps.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dlauncher` (lib) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "39e4fbbccbfb2d8e5431f61d1dea9bb4f189c3267772ef8810d26e21df43f265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39e4fbbccbfb2d8e5431f61d1dea9bb4f189c3267772ef8810d26e21df43f265", kill_on_drop: false }` [INFO] [stdout] 39e4fbbccbfb2d8e5431f61d1dea9bb4f189c3267772ef8810d26e21df43f265