[INFO] fetching crate djotters 0.1.13... [INFO] checking djotters-0.1.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate djotters 0.1.13 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate djotters 0.1.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate djotters 0.1.13 [INFO] finished tweaking crates.io crate djotters 0.1.13 [INFO] tweaked toml for crates.io crate djotters 0.1.13 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f66859c4ac3e7db162334aacfbdb6d75b0f2a9256d4efb0d033f06bc9411898 [INFO] running `Command { std: "docker" "start" "-a" "5f66859c4ac3e7db162334aacfbdb6d75b0f2a9256d4efb0d033f06bc9411898", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f66859c4ac3e7db162334aacfbdb6d75b0f2a9256d4efb0d033f06bc9411898", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f66859c4ac3e7db162334aacfbdb6d75b0f2a9256d4efb0d033f06bc9411898", kill_on_drop: false }` [INFO] [stdout] 5f66859c4ac3e7db162334aacfbdb6d75b0f2a9256d4efb0d033f06bc9411898 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cad0dd904176b447c53e8ef0dc3ba2bbbdb96e92341902d19531f2f90bdfa0b [INFO] running `Command { std: "docker" "start" "-a" "2cad0dd904176b447c53e8ef0dc3ba2bbbdb96e92341902d19531f2f90bdfa0b", kill_on_drop: false }` [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking unidecode v0.3.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking slugify v0.1.0 [INFO] [stderr] Checking djotters v0.1.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `cut` and `newline` [INFO] [stdout] --> src/parser.rs:11:82 [INFO] [stdout] | [INFO] [stdout] 11 | alphanumeric1, anychar, char, line_ending, multispace0, multispace1, newline, space0, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | combinator::{cut, eof, map, map_res, opt, peek, recognize, rest, verify}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::markdown` [INFO] [stdout] --> src/tests/attention.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::super::markdown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::parser` [INFO] [stdout] --> src/tests/attention.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use super::super::parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pretty_assertions::assert_eq` [INFO] [stdout] --> src/tests/attention.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use pretty_assertions::assert_eq; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InputTakeAtPosition`, `cut`, `error::ParseError`, and `newline` [INFO] [stdout] --> src/parser.rs:11:82 [INFO] [stdout] | [INFO] [stdout] 11 | alphanumeric1, anychar, char, line_ending, multispace0, multispace1, newline, space0, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | combinator::{cut, eof, map, map_res, opt, peek, recognize, rest, verify}, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | error::ParseError, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | AsChar, IResult, InputTakeAtPosition, Parser, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::super::parser` [INFO] [stdout] --> src/tests/attention.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use super::super::parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matched` [INFO] [stdout] --> src/parser.rs:467:21 [INFO] [stdout] | [INFO] [stdout] 467 | let (input, matched) = opt(pair(char('|'), opt(peek(char('\n')))))(input)?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matched` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matched` [INFO] [stdout] --> src/parser.rs:467:21 [INFO] [stdout] | [INFO] [stdout] 467 | let (input, matched) = opt(pair(char('|'), opt(peek(char('\n')))))(input)?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matched` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsChar` [INFO] [stdout] --> src/parser.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | AsChar, IResult, InputTakeAtPosition, Parser, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error::ParseError` [INFO] [stdout] --> src/parser.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | error::ParseError, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `InputTakeAtPosition` [INFO] [stdout] --> src/parser.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | AsChar, IResult, InputTakeAtPosition, Parser, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 95 | let not_surrounder = take_while1(move |c| c != '\n' && c != closer.chars().next().unwrap()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let no_end_space = move |input: &'a str| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | / delimited( [INFO] [stdout] 114 | | tag(opener), // Match opening surrounder and ensure no space after it [INFO] [stdout] 115 | | no_end_space, // Match text that is not the surrounder [INFO] [stdout] 116 | | tag(closer), // Ensure no space before closing surrounder and match it [INFO] [stdout] 117 | | )(i) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 140 | let parse_value = delimited(tag("\""), take_while(|c| c != '"'), tag("\"")); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | separated_pair(parse_key, tag("="), parse_value)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn take_before0<'a, FOutput, F>(f: F) -> impl FnMut(&'a str) -> IResult<&'a str, &'a str> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | recognize(many_till(anychar, peek(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:328:20 [INFO] [stdout] | [INFO] [stdout] 328 | move |i: &str| many1(parse_markdown_inline(accept_linebreak))(i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 459 | fn parse_row<'a, O, F>(cell_parser: F) -> impl Fn(&'a str) -> IResult<&'a str, Vec> + 'a [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | let (input, cells) = separated_list1(char('|'), &cell_parser)(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | let (input, matched) = opt(pair(char('|'), opt(peek(char('\n')))))(input)?; [INFO] [stdout] 468 | Ok((input, cells)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `djotters` (lib) due to 6 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `AsChar` [INFO] [stdout] --> src/parser.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | AsChar, IResult, InputTakeAtPosition, Parser, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 95 | let not_surrounder = take_while1(move |c| c != '\n' && c != closer.chars().next().unwrap()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let no_end_space = move |input: &'a str| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | / delimited( [INFO] [stdout] 114 | | tag(opener), // Match opening surrounder and ensure no space after it [INFO] [stdout] 115 | | no_end_space, // Match text that is not the surrounder [INFO] [stdout] 116 | | tag(closer), // Ensure no space before closing surrounder and match it [INFO] [stdout] 117 | | )(i) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 140 | let parse_value = delimited(tag("\""), take_while(|c| c != '"'), tag("\"")); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | separated_pair(parse_key, tag("="), parse_value)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:216:15 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn take_before0<'a, FOutput, F>(f: F) -> impl FnMut(&'a str) -> IResult<&'a str, &'a str> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | recognize(many_till(anychar, peek(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:328:20 [INFO] [stdout] | [INFO] [stdout] 328 | move |i: &str| many1(parse_markdown_inline(accept_linebreak))(i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 459 | fn parse_row<'a, O, F>(cell_parser: F) -> impl Fn(&'a str) -> IResult<&'a str, Vec> + 'a [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 466 | let (input, cells) = separated_list1(char('|'), &cell_parser)(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | let (input, matched) = opt(pair(char('|'), opt(peek(char('\n')))))(input)?; [INFO] [stdout] 468 | Ok((input, cells)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `djotters` (lib test) due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2cad0dd904176b447c53e8ef0dc3ba2bbbdb96e92341902d19531f2f90bdfa0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cad0dd904176b447c53e8ef0dc3ba2bbbdb96e92341902d19531f2f90bdfa0b", kill_on_drop: false }` [INFO] [stdout] 2cad0dd904176b447c53e8ef0dc3ba2bbbdb96e92341902d19531f2f90bdfa0b