[INFO] fetching crate distill-loader 0.0.3... [INFO] checking distill-loader-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate distill-loader 0.0.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate distill-loader 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate distill-loader 0.0.3 [INFO] finished tweaking crates.io crate distill-loader 0.0.3 [INFO] tweaked toml for crates.io crate distill-loader 0.0.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding capnp v0.14.11 (latest: v0.19.6) [INFO] [stderr] Adding capnp-futures v0.14.3 (latest: v0.19.0) [INFO] [stderr] Adding capnp-rpc v0.14.1 (latest: v0.19.2) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding path-clean v0.1.0 (latest: v1.0.1) [INFO] [stderr] Adding path-slash v0.1.5 (latest: v0.2.1) [INFO] [stderr] Adding tokio-util v0.6.10 (latest: v0.7.11) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c39a5efdf852e24c2c24981ee7bd4eccfd7c49cbda43bb28aa0db9726aa85187 [INFO] running `Command { std: "docker" "start" "-a" "c39a5efdf852e24c2c24981ee7bd4eccfd7c49cbda43bb28aa0db9726aa85187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c39a5efdf852e24c2c24981ee7bd4eccfd7c49cbda43bb28aa0db9726aa85187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c39a5efdf852e24c2c24981ee7bd4eccfd7c49cbda43bb28aa0db9726aa85187", kill_on_drop: false }` [INFO] [stdout] c39a5efdf852e24c2c24981ee7bd4eccfd7c49cbda43bb28aa0db9726aa85187 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c54cd79012e889b5b01758736f4042f7041ce4978dfbd1196c290102c694d5b [INFO] running `Command { std: "docker" "start" "-a" "5c54cd79012e889b5b01758736f4042f7041ce4978dfbd1196c290102c694d5b", kill_on_drop: false }` [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking capnp v0.14.11 [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking path-slash v0.1.5 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking distill-core v0.0.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking capnp-futures v0.14.3 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking distill-schema v0.0.3 [INFO] [stderr] Checking capnp-rpc v0.14.1 [INFO] [stderr] Checking distill-loader v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/handle.rs:546:13 [INFO] [stdout] | [INFO] [stdout] 546 | Err(err) => Err(E::custom(format!( [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/handle.rs:546:13 [INFO] [stdout] | [INFO] [stdout] 546 | Err(err) => Err(E::custom(format!( [INFO] [stdout] | ^^^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | Self { [INFO] [stdout] 167 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 168 | | id: handle, [INFO] [stdout] 169 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 170 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 176 | pub(crate) fn new_internal(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Self { [INFO] [stdout] 178 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 179 | | id: handle, [INFO] [stdout] 180 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 181 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:209:25 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn new(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Self { [INFO] [stdout] 209 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 210 | | id: handle, [INFO] [stdout] 211 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 212 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 217 | pub(crate) fn new_internal(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Self { [INFO] [stdout] 219 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 220 | | id: handle, [INFO] [stdout] 221 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 222 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, &r))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:276:43 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, &r))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:322:22 [INFO] [stdout] | [INFO] [stdout] 316 | let (tx, _) = unbounded(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | current: Mutex::new(DummySerdeContextCurrent { [INFO] [stdout] | ______________________^ [INFO] [stdout] 323 | | current_serde_dependencies: HashSet::new(), [INFO] [stdout] 324 | | current_serde_asset: None, [INFO] [stdout] 325 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:377:18 [INFO] [stdout] | [INFO] [stdout] 374 | fn scope<'s>(&'s self, fut: BoxFuture<'s, ()>) -> BoxFuture<'s, ()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let sender = self.dummy.ref_sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | let loader = &*self.dummy; [INFO] [stdout] 377 | Box::pin(SerdeContext::with(loader, sender, fut)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:406:68 [INFO] [stdout] | [INFO] [stdout] 401 | let mut current = self.dummy.current.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | std::mem::replace(&mut current.current_serde_dependencies, HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 414 | let dummy = Arc::new(DummySerdeContext::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | Box::new(DummySerdeContextHandle { dummy }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:423:31 [INFO] [stdout] | [INFO] [stdout] 419 | fn serialize_handle(load: LoadHandle, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | SerdeContext::with_active(|loader, _| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 424 | | use ser::SerializeSeq; [INFO] [stdout] 425 | | let uuid: AssetUuid = loader.get_asset_id(load).unwrap_or_default(); [INFO] [stdout] 426 | | let mut seq = serializer.serialize_seq(Some(uuid.0.len()))?; [INFO] [stdout] ... | [INFO] [stdout] 430 | | seq.end() [INFO] [stdout] 431 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 464 | fn deserialize(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 473 | let (handle, sender) = get_handle_ref(asset_ref); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | Ok(Handle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 479 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let (handle, sender) = get_handle_ref(asset_ref); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | Ok(GenericHandle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:981:45 [INFO] [stdout] | [INFO] [stdout] 980 | pub fn new(io: Box) -> Loader { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 981 | Self::new_with_handle_allocator(io, Arc::new(AtomicHandleAllocator::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:996:19 [INFO] [stdout] | [INFO] [stdout] 985 | io: Box, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 986 | handle_allocator: Arc, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 987 | ) -> Loader { [INFO] [stdout] 988 | let (op_tx, op_rx) = unbounded(); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 989 | let (invalidate_tx, invalidate_rx) = unbounded(); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 990 | #[cfg(feature = "invalidate_path")] [INFO] [stdout] 991 | let (invalidate_path_tx, invalidate_path_rx) = unbounded(); [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 992 | let (metadata_tx, metadata_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 993 | let (data_tx, data_rx) = unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 994 | let (resolve_tx, resolve_rx) = unbounded(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 995 | Loader { [INFO] [stdout] 996 | data: LoaderState { [INFO] [stdout] | ___________________^ [INFO] [stdout] 997 | | handle_allocator, [INFO] [stdout] 998 | | load_states: DashMap::default(), [INFO] [stdout] 999 | | uuid_to_load: DashMap::default(), [INFO] [stdout] ... | [INFO] [stdout] 1019 | | }, [INFO] [stdout] 1020 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile_io.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(file: File) -> std::io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mmap = unsafe { MmapOptions::new().map(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(PackfileMessageReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | file: ManuallyDrop::new(file), [INFO] [stdout] 29 | | mmap: ManuallyDrop::new(mmap), [INFO] [stdout] 30 | | message_reader: ManuallyDrop::new(ThreadLocal::new()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile_io.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(file: File) -> capnp::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let message_reader = PackfileMessageReader::new(file)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(PackfileReader(Arc::new(PackfileReaderInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | reader: message_reader, [INFO] [stdout] 83 | | index_by_uuid, [INFO] [stdout] 84 | | assets_by_path, [INFO] [stdout] 85 | | runtime: tokio::runtime::Builder::new_multi_thread().build()?, [INFO] [stdout] 86 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:346:69 [INFO] [stdout] | [INFO] [stdout] 343 | for asset in requests.data_requests.drain(0..len) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | runtime.local.spawn_local(async move { [INFO] [stdout] 346 | match do_import_artifact_request(&asset, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:361:58 [INFO] [stdout] | [INFO] [stdout] 358 | for m in requests.metadata_requests.drain(0..len) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | runtime.local.spawn_local(async move { [INFO] [stdout] 361 | match do_metadata_request(&m, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:376:57 [INFO] [stdout] | [INFO] [stdout] 373 | for m in requests.resolve_requests.drain(0..len) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | runtime.local.spawn_local(async move { [INFO] [stdout] 376 | match do_resolve_request(&m, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 400 | let snapshot = pry!(params.get_snapshot()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | let channel = self.snapshot_channel.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let mut request = snapshot.get_asset_changes_request(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | let response = request.send().promise.await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | / channel [INFO] [stdout] 448 | | .send(SnapshotChange { [INFO] [stdout] 449 | | snapshot, [INFO] [stdout] 450 | | changed_assets, [INFO] [stdout] ... | [INFO] [stdout] 453 | | changed_paths, [INFO] [stdout] 454 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn new(sender: Sender, handle: LoadHandle, version: u32) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self { [INFO] [stdout] 53 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `distill-loader` (lib test) due to 23 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:167:25 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | Self { [INFO] [stdout] 167 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 168 | | id: handle, [INFO] [stdout] 169 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 170 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:178:25 [INFO] [stdout] | [INFO] [stdout] 176 | pub(crate) fn new_internal(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Self { [INFO] [stdout] 178 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 179 | | id: handle, [INFO] [stdout] 180 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 181 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:209:25 [INFO] [stdout] | [INFO] [stdout] 207 | pub fn new(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Self { [INFO] [stdout] 209 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 210 | | id: handle, [INFO] [stdout] 211 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 212 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 217 | pub(crate) fn new_internal(chan: Sender, handle: LoadHandle) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Self { [INFO] [stdout] 219 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 220 | | id: handle, [INFO] [stdout] 221 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 222 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, &r))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:276:43 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, &r))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:322:22 [INFO] [stdout] | [INFO] [stdout] 316 | let (tx, _) = unbounded(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 322 | current: Mutex::new(DummySerdeContextCurrent { [INFO] [stdout] | ______________________^ [INFO] [stdout] 323 | | current_serde_dependencies: HashSet::new(), [INFO] [stdout] 324 | | current_serde_asset: None, [INFO] [stdout] 325 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:377:18 [INFO] [stdout] | [INFO] [stdout] 374 | fn scope<'s>(&'s self, fut: BoxFuture<'s, ()>) -> BoxFuture<'s, ()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let sender = self.dummy.ref_sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | let loader = &*self.dummy; [INFO] [stdout] 377 | Box::pin(SerdeContext::with(loader, sender, fut)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:406:68 [INFO] [stdout] | [INFO] [stdout] 401 | let mut current = self.dummy.current.lock().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | std::mem::replace(&mut current.current_serde_dependencies, HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:415:18 [INFO] [stdout] | [INFO] [stdout] 414 | let dummy = Arc::new(DummySerdeContext::new()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | Box::new(DummySerdeContextHandle { dummy }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:423:31 [INFO] [stdout] | [INFO] [stdout] 419 | fn serialize_handle(load: LoadHandle, serializer: S) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | SerdeContext::with_active(|loader, _| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 424 | | use ser::SerializeSeq; [INFO] [stdout] 425 | | let uuid: AssetUuid = loader.get_asset_id(load).unwrap_or_default(); [INFO] [stdout] 426 | | let mut seq = serializer.serialize_seq(Some(uuid.0.len()))?; [INFO] [stdout] ... | [INFO] [stdout] 430 | | seq.end() [INFO] [stdout] 431 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 464 | fn deserialize(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 473 | let (handle, sender) = get_handle_ref(asset_ref); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | Ok(Handle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 479 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let (handle, sender) = get_handle_ref(asset_ref); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | Ok(GenericHandle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:981:45 [INFO] [stdout] | [INFO] [stdout] 980 | pub fn new(io: Box) -> Loader { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 981 | Self::new_with_handle_allocator(io, Arc::new(AtomicHandleAllocator::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:996:19 [INFO] [stdout] | [INFO] [stdout] 985 | io: Box, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 986 | handle_allocator: Arc, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 987 | ) -> Loader { [INFO] [stdout] 988 | let (op_tx, op_rx) = unbounded(); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 989 | let (invalidate_tx, invalidate_rx) = unbounded(); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 990 | #[cfg(feature = "invalidate_path")] [INFO] [stdout] 991 | let (invalidate_path_tx, invalidate_path_rx) = unbounded(); [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 992 | let (metadata_tx, metadata_rx) = unbounded(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 993 | let (data_tx, data_rx) = unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 994 | let (resolve_tx, resolve_rx) = unbounded(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 995 | Loader { [INFO] [stdout] 996 | data: LoaderState { [INFO] [stdout] | ___________________^ [INFO] [stdout] 997 | | handle_allocator, [INFO] [stdout] 998 | | load_states: DashMap::default(), [INFO] [stdout] 999 | | uuid_to_load: DashMap::default(), [INFO] [stdout] ... | [INFO] [stdout] 1019 | | }, [INFO] [stdout] 1020 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile_io.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(file: File) -> std::io::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mmap = unsafe { MmapOptions::new().map(&file)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(PackfileMessageReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | file: ManuallyDrop::new(file), [INFO] [stdout] 29 | | mmap: ManuallyDrop::new(mmap), [INFO] [stdout] 30 | | message_reader: ManuallyDrop::new(ThreadLocal::new()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packfile_io.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(file: File) -> capnp::Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let message_reader = PackfileMessageReader::new(file)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(PackfileReader(Arc::new(PackfileReaderInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | reader: message_reader, [INFO] [stdout] 83 | | index_by_uuid, [INFO] [stdout] 84 | | assets_by_path, [INFO] [stdout] 85 | | runtime: tokio::runtime::Builder::new_multi_thread().build()?, [INFO] [stdout] 86 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:346:69 [INFO] [stdout] | [INFO] [stdout] 343 | for asset in requests.data_requests.drain(0..len) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | runtime.local.spawn_local(async move { [INFO] [stdout] 346 | match do_import_artifact_request(&asset, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:361:58 [INFO] [stdout] | [INFO] [stdout] 358 | for m in requests.metadata_requests.drain(0..len) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | runtime.local.spawn_local(async move { [INFO] [stdout] 361 | match do_metadata_request(&m, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:376:57 [INFO] [stdout] | [INFO] [stdout] 373 | for m in requests.resolve_requests.drain(0..len) { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | let snapshot = connection.snapshot.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | runtime.local.spawn_local(async move { [INFO] [stdout] 376 | match do_resolve_request(&m, &snapshot).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc_io.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 400 | let snapshot = pry!(params.get_snapshot()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | let channel = self.snapshot_channel.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | let mut request = snapshot.get_asset_changes_request(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | let response = request.send().promise.await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | / channel [INFO] [stdout] 448 | | .send(SnapshotChange { [INFO] [stdout] 449 | | snapshot, [INFO] [stdout] 450 | | changed_assets, [INFO] [stdout] ... | [INFO] [stdout] 453 | | changed_paths, [INFO] [stdout] 454 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 51 | pub(crate) fn new(sender: Sender, handle: LoadHandle, version: u32) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self { [INFO] [stdout] 53 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `distill-loader` (lib) due to 23 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "5c54cd79012e889b5b01758736f4042f7041ce4978dfbd1196c290102c694d5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c54cd79012e889b5b01758736f4042f7041ce4978dfbd1196c290102c694d5b", kill_on_drop: false }` [INFO] [stdout] 5c54cd79012e889b5b01758736f4042f7041ce4978dfbd1196c290102c694d5b