[INFO] fetching crate distill-importer 0.0.3... [INFO] checking distill-importer-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate distill-importer 0.0.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate distill-importer 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate distill-importer 0.0.3 [INFO] finished tweaking crates.io crate distill-importer 0.0.3 [INFO] tweaked toml for crates.io crate distill-importer 0.0.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding erased-serde v0.3.31 (latest: v0.4.5) [INFO] [stderr] Adding inventory v0.2.3 (latest: v0.3.15) [INFO] [stderr] Adding ron v0.6.6 (latest: v0.8.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding typetag v0.1.8 (latest: v0.2.18) [INFO] [stderr] Adding typetag-impl v0.1.8 (latest: v0.2.18) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 842dc5dc5568b6c82a094fe8089bc96bcb2324618c4493ad568809544e4599c8 [INFO] running `Command { std: "docker" "start" "-a" "842dc5dc5568b6c82a094fe8089bc96bcb2324618c4493ad568809544e4599c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "842dc5dc5568b6c82a094fe8089bc96bcb2324618c4493ad568809544e4599c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "842dc5dc5568b6c82a094fe8089bc96bcb2324618c4493ad568809544e4599c8", kill_on_drop: false }` [INFO] [stdout] 842dc5dc5568b6c82a094fe8089bc96bcb2324618c4493ad568809544e4599c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45cf5d7a9b8349ffc1498448ac00c622e4249a1467c97fe6c5499d7831d3dde8 [INFO] running `Command { std: "docker" "start" "-a" "45cf5d7a9b8349ffc1498448ac00c622e4249a1467c97fe6c5499d7831d3dde8", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking distill-core v0.0.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking distill-importer v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:88:18 [INFO] [stdout] | [INFO] [stdout] 84 | options: Box, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | mut state: Box, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 89 | | let s = state.any_mut().downcast_mut::(); [INFO] [stdout] 90 | | let s = if let Some(s) = s { [INFO] [stdout] 91 | | s [INFO] [stdout] ... | [INFO] [stdout] 109 | | }) [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:88:18 [INFO] [stdout] | [INFO] [stdout] 84 | options: Box, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | mut state: Box, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 89 | | let s = state.any_mut().downcast_mut::(); [INFO] [stdout] 90 | | let s = if let Some(s) = s { [INFO] [stdout] 91 | | s [INFO] [stdout] ... | [INFO] [stdout] 109 | | }) [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 84 | options: Box, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | mut state: Box, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let result = self.import(op, source, o, s).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | log::trace!("import_boxed imported"); [INFO] [stdout] 105 | Ok(BoxedImporterValue { [INFO] [stdout] | ________________^ [INFO] [stdout] 106 | | value: result, [INFO] [stdout] 107 | | options, [INFO] [stdout] 108 | | state, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 84 | options: Box, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | mut state: Box, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let result = self.import(op, source, o, s).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | log::trace!("import_boxed imported"); [INFO] [stdout] 105 | Ok(BoxedImporterValue { [INFO] [stdout] | ________________^ [INFO] [stdout] 106 | | value: result, [INFO] [stdout] 107 | | options, [INFO] [stdout] 108 | | state, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 116 | options: Box, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut state: Box, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 121 | | let s = state.any_mut().downcast_mut::(); [INFO] [stdout] 122 | | let s = if let Some(s) = s { [INFO] [stdout] 123 | | s [INFO] [stdout] ... | [INFO] [stdout] 139 | | }) [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 116 | options: Box, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut state: Box, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 121 | | let s = state.any_mut().downcast_mut::(); [INFO] [stdout] 122 | | let s = if let Some(s) = s { [INFO] [stdout] 123 | | s [INFO] [stdout] ... | [INFO] [stdout] 139 | | }) [INFO] [stdout] 140 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 116 | options: Box, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut state: Box, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let result = self.export(output, o, s, assets).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(BoxedExportInputs { [INFO] [stdout] | ________________^ [INFO] [stdout] 136 | | options, [INFO] [stdout] 137 | | state, [INFO] [stdout] 138 | | value: result, [INFO] [stdout] 139 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 116 | options: Box, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | mut state: Box, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let result = self.export(output, o, s, assets).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(BoxedExportInputs { [INFO] [stdout] | ________________^ [INFO] [stdout] 136 | | options, [INFO] [stdout] 137 | | state, [INFO] [stdout] 138 | | value: result, [INFO] [stdout] 139 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 159 | let metadata = erased_serde::deserialize::>(deserializer)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Ok(SourceMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | version: metadata.version, [INFO] [stdout] 162 | | importer_options: Box::new(metadata.importer_options), [INFO] [stdout] 163 | | importer_state: Box::new(metadata.importer_state), [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxed_importer.rs:160:12 [INFO] [stdout] | [INFO] [stdout] 159 | let metadata = erased_serde::deserialize::>(deserializer)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Ok(SourceMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 161 | | version: metadata.version, [INFO] [stdout] 162 | | importer_options: Box::new(metadata.importer_options), [INFO] [stdout] 163 | | importer_state: Box::new(metadata.importer_state), [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `distill-importer` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `distill-importer` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "45cf5d7a9b8349ffc1498448ac00c622e4249a1467c97fe6c5499d7831d3dde8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45cf5d7a9b8349ffc1498448ac00c622e4249a1467c97fe6c5499d7831d3dde8", kill_on_drop: false }` [INFO] [stdout] 45cf5d7a9b8349ffc1498448ac00c622e4249a1467c97fe6c5499d7831d3dde8