[INFO] fetching crate disc_riider 0.2.1... [INFO] checking disc_riider-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate disc_riider 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate disc_riider 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate disc_riider 0.2.1 [INFO] finished tweaking crates.io crate disc_riider 0.2.1 [INFO] tweaked toml for crates.io crate disc_riider 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 30 packages to latest compatible versions [INFO] [stderr] Adding binrw v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding binrw_derive v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 150237ec249b67ad16602b204c4ebd27e29370c0286bed62d0d5362716ef0ec6 [INFO] running `Command { std: "docker" "start" "-a" "150237ec249b67ad16602b204c4ebd27e29370c0286bed62d0d5362716ef0ec6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "150237ec249b67ad16602b204c4ebd27e29370c0286bed62d0d5362716ef0ec6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "150237ec249b67ad16602b204c4ebd27e29370c0286bed62d0d5362716ef0ec6", kill_on_drop: false }` [INFO] [stdout] 150237ec249b67ad16602b204c4ebd27e29370c0286bed62d0d5362716ef0ec6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6bc39c2d89eaaba44763a58521b900cb821aaaee1bdaea4bf1189fe889024880 [INFO] running `Command { std: "docker" "start" "-a" "6bc39c2d89eaaba44763a58521b900cb821aaaee1bdaea4bf1189fe889024880", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking disc_riider v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `Readonly` is never constructed [INFO] [stdout] --> src/reader_writer.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | enum OpenMode { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 17 | Readonly { max_group: u64 }, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `can_write` is never used [INFO] [stdout] --> src/reader_writer.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl OpenMode { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 24 | fn can_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `with_file` is never used [INFO] [stdout] --> src/reader_writer.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ------------------------------------- method in this implementation [INFO] [stdout] 60 | pub fn with_file<'a, RS: Read + Seek>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `VerificationError` is never used [INFO] [stdout] --> src/reader_writer.rs:131:6 [INFO] [stdout] | [INFO] [stdout] 131 | enum VerificationError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `decrypt_verify_group` is never used [INFO] [stdout] --> src/reader_writer.rs:142:4 [INFO] [stdout] | [INFO] [stdout] 142 | fn decrypt_verify_group( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `create_readonly` is never used [INFO] [stdout] --> src/reader_writer.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 209 | impl<'a, RS: Read + Seek> WiiEncryptedReadWriteStream<'a, RS> { [INFO] [stdout] | ------------------------------------------------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 214 | pub fn create_readonly( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader_writer.rs:227:20 [INFO] [stdout] | [INFO] [stdout] 221 | let group_cache = vec![0; GROUP_SIZE as usize] [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | inner: WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 228 | | h3: None, [INFO] [stdout] 229 | | data_offset, [INFO] [stdout] 230 | | encryption_key, [INFO] [stdout] ... | [INFO] [stdout] 237 | | filled_groups: 0, [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader_writer.rs:330:20 [INFO] [stdout] | [INFO] [stdout] 324 | let group_cache = vec![0; GROUP_SIZE as usize] [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | inner: WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 331 | | h3: Some(vec![0; 0x18000].into_boxed_slice().try_into().unwrap()), [INFO] [stdout] 332 | | data_offset, [INFO] [stdout] 333 | | encryption_key, [INFO] [stdout] ... | [INFO] [stdout] 339 | | filled_groups, [INFO] [stdout] 340 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/new_reader.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn open(mut rs: RS) -> binrw::BinResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(WiiIsoReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | file: rs, [INFO] [stdout] 375 | | header, [INFO] [stdout] 376 | | region, [INFO] [stdout] 377 | | partitions, [INFO] [stdout] 378 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/new_reader.rs:419:12 [INFO] [stdout] | [INFO] [stdout] 402 | let mut encrypt_part_state = EncryptedPartState { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | Ok(WiiPartitionReadInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 420 | | partition_entry: partition, [INFO] [stdout] 421 | | wii_partition_header, [INFO] [stdout] 422 | | encrypted_header, [INFO] [stdout] 423 | | encrypt_part_state, [INFO] [stdout] 424 | | fst, [INFO] [stdout] 425 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Readonly` is never constructed [INFO] [stdout] --> src/reader_writer.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 16 | enum OpenMode { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 17 | Readonly { max_group: u64 }, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `can_write` is never used [INFO] [stdout] --> src/reader_writer.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl OpenMode { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 24 | fn can_write(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `with_file` is never used [INFO] [stdout] --> src/reader_writer.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | impl WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ------------------------------------- method in this implementation [INFO] [stdout] 60 | pub fn with_file<'a, RS: Read + Seek>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `VerificationError` is never used [INFO] [stdout] --> src/reader_writer.rs:131:6 [INFO] [stdout] | [INFO] [stdout] 131 | enum VerificationError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `decrypt_verify_group` is never used [INFO] [stdout] --> src/reader_writer.rs:142:4 [INFO] [stdout] | [INFO] [stdout] 142 | fn decrypt_verify_group( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `create_readonly` and `read_into_vec` are never used [INFO] [stdout] --> src/reader_writer.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 209 | impl<'a, RS: Read + Seek> WiiEncryptedReadWriteStream<'a, RS> { [INFO] [stdout] | ------------------------------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 214 | pub fn create_readonly( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 278 | pub fn read_into_vec( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader_writer.rs:227:20 [INFO] [stdout] | [INFO] [stdout] 221 | let group_cache = vec![0; GROUP_SIZE as usize] [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | inner: WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 228 | | h3: None, [INFO] [stdout] 229 | | data_offset, [INFO] [stdout] 230 | | encryption_key, [INFO] [stdout] ... | [INFO] [stdout] 237 | | filled_groups: 0, [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader_writer.rs:330:20 [INFO] [stdout] | [INFO] [stdout] 324 | let group_cache = vec![0; GROUP_SIZE as usize] [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | inner: WiiEncryptedReadWriteStreamInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 331 | | h3: Some(vec![0; 0x18000].into_boxed_slice().try_into().unwrap()), [INFO] [stdout] 332 | | data_offset, [INFO] [stdout] 333 | | encryption_key, [INFO] [stdout] ... | [INFO] [stdout] 339 | | filled_groups, [INFO] [stdout] 340 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/new_reader.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn open(mut rs: RS) -> binrw::BinResult { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(WiiIsoReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | file: rs, [INFO] [stdout] 375 | | header, [INFO] [stdout] 376 | | region, [INFO] [stdout] 377 | | partitions, [INFO] [stdout] 378 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/new_reader.rs:419:12 [INFO] [stdout] | [INFO] [stdout] 402 | let mut encrypt_part_state = EncryptedPartState { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | Ok(WiiPartitionReadInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 420 | | partition_entry: partition, [INFO] [stdout] 421 | | wii_partition_header, [INFO] [stdout] 422 | | encrypted_header, [INFO] [stdout] 423 | | encrypt_part_state, [INFO] [stdout] 424 | | fst, [INFO] [stdout] 425 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `disc_riider` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `disc_riider` (lib) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6bc39c2d89eaaba44763a58521b900cb821aaaee1bdaea4bf1189fe889024880", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bc39c2d89eaaba44763a58521b900cb821aaaee1bdaea4bf1189fe889024880", kill_on_drop: false }` [INFO] [stdout] 6bc39c2d89eaaba44763a58521b900cb821aaaee1bdaea4bf1189fe889024880