[INFO] fetching crate diridp 0.1.1... [INFO] checking diridp-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diridp 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate diridp 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diridp 0.1.1 [INFO] finished tweaking crates.io crate diridp 0.1.1 [INFO] tweaked toml for crates.io crate diridp 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate diridp 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69ae6efec80c8bd0e6c375805e7600fd95d5e90ad29e0a8d65b6fc2e9aa7bd66 [INFO] running `Command { std: "docker" "start" "-a" "69ae6efec80c8bd0e6c375805e7600fd95d5e90ad29e0a8d65b6fc2e9aa7bd66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69ae6efec80c8bd0e6c375805e7600fd95d5e90ad29e0a8d65b6fc2e9aa7bd66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69ae6efec80c8bd0e6c375805e7600fd95d5e90ad29e0a8d65b6fc2e9aa7bd66", kill_on_drop: false }` [INFO] [stdout] 69ae6efec80c8bd0e6c375805e7600fd95d5e90ad29e0a8d65b6fc2e9aa7bd66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d1fa7581d498f6f0a1cdec22c80853a8d63560080df4e967d5ed47cb7fd9efa [INFO] running `Command { std: "docker" "start" "-a" "7d1fa7581d498f6f0a1cdec22c80853a8d63560080df4e967d5ed47cb7fd9efa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling libm v0.2.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking base64ct v1.5.0 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking const-oid v0.7.1 [INFO] [stderr] Checking pem-rfc7468 v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking zeroize v1.5.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling num-bigint-dig v0.8.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking filetime v0.2.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking crypto-bigint v0.3.2 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking notify v5.0.0-pre.15 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking der v0.5.1 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking spki v0.5.4 [INFO] [stderr] Checking pkcs8 v0.8.0 [INFO] [stderr] Checking pkcs1 v0.3.3 [INFO] [stderr] Checking rsa v0.6.1 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking diridp v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `oidc_config_path` and `jwks_uri` are never read [INFO] [stdout] --> src/state.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Provider { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | pub oidc_config_path: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | pub jwks_path: PathBuf, [INFO] [stdout] 26 | pub jwks_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 69 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut watcher = (!args.once) [INFO] [stdout] 71 | .then(|| notify::recommended_watcher(tx).context("Failed to create watcher")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:307:22 [INFO] [stdout] | [INFO] [stdout] 307 | .map(|entry| load_key_pair(&keys_dir, entry).map(Arc::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:8 [INFO] [stdout] | [INFO] [stdout] 385 | let key_pair = RsaPrivateKey::read_pkcs8_pem_file(&path) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | Ok(state::KeyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 389 | | id: entry.id, [INFO] [stdout] 390 | | path, [INFO] [stdout] 391 | | inner: key_pair, [INFO] [stdout] 392 | | expires: UNIX_EPOCH + Duration::from_secs(entry.expires), [INFO] [stdout] 393 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/update_keys.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 153 | let inner = RsaPrivateKey::new(&mut rng, 2048).context("Failed to generate RSA key pair")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(state::KeyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 167 | | id, [INFO] [stdout] 168 | | path, [INFO] [stdout] 169 | | inner, [INFO] [stdout] 170 | | expires, [INFO] [stdout] 171 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | fs::rename(&tmp_path, &path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diridp` (bin "diridp") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `oidc_config_path` and `jwks_uri` are never read [INFO] [stdout] --> src/state.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Provider { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 24 | pub oidc_config_path: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 25 | pub jwks_path: PathBuf, [INFO] [stdout] 26 | pub jwks_uri: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 69 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut watcher = (!args.once) [INFO] [stdout] 71 | .then(|| notify::recommended_watcher(tx).context("Failed to create watcher")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:307:22 [INFO] [stdout] | [INFO] [stdout] 307 | .map(|entry| load_key_pair(&keys_dir, entry).map(Arc::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:8 [INFO] [stdout] | [INFO] [stdout] 385 | let key_pair = RsaPrivateKey::read_pkcs8_pem_file(&path) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | Ok(state::KeyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 389 | | id: entry.id, [INFO] [stdout] 390 | | path, [INFO] [stdout] 391 | | inner: key_pair, [INFO] [stdout] 392 | | expires: UNIX_EPOCH + Duration::from_secs(entry.expires), [INFO] [stdout] 393 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/update_keys.rs:166:8 [INFO] [stdout] | [INFO] [stdout] 153 | let inner = RsaPrivateKey::new(&mut rng, 2048).context("Failed to generate RSA key pair")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(state::KeyPair { [INFO] [stdout] | ________^ [INFO] [stdout] 167 | | id, [INFO] [stdout] 168 | | path, [INFO] [stdout] 169 | | inner, [INFO] [stdout] 170 | | expires, [INFO] [stdout] 171 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | fs::rename(&tmp_path, &path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diridp` (bin "diridp" test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7d1fa7581d498f6f0a1cdec22c80853a8d63560080df4e967d5ed47cb7fd9efa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d1fa7581d498f6f0a1cdec22c80853a8d63560080df4e967d5ed47cb7fd9efa", kill_on_drop: false }` [INFO] [stdout] 7d1fa7581d498f6f0a1cdec22c80853a8d63560080df4e967d5ed47cb7fd9efa