[INFO] fetching crate dinero-rs 0.33.3-dev... [INFO] checking dinero-rs-0.33.3-dev against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dinero-rs 0.33.3-dev into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate dinero-rs 0.33.3-dev on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dinero-rs 0.33.3-dev [INFO] finished tweaking crates.io crate dinero-rs 0.33.3-dev [INFO] tweaked toml for crates.io crate dinero-rs 0.33.3-dev written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate dinero-rs 0.33.3-dev already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 790eb77487269ae41287bbc4ceff7a3c41e5f25e8062f7258cd8d4fe64f5115a [INFO] running `Command { std: "docker" "start" "-a" "790eb77487269ae41287bbc4ceff7a3c41e5f25e8062f7258cd8d4fe64f5115a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "790eb77487269ae41287bbc4ceff7a3c41e5f25e8062f7258cd8d4fe64f5115a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "790eb77487269ae41287bbc4ceff7a3c41e5f25e8062f7258cd8d4fe64f5115a", kill_on_drop: false }` [INFO] [stdout] 790eb77487269ae41287bbc4ceff7a3c41e5f25e8062f7258cd8d4fe64f5115a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c53261f964d93ce9715eacb518c3a7a9f97a782e4920a76aa7e4098944f9700 [INFO] running `Command { std: "docker" "start" "-a" "5c53261f964d93ce9715eacb518c3a7a9f97a782e4920a76aa7e4098944f9700", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Checking termtree v0.2.3 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking predicates-tree v1.0.4 [INFO] [stderr] Checking predicates v2.1.0 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking nix v0.20.2 [INFO] [stderr] Checking fd-lock v2.0.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking shellexpand v2.1.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking rustyline v8.2.0 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking pidgin v0.4.3 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking assert_cmd v2.0.2 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking two_timer v2.2.3 [INFO] [stderr] Checking dinero-rs v0.33.3-dev (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commands/roi.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | let mut period = &mut periods[index]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commands/roi.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | let mut period = &mut periods[index]; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/app.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct CommonOpts { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 105 | args_only: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | init_file: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | period: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 127 | #[structopt(long = "now", parse(try_from_str = date_parser))] [INFO] [stdout] 128 | now: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | force_pager: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | effective: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | unrealized_gains: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 169 | unrealized_losses: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommonOpts` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `note` is never read [INFO] [stdout] --> src/models/payee.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Payee { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 12 | name: String, [INFO] [stdout] 13 | note: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Payee` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NodeEdge` is never constructed [INFO] [stdout] --> src/models/price.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 174 | struct NodeEdge { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:121:67 [INFO] [stdout] | [INFO] [stdout] 121 | #[structopt(short = "b", long = "begin", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:123:65 [INFO] [stdout] | [INFO] [stdout] 123 | #[structopt(short = "e", long = "end", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:127:52 [INFO] [stdout] | [INFO] [stdout] 127 | #[structopt(long = "now", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:90:56 [INFO] [stdout] | [INFO] [stdout] 90 | .fold(Balance::new(), |acc, new| acc + new.1.clone()); [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|x| (*x.0, x.1.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:136:47 [INFO] [stdout] | [INFO] [stdout] 136 | .map(|x| (x.0.get_name(), x.1.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:272:50 [INFO] [stdout] | [INFO] [stdout] 272 | .fold(Balance::new(), |acc, x| acc + x.1.to_owned()); [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:363:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn to_ledger(mut self, options: &CommonOpts) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut commodity_strs = HashSet::::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let mut account_strs = HashSet::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut payee_strs = HashSet::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let payees_copy = self.payees.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let mut prices: Vec = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut transactions = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut balances: HashMap, Balance> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | Ok(Ledger { [INFO] [stdout] | ____________^ [INFO] [stdout] 364 | | accounts: self.accounts, [INFO] [stdout] 365 | | commodities: self.commodities, [INFO] [stdout] 366 | | transactions, [INFO] [stdout] ... | [INFO] [stdout] 369 | | files: self.files, [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 378 | let mut prices = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | let mut transactions = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok(TransactionTransformer { [INFO] [stdout] | ____________^ [INFO] [stdout] 492 | | ledger_transactions: transactions, [INFO] [stdout] 493 | | raw_transactions: automated_transactions, [INFO] [stdout] 494 | | prices, [INFO] [stdout] 495 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/balance.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 125 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut total: HashMap>, Money> = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let balances = vec![self, rhs]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | balance: total.into_iter().filter(|(_, v)| !v.is_zero()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/money.rs:195:23 [INFO] [stdout] | [INFO] [stdout] 191 | fn from(cur_amount: (Currency, BigRational)) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let (currency, amount) = cur_amount; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | currency: Rc::new(currency), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/price.rs:274:20 [INFO] [stdout] | [INFO] [stdout] 189 | fn from_prices(prices: &[Price], source: Node) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut nodes = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let mut edges = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut currency_dates = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut prices_nodup = HashMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let vec_node: Vec> = nodes.iter().map(|x| x.1.clone()).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | nodes: nodes.iter().map(|x| x.1.clone()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tokenizers/payee.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|x| Regex::new(x.clone().as_str()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:518:14 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_binary_expr(operation: Binary, lhs: Node, rhs: Node) -> Node { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:519:14 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_binary_expr(operation: Binary, lhs: Node, rhs: Node) -> Node { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:526:16 [INFO] [stdout] | [INFO] [stdout] 523 | fn parse_unary_expr(operation: Unary, child: Node) -> Node { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | child: Box::new(child), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dinero-rs` (lib) due to 17 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/app.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct CommonOpts { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 105 | args_only: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | init_file: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | period: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 127 | #[structopt(long = "now", parse(try_from_str = date_parser))] [INFO] [stdout] 128 | now: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | force_pager: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | effective: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | unrealized_gains: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 169 | unrealized_losses: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommonOpts` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `note` is never read [INFO] [stdout] --> src/models/payee.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Payee { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 12 | name: String, [INFO] [stdout] 13 | note: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Payee` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NodeEdge` is never constructed [INFO] [stdout] --> src/models/price.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 174 | struct NodeEdge { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:121:67 [INFO] [stdout] | [INFO] [stdout] 121 | #[structopt(short = "b", long = "begin", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:123:65 [INFO] [stdout] | [INFO] [stdout] 123 | #[structopt(short = "e", long = "end", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:127:52 [INFO] [stdout] | [INFO] [stdout] 127 | #[structopt(long = "now", parse(try_from_str = date_parser))] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:90:56 [INFO] [stdout] | [INFO] [stdout] 90 | .fold(Balance::new(), |acc, new| acc + new.1.clone()); [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:96:29 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|x| (*x.0, x.1.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:136:47 [INFO] [stdout] | [INFO] [stdout] 136 | .map(|x| (x.0.get_name(), x.1.clone())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/balance.rs:272:50 [INFO] [stdout] | [INFO] [stdout] 272 | .fold(Balance::new(), |acc, x| acc + x.1.to_owned()); [INFO] [stdout] | --- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:363:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn to_ledger(mut self, options: &CommonOpts) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut commodity_strs = HashSet::::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let mut account_strs = HashSet::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut payee_strs = HashSet::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let payees_copy = self.payees.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let mut prices: Vec = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut transactions = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let mut balances: HashMap, Balance> = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | Ok(Ledger { [INFO] [stdout] | ____________^ [INFO] [stdout] 364 | | accounts: self.accounts, [INFO] [stdout] 365 | | commodities: self.commodities, [INFO] [stdout] 366 | | transactions, [INFO] [stdout] ... | [INFO] [stdout] 369 | | files: self.files, [INFO] [stdout] 370 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 378 | let mut prices = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | let mut transactions = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok(TransactionTransformer { [INFO] [stdout] | ____________^ [INFO] [stdout] 492 | | ledger_transactions: transactions, [INFO] [stdout] 493 | | raw_transactions: automated_transactions, [INFO] [stdout] 494 | | prices, [INFO] [stdout] 495 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/balance.rs:152:22 [INFO] [stdout] | [INFO] [stdout] 125 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let mut total: HashMap>, Money> = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let balances = vec![self, rhs]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | balance: total.into_iter().filter(|(_, v)| !v.is_zero()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/money.rs:195:23 [INFO] [stdout] | [INFO] [stdout] 191 | fn from(cur_amount: (Currency, BigRational)) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let (currency, amount) = cur_amount; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | currency: Rc::new(currency), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/price.rs:274:20 [INFO] [stdout] | [INFO] [stdout] 189 | fn from_prices(prices: &[Price], source: Node) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let mut nodes = HashMap::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let mut edges = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let mut currency_dates = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let mut prices_nodup = HashMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let vec_node: Vec> = nodes.iter().map(|x| x.1.clone()).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | nodes: nodes.iter().map(|x| x.1.clone()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tokenizers/payee.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|x| Regex::new(x.clone().as_str()).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:518:14 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_binary_expr(operation: Binary, lhs: Node, rhs: Node) -> Node { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:519:14 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_binary_expr(operation: Binary, lhs: Node, rhs: Node) -> Node { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/value_expr.rs:526:16 [INFO] [stdout] | [INFO] [stdout] 523 | fn parse_unary_expr(operation: Unary, child: Node) -> Node { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | child: Box::new(child), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dinero-rs` (lib test) due to 17 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5c53261f964d93ce9715eacb518c3a7a9f97a782e4920a76aa7e4098944f9700", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c53261f964d93ce9715eacb518c3a7a9f97a782e4920a76aa7e4098944f9700", kill_on_drop: false }` [INFO] [stdout] 5c53261f964d93ce9715eacb518c3a7a9f97a782e4920a76aa7e4098944f9700