[INFO] fetching crate dill 0.9.1... [INFO] checking dill-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate dill 0.9.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate dill 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate dill 0.9.1 [INFO] finished tweaking crates.io crate dill 0.9.1 [INFO] tweaked toml for crates.io crate dill 0.9.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6bd4200382a2b72954876825444f8f5ca3b6019edf70f29699a1ad3912c9ba8f [INFO] running `Command { std: "docker" "start" "-a" "6bd4200382a2b72954876825444f8f5ca3b6019edf70f29699a1ad3912c9ba8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6bd4200382a2b72954876825444f8f5ca3b6019edf70f29699a1ad3912c9ba8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bd4200382a2b72954876825444f8f5ca3b6019edf70f29699a1ad3912c9ba8f", kill_on_drop: false }` [INFO] [stdout] 6bd4200382a2b72954876825444f8f5ca3b6019edf70f29699a1ad3912c9ba8f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c1c2cc96a3385e7da001d5a5eda3ab6cfbdf2ec3560627af9a9d8a08561b231 [INFO] running `Command { std: "docker" "start" "-a" "8c1c2cc96a3385e7da001d5a5eda3ab6cfbdf2ec3560627af9a9d8a08561b231", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling dill-impl v0.9.1 [INFO] [stderr] Checking multimap v0.10.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking dill v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:258:20 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn new(factory: Fct) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Self { [INFO] [stdout] 258 | state: Mutex::new(LazyState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 259 | | factory: Some(factory), [INFO] [stdout] 260 | | instance: None, [INFO] [stdout] 261 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog_builder.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | cast_arc: |v| v.downcast().unwrap(), [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog_builder.rs:141:42 [INFO] [stdout] | [INFO] [stdout] 137 | let mut builders = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut bindings = MultiMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Catalog::new(builders, bindings, self.chained_catalog.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 31 | builders: HashMap>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | bindings: MultiMap, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | chained_catalog: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> Self { [INFO] [stdout] 35 | Self(Arc::new(CatalogInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 36 | | builders, [INFO] [stdout] 37 | | bindings, [INFO] [stdout] 38 | | chained_catalog, [INFO] [stdout] 39 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecast_builder.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | let inst = self.builder.get(cat)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok((self.caster.cast_arc)(inst)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:258:20 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn new(factory: Fct) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | Self { [INFO] [stdout] 258 | state: Mutex::new(LazyState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 259 | | factory: Some(factory), [INFO] [stdout] 260 | | instance: None, [INFO] [stdout] 261 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog_builder.rs:76:35 [INFO] [stdout] | [INFO] [stdout] 76 | cast_arc: |v| v.downcast().unwrap(), [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog_builder.rs:141:42 [INFO] [stdout] | [INFO] [stdout] 137 | let mut builders = HashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut bindings = MultiMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Catalog::new(builders, bindings, self.chained_catalog.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 31 | builders: HashMap>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | bindings: MultiMap, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | chained_catalog: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> Self { [INFO] [stdout] 35 | Self(Arc::new(CatalogInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 36 | | builders, [INFO] [stdout] 37 | | bindings, [INFO] [stdout] 38 | | chained_catalog, [INFO] [stdout] 39 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dill` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/typecast_builder.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | let inst = self.builder.get(cat)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok((self.caster.cast_arc)(inst)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dill` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8c1c2cc96a3385e7da001d5a5eda3ab6cfbdf2ec3560627af9a9d8a08561b231", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c1c2cc96a3385e7da001d5a5eda3ab6cfbdf2ec3560627af9a9d8a08561b231", kill_on_drop: false }` [INFO] [stdout] 8c1c2cc96a3385e7da001d5a5eda3ab6cfbdf2ec3560627af9a9d8a08561b231