[INFO] fetching crate digital_test_runner 0.1.0... [INFO] checking digital_test_runner-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate digital_test_runner 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate digital_test_runner 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate digital_test_runner 0.1.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate digital_test_runner 0.1.0 [INFO] tweaked toml for crates.io crate digital_test_runner 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate digital_test_runner 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18514a74bc10fef6628319a95795334dfea1d060038281cf9de3c30f0595a9cf [INFO] running `Command { std: "docker" "start" "-a" "18514a74bc10fef6628319a95795334dfea1d060038281cf9de3c30f0595a9cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18514a74bc10fef6628319a95795334dfea1d060038281cf9de3c30f0595a9cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18514a74bc10fef6628319a95795334dfea1d060038281cf9de3c30f0595a9cf", kill_on_drop: false }` [INFO] [stdout] 18514a74bc10fef6628319a95795334dfea1d060038281cf9de3c30f0595a9cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17d3a1288bf101ea7f7d14002cd688dd3918543fd04af34eda1115b83e8c4458 [INFO] running `Command { std: "docker" "start" "-a" "17d3a1288bf101ea7f7d14002cd688dd3918543fd04af34eda1115b83e8c4458", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.156 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking object v0.36.3 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling indexmap v2.4.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Compiling rstest_macros v0.21.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking which v6.0.2 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling logos-codegen v0.14.1 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling logos-derive v0.14.1 [INFO] [stderr] Checking logos v0.14.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking digital_test_runner v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:407:18 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn output(name: impl Into, bits: usize) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | typ: SignalType::Output, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:416:18 [INFO] [stdout] | [INFO] [stdout] 412 | pub fn input(name: impl Into, bits: usize, default: impl Into) -> Self { [INFO] [stdout] | ----------------------- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | typ: SignalType::Input { [INFO] [stdout] | __________________^ [INFO] [stdout] 417 | | default: default.into(), [INFO] [stdout] 418 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:431:18 [INFO] [stdout] | [INFO] [stdout] 424 | name: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | bits: usize, [INFO] [stdout] 426 | default: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | typ: SignalType::Bidirectional { [INFO] [stdout] | __________________^ [INFO] [stdout] 432 | | default: default.into(), [INFO] [stdout] 433 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dig.rs:219:12 [INFO] [stdout] | [INFO] [stdout] 121 | let doc = roxmltree::Document::parse(input).map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let output_signals = visual_elements(&doc, &["Out"]) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let inputs_signals = visual_elements(&doc, &["In", "Clock"]) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let signals = Vec::from_iter(inputs_signals.chain(output_signals)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let mut test_signal_names: HashSet = HashSet::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut bidirectional: HashSet = HashSet::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let signal_names: HashSet = signals.iter().map(|s| s.name.clone()).collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let mut signals = signals; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | Ok(File { [INFO] [stdout] | ____________^ [INFO] [stdout] 220 | | signals, [INFO] [stdout] 221 | | test_cases, [INFO] [stdout] 222 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dig.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | typ: SignalType::Output, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dig.rs:150:22 [INFO] [stdout] | [INFO] [stdout] 150 | typ: SignalType::Input { default }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dig.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | File::parse(&input).map_err(|DigFileError(err)| match err { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_row_iterator.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 96 | let mut test_data = DataRowIteratorTestData::new(test_case); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | ctx, [INFO] [stdout] 106 | | test_data, [INFO] [stdout] 107 | | driver, [INFO] [stdout] 108 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `digital_test_runner` (lib) due to 14 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval_context.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 72 | range: R, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> i64 { [INFO] [stdout] 74 | self.rng.borrow_mut().gen_range(range) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_test_case.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn with_signals(mut self, mut signals: Vec) -> Result { [INFO] [stdout] | -------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(TestCase { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | stmts: self.stmts, [INFO] [stdout] 55 | | signals, [INFO] [stdout] 56 | | input_indices, [INFO] [stdout] 57 | | expected_indices, [INFO] [stdout] 58 | | read_outputs, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsed_test_case.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 38 | signals.extend(self.virtual_signals.drain(..).map(|(virt, _)| Signal { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | typ: SignalType::Virtual { [INFO] [stdout] | __________________^ [INFO] [stdout] 42 | | expr: VirtualExpr { [INFO] [stdout] 43 | | expr: Box::new(virt.expr), [INFO] [stdout] 44 | | }, [INFO] [stdout] 45 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:205:21 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|(name, (span, expr))| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | ( [INFO] [stdout] 205 | / VirtualSignal { [INFO] [stdout] 206 | | name: name.to_string(), [INFO] [stdout] 207 | | expr, [INFO] [stdout] 208 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expr.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 71 | let first = self.parse_factor()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let mut tree = BinOpTree::Atom(first); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(tree.into()) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "17d3a1288bf101ea7f7d14002cd688dd3918543fd04af34eda1115b83e8c4458", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17d3a1288bf101ea7f7d14002cd688dd3918543fd04af34eda1115b83e8c4458", kill_on_drop: false }` [INFO] [stdout] 17d3a1288bf101ea7f7d14002cd688dd3918543fd04af34eda1115b83e8c4458