[INFO] crate digest 0.11.0-pre.9 is already in cache [INFO] checking digest-0.11.0-pre.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate digest 0.11.0-pre.9 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate digest 0.11.0-pre.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate digest 0.11.0-pre.9 [INFO] finished tweaking crates.io crate digest 0.11.0-pre.9 [INFO] tweaked toml for crates.io crate digest 0.11.0-pre.9 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f63a045f80bcd856c2972edc6264f4f22d62f73762fa78452b3c38fd17cb4fe [INFO] running `Command { std: "docker" "start" "-a" "8f63a045f80bcd856c2972edc6264f4f22d62f73762fa78452b3c38fd17cb4fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f63a045f80bcd856c2972edc6264f4f22d62f73762fa78452b3c38fd17cb4fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f63a045f80bcd856c2972edc6264f4f22d62f73762fa78452b3c38fd17cb4fe", kill_on_drop: false }` [INFO] [stdout] 8f63a045f80bcd856c2972edc6264f4f22d62f73762fa78452b3c38fd17cb4fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5de245b8bde1b1a42c21ffecdfc2025786be88774b8c792b7737d7aee7048a81 [INFO] running `Command { std: "docker" "start" "-a" "5de245b8bde1b1a42c21ffecdfc2025786be88774b8c792b7737d7aee7048a81", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking hybrid-array v0.2.0-rc.9 [INFO] [stderr] Checking crypto-common v0.2.0-rc.1 [INFO] [stderr] Checking block-buffer v0.11.0-rc.1 [INFO] [stderr] Checking digest v0.11.0-pre.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 85 | let buffer = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | T::new(output_size.into()).map(|core| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 85 | let buffer = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | T::new(output_size.into()).map(|core| Self { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 87 | | core, [INFO] [stdout] 88 | | buffer, [INFO] [stdout] 89 | | output_size, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 159 | let serialized_core = self.core.serialize(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let serialized_pos = Array([self.buffer.get_pos().try_into().unwrap()]); [INFO] [stdout] 161 | let serialized_data = self.buffer.clone().pad_with_zeros(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | / serialized_core [INFO] [stdout] 165 | | .concat(serialized_pos) [INFO] [stdout] 166 | | .concat(serialized_data) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:129:19 [INFO] [stdout] | [INFO] [stdout] 127 | fn finalize_xof(mut self) -> Self::Reader { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Self::Reader { [INFO] [stdout] 129 | core: self.core.finalize_xof_core(&mut self.buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 127 | fn finalize_xof(mut self) -> Self::Reader { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | buffer: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 199 | let serialized_core = self.core.serialize(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let serialized_pos = Array([self.buffer.get_pos().try_into().unwrap()]); [INFO] [stdout] 201 | let serialized_data = self.buffer.clone().pad_with_zeros(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | [INFO] [stdout] 203 | / serialized_core [INFO] [stdout] 204 | | .concat(serialized_pos) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest.rs:200:18 [INFO] [stdout] | [INFO] [stdout] 197 | fn finalize_into(self, buf: &mut [u8]) -> Result<(), InvalidBufferSize> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | .map(|buf| FixedOutput::finalize_into(self, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `digest` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 85 | let buffer = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | T::new(output_size.into()).map(|core| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 85 | let buffer = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | T::new(output_size.into()).map(|core| Self { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 87 | | core, [INFO] [stdout] 88 | | buffer, [INFO] [stdout] 89 | | output_size, [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/rt_variable.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 159 | let serialized_core = self.core.serialize(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let serialized_pos = Array([self.buffer.get_pos().try_into().unwrap()]); [INFO] [stdout] 161 | let serialized_data = self.buffer.clone().pad_with_zeros(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | / serialized_core [INFO] [stdout] 165 | | .concat(serialized_pos) [INFO] [stdout] 166 | | .concat(serialized_data) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:129:19 [INFO] [stdout] | [INFO] [stdout] 127 | fn finalize_xof(mut self) -> Self::Reader { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | Self::Reader { [INFO] [stdout] 129 | core: self.core.finalize_xof_core(&mut self.buffer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 127 | fn finalize_xof(mut self) -> Self::Reader { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | buffer: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core_api/wrapper.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 199 | let serialized_core = self.core.serialize(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let serialized_pos = Array([self.buffer.get_pos().try_into().unwrap()]); [INFO] [stdout] 201 | let serialized_data = self.buffer.clone().pad_with_zeros(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | [INFO] [stdout] 203 | / serialized_core [INFO] [stdout] 204 | | .concat(serialized_pos) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest.rs:200:18 [INFO] [stdout] | [INFO] [stdout] 197 | fn finalize_into(self, buf: &mut [u8]) -> Result<(), InvalidBufferSize> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | .map(|buf| FixedOutput::finalize_into(self, buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `digest` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "5de245b8bde1b1a42c21ffecdfc2025786be88774b8c792b7737d7aee7048a81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5de245b8bde1b1a42c21ffecdfc2025786be88774b8c792b7737d7aee7048a81", kill_on_drop: false }` [INFO] [stdout] 5de245b8bde1b1a42c21ffecdfc2025786be88774b8c792b7737d7aee7048a81