[INFO] fetching crate diffus 0.10.0... [INFO] checking diffus-0.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diffus 0.10.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate diffus 0.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diffus 0.10.0 [INFO] finished tweaking crates.io crate diffus 0.10.0 [INFO] tweaked toml for crates.io crate diffus 0.10.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 830f3ddc940335dd839fbc67dfe4a73bf79613f1d3a1e190492c7989a910f619 [INFO] running `Command { std: "docker" "start" "-a" "830f3ddc940335dd839fbc67dfe4a73bf79613f1d3a1e190492c7989a910f619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "830f3ddc940335dd839fbc67dfe4a73bf79613f1d3a1e190492c7989a910f619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "830f3ddc940335dd839fbc67dfe4a73bf79613f1d3a1e190492c7989a910f619", kill_on_drop: false }` [INFO] [stdout] 830f3ddc940335dd839fbc67dfe4a73bf79613f1d3a1e190492c7989a910f619 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f6d26cd08e403790a8faca97d62d51fcaba973eca883ce6128ede2ab48eb065 [INFO] running `Command { std: "docker" "start" "-a" "3f6d26cd08e403790a8faca97d62d51fcaba973eca883ce6128ede2ab48eb065", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking diffus v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(k, v)| (k, map::Edit::Insert(v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:23:61 [INFO] [stdout] | [INFO] [stdout] 23 | .chain(unique_self.map(|(k, v)| (k, map::Edit::Remove(v)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:24:78 [INFO] [stdout] | [INFO] [stdout] 24 | .chain(intersection.map(|(k, (self_v, other_v))| (k, self_v.diff(other_v).into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 71 | mut x: itertools::PutBack>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | mut y: itertools::PutBack>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / std::iter::from_fn(move || { [INFO] [stdout] 78 | | let current_x = x.next(); [INFO] [stdout] 79 | | let current_y = y.next(); [INFO] [stdout] ... | [INFO] [stdout] 110 | | .collect::>() [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 121 | x: impl Fn() -> I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | y: impl Fn() -> J, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / x().zip(y()) [INFO] [stdout] 129 | | .take(prefix_eq) [INFO] [stdout] 130 | | .map(|(x, y)| Edit::Same(x, y)) [INFO] [stdout] 131 | | .chain(lcs_base( [INFO] [stdout] ... | [INFO] [stdout] 142 | | ), [INFO] [stdout] 143 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 121 | x: impl Fn() -> I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | y: impl Fn() -> J, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / x().skip(x_len - suffix_eq) [INFO] [stdout] 146 | | .zip(y().skip(y_len - suffix_eq)) [INFO] [stdout] 147 | | .map(|(x, y)| Edit::Same(x, y)), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diffus` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/diffable_impls/borrow.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | if let edit::Edit::Change(diff) = Box::new(left).diff(&Box::new(right)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(k, v)| (k, map::Edit::Insert(v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:23:61 [INFO] [stdout] | [INFO] [stdout] 23 | .chain(unique_self.map(|(k, v)| (k, map::Edit::Remove(v)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diffable_impls/map.rs:24:78 [INFO] [stdout] | [INFO] [stdout] 24 | .chain(intersection.map(|(k, (self_v, other_v))| (k, self_v.diff(other_v).into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | / map_impl! { [INFO] [stdout] 43 | | (BTreeMap, Ord), [INFO] [stdout] 44 | | (HashMap, Hash) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `map_impl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 71 | mut x: itertools::PutBack>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | mut y: itertools::PutBack>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / std::iter::from_fn(move || { [INFO] [stdout] 78 | | let current_x = x.next(); [INFO] [stdout] 79 | | let current_y = y.next(); [INFO] [stdout] ... | [INFO] [stdout] 110 | | .collect::>() [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 121 | x: impl Fn() -> I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | y: impl Fn() -> J, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / x().zip(y()) [INFO] [stdout] 129 | | .take(prefix_eq) [INFO] [stdout] 130 | | .map(|(x, y)| Edit::Same(x, y)) [INFO] [stdout] 131 | | .chain(lcs_base( [INFO] [stdout] ... | [INFO] [stdout] 142 | | ), [INFO] [stdout] 143 | | )) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lcs.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 121 | x: impl Fn() -> I, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | y: impl Fn() -> J, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / x().skip(x_len - suffix_eq) [INFO] [stdout] 146 | | .zip(y().skip(y_len - suffix_eq)) [INFO] [stdout] 147 | | .map(|(x, y)| Edit::Same(x, y)), [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diffus` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3f6d26cd08e403790a8faca97d62d51fcaba973eca883ce6128ede2ab48eb065", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f6d26cd08e403790a8faca97d62d51fcaba973eca883ce6128ede2ab48eb065", kill_on_drop: false }` [INFO] [stdout] 3f6d26cd08e403790a8faca97d62d51fcaba973eca883ce6128ede2ab48eb065