[INFO] fetching crate difftastic-lib 0.0.2... [INFO] checking difftastic-lib-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate difftastic-lib 0.0.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate difftastic-lib 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate difftastic-lib 0.0.2 [INFO] finished tweaking crates.io crate difftastic-lib 0.0.2 [INFO] tweaked toml for crates.io crate difftastic-lib 0.0.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate difftastic-lib 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19f7416293ad623f88d73a7ada29cc75b329f069a84e6256089df7e1a1c71a6e [INFO] running `Command { std: "docker" "start" "-a" "19f7416293ad623f88d73a7ada29cc75b329f069a84e6256089df7e1a1c71a6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19f7416293ad623f88d73a7ada29cc75b329f069a84e6256089df7e1a1c71a6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19f7416293ad623f88d73a7ada29cc75b329f069a84e6256089df7e1a1c71a6e", kill_on_drop: false }` [INFO] [stdout] 19f7416293ad623f88d73a7ada29cc75b329f069a84e6256089df7e1a1c71a6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bec32786d119f9359a478a3d51b2a4f5043013caf3e23c0e04391c9661bc33b6 [INFO] running `Command { std: "docker" "start" "-a" "bec32786d119f9359a478a3d51b2a4f5043013caf3e23c0e04391c9661bc33b6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling io-lifetimes v0.7.3 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling rustix v0.35.9 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Checking os_str_bytes v6.0.1 [INFO] [stderr] Checking fixedbitset v0.4.1 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Checking archery v0.4.0 [INFO] [stderr] Checking bytecount v0.6.2 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking wu-diff v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking rpds v0.10.0 [INFO] [stderr] Checking owo-colors v3.4.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking bumpalo v3.9.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking radix-heap v0.4.2 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking petgraph v0.6.1 [INFO] [stderr] Compiling const_format_proc_macros v0.2.22 [INFO] [stderr] Compiling libmimalloc-sys v0.1.24 [INFO] [stderr] Compiling tree-sitter v0.20.6 [INFO] [stderr] Checking pretty_assertions v1.2.1 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking const_format v0.2.23 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking mimalloc v0.1.28 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking tree_magic_mini v3.0.3 [INFO] [stderr] Checking terminal_size v0.2.1 [INFO] [stderr] Compiling difftastic-lib v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Vertex<'_, '_>` instead of cloning the inner type [INFO] [stdout] --> src/diff/dijkstra.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | res.push((edge, prev.clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff/graph.rs:227:18 [INFO] [stdout] | [INFO] [stdout] 213 | let (mut lhs_delims, rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff/graph.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 235 | let (lhs_delims, mut rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/hunks.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | novel_lhs: self.novel_lhs.union(&other.novel_lhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/hunks.rs:71:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | novel_rhs: self.novel_rhs.union(&other.novel_rhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 17 | let lhs_res = fs::read(lhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let rhs_res = fs::read(rhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | match (lhs_res, rhs_res) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/parse/guess_language.rs:239:63 [INFO] [stdout] | [INFO] [stdout] 239 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/tree_sitter_parser.rs:800:5 [INFO] [stdout] | [INFO] [stdout] 795 | let mut parser = ts::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | parser.parse(src, None).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `difftastic-lib` (lib) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `LinePosition` is never constructed [INFO] [stdout] --> src/lines.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | struct LinePosition { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&graph::Vertex<'_, '_>` instead of cloning the inner type [INFO] [stdout] --> src/diff/dijkstra.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | res.push((edge, prev.clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff/graph.rs:227:18 [INFO] [stdout] | [INFO] [stdout] 213 | let (mut lhs_delims, rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff/graph.rs:249:18 [INFO] [stdout] | [INFO] [stdout] 235 | let (lhs_delims, mut rhs_delims) = match entered.peek() { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let entered = if modifying_head { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | entered.push(EnteredDelimiter::PopEither((lhs_delims, rhs_delims))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/hunks.rs:70:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | novel_lhs: self.novel_lhs.union(&other.novel_lhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/hunks.rs:71:24 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn merge(self, other: &Self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut lhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let mut rhs_seen: HashSet = HashSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | novel_rhs: self.novel_rhs.union(&other.novel_rhs).copied().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 17 | let lhs_res = fs::read(lhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let rhs_res = fs::read(rhs_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | match (lhs_res, rhs_res) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/parse/guess_language.rs:239:63 [INFO] [stdout] | [INFO] [stdout] 239 | let lang = match mode_name.to_ascii_lowercase().trim().borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/tree_sitter_parser.rs:800:5 [INFO] [stdout] | [INFO] [stdout] 795 | let mut parser = ts::Parser::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 800 | parser.parse(src, None).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/options.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | match display_mode_str.borrow() { [INFO] [stdout] | ^^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Borrow`, so calling `borrow` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `difftastic-lib` (lib test) due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bec32786d119f9359a478a3d51b2a4f5043013caf3e23c0e04391c9661bc33b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bec32786d119f9359a478a3d51b2a4f5043013caf3e23c0e04391c9661bc33b6", kill_on_drop: false }` [INFO] [stdout] bec32786d119f9359a478a3d51b2a4f5043013caf3e23c0e04391c9661bc33b6