[INFO] fetching crate diesele 0.1.0... [INFO] checking diesele-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diesele 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate diesele 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diesele 0.1.0 [INFO] finished tweaking crates.io crate diesele 0.1.0 [INFO] tweaked toml for crates.io crate diesele 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding diesel v2.1.6 (latest: v2.2.3) [INFO] [stderr] Adding diesel-async v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding diesel_derives v2.1.4 (latest: v2.2.3) [INFO] [stderr] Adding diesel_table_macro_syntax v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a4b8c127e90b84a2906e6aea193cdbab98d15a1c7051fd798f22c777a615a45 [INFO] running `Command { std: "docker" "start" "-a" "4a4b8c127e90b84a2906e6aea193cdbab98d15a1c7051fd798f22c777a615a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a4b8c127e90b84a2906e6aea193cdbab98d15a1c7051fd798f22c777a615a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a4b8c127e90b84a2906e6aea193cdbab98d15a1c7051fd798f22c777a615a45", kill_on_drop: false }` [INFO] [stdout] 4a4b8c127e90b84a2906e6aea193cdbab98d15a1c7051fd798f22c777a615a45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4eaa70b95a79557e1e52f8954cb6706b032e3daa5365fa58c93df5511094139 [INFO] running `Command { std: "docker" "start" "-a" "b4eaa70b95a79557e1e52f8954cb6706b032e3daa5365fa58c93df5511094139", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking scoped-futures v0.1.3 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sqlformat v0.2.4 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.1.0 [INFO] [stderr] Compiling diesel_derives v2.1.4 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking diesel v2.1.6 [INFO] [stderr] Checking diesel-async v0.4.1 [INFO] [stderr] Checking diesele v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn explain + Send>(query: Q) -> Explain { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Explain { [INFO] [stdout] 46 | query: Arc::new(Mutex::new(Some(query))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 57 | fn io_err(err: std::io::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Error::QueryBuilderError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 61 | fn get_old_contents(path: impl AsRef) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Some( [INFO] [stdout] 63 | std::fs::read_to_string(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 93 | let mut query = ReusableQuery { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / ExplainQuery(query) [INFO] [stdout] 102 | | .load::(conn) [INFO] [stdout] 103 | | .map(|result| { [INFO] [stdout] 104 | | query_plan_lines = result; [INFO] [stdout] 105 | | Err(Error::RollbackTransaction) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | query_plan_lines = result; [INFO] [stdout] 105 | Err(Error::RollbackTransaction) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesele` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn explain + Send>(query: Q) -> Explain { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Explain { [INFO] [stdout] 46 | query: Arc::new(Mutex::new(Some(query))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 57 | fn io_err(err: std::io::Error) -> Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Error::QueryBuilderError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 61 | fn get_old_contents(path: impl AsRef) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Some( [INFO] [stdout] 63 | std::fs::read_to_string(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 93 | let mut query = ReusableQuery { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | / ExplainQuery(query) [INFO] [stdout] 102 | | .load::(conn) [INFO] [stdout] 103 | | .map(|result| { [INFO] [stdout] 104 | | query_plan_lines = result; [INFO] [stdout] 105 | | Err(Error::RollbackTransaction) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | query_plan_lines = result; [INFO] [stdout] 105 | Err(Error::RollbackTransaction) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesele` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b4eaa70b95a79557e1e52f8954cb6706b032e3daa5365fa58c93df5511094139", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4eaa70b95a79557e1e52f8954cb6706b032e3daa5365fa58c93df5511094139", kill_on_drop: false }` [INFO] [stdout] b4eaa70b95a79557e1e52f8954cb6706b032e3daa5365fa58c93df5511094139