[INFO] fetching crate diesel_geometry 1.4.0... [INFO] checking diesel_geometry-1.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diesel_geometry 1.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate diesel_geometry 1.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diesel_geometry 1.4.0 [INFO] finished tweaking crates.io crate diesel_geometry 1.4.0 [INFO] tweaked toml for crates.io crate diesel_geometry 1.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding diesel v1.4.8 (latest: v2.2.3) [INFO] [stderr] Adding diesel_derives v1.4.1 (latest: v2.2.3) [INFO] [stderr] Adding dotenv v0.13.0 (latest: v0.15.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pq-sys v0.4.8 (latest: v0.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2a5bb3cca570d59affe59d2865473c1d3baa1cde51b89b90c1b57d910b54b23 [INFO] running `Command { std: "docker" "start" "-a" "c2a5bb3cca570d59affe59d2865473c1d3baa1cde51b89b90c1b57d910b54b23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2a5bb3cca570d59affe59d2865473c1d3baa1cde51b89b90c1b57d910b54b23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2a5bb3cca570d59affe59d2865473c1d3baa1cde51b89b90c1b57d910b54b23", kill_on_drop: false }` [INFO] [stdout] c2a5bb3cca570d59affe59d2865473c1d3baa1cde51b89b90c1b57d910b54b23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07b10e897a9fa3ac845ac5eafb1f8d218261df12072a2f98258383cc20d86c5c [INFO] running `Command { std: "docker" "start" "-a" "07b10e897a9fa3ac845ac5eafb1f8d218261df12072a2f98258383cc20d86c5c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling pq-sys v0.4.8 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking diesel v1.4.8 [INFO] [stderr] Checking diesel_geometry v1.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `pg::expression::dsl::*` [INFO] [stdout] --> src/expression/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pg::expression::dsl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::expression::bound::Bound` [INFO] [stdout] --> src/pg/types/geometric.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use diesel::expression::bound::Bound; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::expression::AsExpression` [INFO] [stdout] --> src/pg/types/geometric.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use diesel::expression::AsExpression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::sql_types::Nullable` [INFO] [stdout] --> src/pg/types/geometric.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use diesel::sql_types::Nullable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `expression::dsl::*` [INFO] [stdout] --> src/lib.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | pub use expression::dsl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pg::expression::dsl::*` [INFO] [stdout] --> src/expression/mod.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pg::expression::dsl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::expression::bound::Bound` [INFO] [stdout] --> src/pg/types/geometric.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use diesel::expression::bound::Bound; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::expression::AsExpression` [INFO] [stdout] --> src/pg/types/geometric.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use diesel::expression::AsExpression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `diesel::sql_types::Nullable` [INFO] [stdout] --> src/pg/types/geometric.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use diesel::sql_types::Nullable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/test_helpers.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | #[cfg_attr(feature = "clippy", allow(invalid_ref))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `postgres`, and `serde` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `expression::dsl::*` [INFO] [stdout] --> src/lib.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | pub use expression::dsl::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/test_helpers.rs:28:51 [INFO] [stdout] | [INFO] [stdout] 28 | Output::new(Vec::new(), unsafe { mem::uninitialized() }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg/expression/expression_methods.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn same_as(self: Self, other: T) -> SameAs [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | SameAs::new(self, other.as_expression()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg/expression/expression_methods.rs:76:34 [INFO] [stdout] | [INFO] [stdout] 72 | fn is_contained_by(self: Self, other: T) -> IsContainedBy [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | IsContainedBy::new(self, other.as_expression()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesel_geometry` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/pg/types/geometric.rs:167:31 [INFO] [stdout] | [INFO] [stdout] 167 | uuid.unwrap_err().description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `name`, and `location` are never read [INFO] [stdout] --> src/pg/types/geometric.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 232 | struct Item { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 233 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 234 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 235 | location: ::pg::types::geometric::PgPoint, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Item` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg/expression/expression_methods.rs:36:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn same_as(self: Self, other: T) -> SameAs [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | SameAs::new(self, other.as_expression()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg/expression/expression_methods.rs:76:34 [INFO] [stdout] | [INFO] [stdout] 72 | fn is_contained_by(self: Self, other: T) -> IsContainedBy [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | IsContainedBy::new(self, other.as_expression()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `&::MetadataLookup` does not permit being left uninitialized [INFO] [stdout] --> src/test_helpers.rs:28:46 [INFO] [stdout] | [INFO] [stdout] 28 | Output::new(Vec::new(), unsafe { mem::uninitialized() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: references must be non-null [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesel_geometry` (lib test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "07b10e897a9fa3ac845ac5eafb1f8d218261df12072a2f98258383cc20d86c5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07b10e897a9fa3ac845ac5eafb1f8d218261df12072a2f98258383cc20d86c5c", kill_on_drop: false }` [INFO] [stdout] 07b10e897a9fa3ac845ac5eafb1f8d218261df12072a2f98258383cc20d86c5c