[INFO] fetching crate diesel_cockroach 0.1.1... [INFO] checking diesel_cockroach-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate diesel_cockroach 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate diesel_cockroach 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate diesel_cockroach 0.1.1 [INFO] finished tweaking crates.io crate diesel_cockroach 0.1.1 [INFO] tweaked toml for crates.io crate diesel_cockroach 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding ansi_term v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding diesel v1.4.8 (latest: v2.2.3) [INFO] [stderr] Adding diesel_derives v1.4.1 (latest: v2.2.3) [INFO] [stderr] Adding pq-sys v0.4.8 (latest: v0.6.1) [INFO] [stderr] Adding pretty_assertions v0.6.1 (latest: v1.4.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcef2d2c4e8bcf643d0127e0a123bc8afac2afd8ff341d04ee12e138993783cb [INFO] running `Command { std: "docker" "start" "-a" "dcef2d2c4e8bcf643d0127e0a123bc8afac2afd8ff341d04ee12e138993783cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcef2d2c4e8bcf643d0127e0a123bc8afac2afd8ff341d04ee12e138993783cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcef2d2c4e8bcf643d0127e0a123bc8afac2afd8ff341d04ee12e138993783cb", kill_on_drop: false }` [INFO] [stdout] dcef2d2c4e8bcf643d0127e0a123bc8afac2afd8ff341d04ee12e138993783cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc1facc2a96d442662c846a1f199fd66ae4fe33f85c8e3c5b6ea52c591b75788 [INFO] running `Command { std: "docker" "start" "-a" "fc1facc2a96d442662c846a1f199fd66ae4fe33f85c8e3c5b6ea52c591b75788", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling pq-sys v0.4.8 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Checking diesel v1.4.8 [INFO] [stderr] Checking diesel_cockroach v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upsert.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn values(self, records: U) -> UpsertStatement [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | UpsertStatement::new(self.target, records.values()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesel_cockroach` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upsert.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn values(self, records: U) -> UpsertStatement [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | UpsertStatement::new(self.target, records.values()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diesel_cockroach` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "fc1facc2a96d442662c846a1f199fd66ae4fe33f85c8e3c5b6ea52c591b75788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc1facc2a96d442662c846a1f199fd66ae4fe33f85c8e3c5b6ea52c591b75788", kill_on_drop: false }` [INFO] [stdout] fc1facc2a96d442662c846a1f199fd66ae4fe33f85c8e3c5b6ea52c591b75788